Re: [DISCUSS] Open Telemetry with ActiveMQ

2022-01-12 Thread Nabwegamo Brenda
> > > >>>> > > On Wed, Dec 29, 2021 at 12:44 PM Nabwegamo Brenda < >>>> brenser...@gmail.com> >>>> > > wrote: >>>> > > >>>> > >> Thanks Michael for your previous comments. >>>> > &

Re: [DISCUSS] Open Telemetry with ActiveMQ

2022-01-06 Thread Nabwegamo Brenda
>>> > >> have understood the previous comments. >>> > >> >>> > >> On Wed, Dec 29, 2021 at 1:50 AM michael.andre.pearce >>> > >> wrote: >>> > >> >>> > >>> Left commentsTwo main feedback themes1

Re: [DISCUSS] Open Telemetry with ActiveMQ

2022-01-06 Thread Nabwegamo Brenda
> wrote: >> > >> >> > >>> Left commentsTwo main feedback themes1) plugin should not be >> > >>> touching/changing any core code the whole point is that a user >> simply >> > >>> implements plugin inde

Re: [DISCUSS] Open Telemetry with ActiveMQ

2022-01-06 Thread Nabwegamo Brenda
sly > > >>> mentioned it should not be having dependency to specific vendor > exporter > > >>> this is whole point of open telemetry that you plug/ code to open > telemetry > > >>> apis and then simply swap different exporters depending on tracing > vendor

Re: [DISCUSS] Open Telemetry with ActiveMQ

2022-01-04 Thread Clebert Suconic
to broker.2) Dependency, as previously > >>> mentioned it should not be having dependency to specific vendor exporter > >>> this is whole point of open telemetry that you plug/ code to open > >>> telemetry > >>> apis and then simply swap differ

Re: [DISCUSS] Open Telemetry with ActiveMQ

2021-12-30 Thread Nabwegamo Brenda
apis and then simply swap different exporters depending on tracing vendor >>> selection of end user infra.Sent from my Galaxy >>> ---- Original message ----From: Nabwegamo Brenda < >>> brenser...@gmail.com> Date: 28/12/2021 14:06 (GMT+00:00) To: >>>

Re: [DISCUSS] Open Telemetry with ActiveMQ

2021-12-30 Thread Nabwegamo Brenda
> apis and then simply swap different exporters depending on tracing vendor >> selection of end user infra.Sent from my Galaxy >> Original message From: Nabwegamo Brenda < >> brenser...@gmail.com> Date: 28/12/2021 14:06 (GMT+00:00) To: >> dev@activ

Re: [DISCUSS] Open Telemetry with ActiveMQ

2021-12-29 Thread Nabwegamo Brenda
28/12/2021 14:06 (GMT+00:00) To: > dev@activemq.apache.org Subject: Re: [DISCUSS] Open Telemetry with > ActiveMQ Hello once again!I have created the first sample on my branch ( > https://github.com/apache/activemq-artemis/commit/6042beac67a5ab48f6b8b930c528790695eb7e82) > but i st

Re: [DISCUSS] Open Telemetry with ActiveMQ

2021-12-28 Thread michael.andre.pearce
@activemq.apache.org Subject: Re: [DISCUSS] Open Telemetry with ActiveMQ Hello once again!I have created the first  sample on my branch (https://github.com/apache/activemq-artemis/commit/6042beac67a5ab48f6b8b930c528790695eb7e82) but i still have questions about its logic. I think I have tried toimplement most

Re: [DISCUSS] Open Telemetry with ActiveMQ

2021-12-28 Thread Nabwegamo Brenda
Hello once again! I have created the first sample on my branch ( https://github.com/apache/activemq-artemis/commit/6042beac67a5ab48f6b8b930c528790695eb7e82 ) but i still have questions about its logic. I think I have tried to implement most of the suggestions and I kindly request for your review.

Re: [DISCUSS] Open Telemetry with ActiveMQ

2021-12-27 Thread Nabwegamo Brenda
> just should be done so that we supply the plugin to api but users should > > add the appropriate agent as they need. Sent from my Galaxy > > Original message From: Clebert Suconic < > > clebert.suco...@gmail.com> Date: 23/12/2021 14:08 (GMT+00:00) To:

Re: [DISCUSS] Open Telemetry with ActiveMQ

2021-12-25 Thread Clebert Suconic
--From: Clebert Suconic < > clebert.suco...@gmail.com> Date: 23/12/2021 14:08 (GMT+00:00) To: > dev@activemq.apache.org Subject: Re: [DISCUSS] Open Telemetry with > ActiveMQ Jaeger will accept Zipkin packets.. if you write zipkin it should > workwith either Jaeger or Zipkin... so

Re: [DISCUSS] Open Telemetry with ActiveMQ

2021-12-24 Thread michael.andre.pearce
d the appropriate agent as they need. Sent from my Galaxy Original message From: Clebert Suconic Date: 23/12/2021 14:08 (GMT+00:00) To: dev@activemq.apache.org Subject: Re: [DISCUSS] Open Telemetry with ActiveMQ Jaeger will accept Zipkin packets.. if you write zipkin it s

Re: [DISCUSS] Open Telemetry with ActiveMQ

2021-12-23 Thread Clebert Suconic
Jaeger will accept Zipkin packets.. if you write zipkin it should work with either Jaeger or Zipkin... so I think it's very nice for a prototype. I think we could start working on making it ready for PR... create the appropriate sub-modules and proper tests. Is there any API that could receive