Re: HEADS-UP 2.25.1 Next week

2022-09-21 Thread Clebert Suconic
and I just removed the 2.x branch On Wed, Sep 21, 2022 at 8:20 AM Clebert Suconic wrote: > > Let’s do this as 2.x then? Probably 2.27. I’m cutting 2.26 today. > > On Tue, Sep 20, 2022 at 10:33 AM Robbie Gemmell > wrote: >> >> On the logging bit, I would note there are numerous cases of 2.x >>

Re: HEADS-UP 2.25.1 Next week

2022-09-21 Thread Clebert Suconic
Let’s do this as 2.x then? Probably 2.27. I’m cutting 2.26 today. On Tue, Sep 20, 2022 at 10:33 AM Robbie Gemmell wrote: > On the logging bit, I would note there are numerous cases of 2.x > releases adjusting stuff in ways that similarly needed specific > handling 'during a normal upgrade proc

Re: HEADS-UP 2.25.1 Next week

2022-09-20 Thread Robbie Gemmell
On the logging bit, I would note there are numerous cases of 2.x releases adjusting stuff in ways that similarly needed specific handling 'during a normal upgrade procedure' per https://activemq.apache.org/components/artemis/documentation/latest/versions.html. Even the existing logging bits have cl

Re: HEADS-UP 2.25.1 Next week

2022-09-20 Thread Robbie Gemmell
Yep if you want to you could certainly release a 2.26.0 from main instead of a 2.x branch in the current (essentially identical) state and create a branch later if/when actually needed. On Fri, 16 Sept 2022 at 14:35, Clebert Suconic wrote: > > hmmm... this is actually pointless.. (the 2.x branch

Re: HEADS-UP 2.25.1 Next week

2022-09-16 Thread Clebert Suconic
although I'm not 100% sure logging alone would warrant it becoming 3.0... although logging is coming to the branch soon, and I would prefer not having it waiting for releases... it's a significant improvement for how we develop the codebase. On Fri, Sep 16, 2022 at 11:40 AM Clebert Suconic wrot

Re: HEADS-UP 2.25.1 Next week

2022-09-16 Thread Clebert Suconic
On Fri, Sep 16, 2022 at 11:05 AM Justin Bertram wrote: > > In my opinion there is a bit of more work to do before 3.0 could be > released. For example: > > - Remove all deprecated methods, config, etc. (this is not a small amount > of work) > - Update all the config with the new inclusive terms

Re: HEADS-UP 2.25.1 Next week

2022-09-16 Thread Justin Bertram
In my opinion there is a bit of more work to do before 3.0 could be released. For example: - Remove all deprecated methods, config, etc. (this is not a small amount of work) - Update all the config with the new inclusive terms Personally I don't really see how we could do the logging change on

Re: HEADS-UP 2.25.1 Next week

2022-09-16 Thread Clebert Suconic
I won't revert the commit though.. I would rather just release from main, with next release as 2.26.0... I"m thinkin the new logging isn't also a breaking (3.0) change... we should keep it as 2.x perhaps... (not saying we can't start planning a serious 3.0 though) On Fri, Sep 16, 2022 at 10:37

Re: HEADS-UP 2.25.1 Next week

2022-09-16 Thread Gary Tully
The removal of the REST feature is the only breaking change, feature wise logging will be compatible and most won't care. I would suggest reverting the commit that requires a 3.0 : ARTEMIS-3987Removing ActiveMQ Artemis Rest from the codebase - commit e654eba and cutting the next release from mai

Re: HEADS-UP 2.25.1 Next week

2022-09-16 Thread Clebert Suconic
hmmm... this is actually pointless.. (the 2.x branch so far). I had to cherry-pick *everything* except to 1 commit: ARTEMIS-3987Removing ActiveMQ Artemis Rest from the codebase - commit e654eba We could definitely release from main right now... and I'm wondering if we shouldn't make the log

Re: HEADS-UP 2.25.1 Next week

2022-09-15 Thread Clebert Suconic
@Gary Tully unless you don't consider removing activemq-rest and changing the logging framework a change big enough to warrant a bump to 3.0. if the consensus is to keep main as 2.x we can certainly rename it back and do the release from main. I thought we should rename it based on these two things

Re: HEADS-UP 2.25.1 Next week

2022-09-15 Thread Clebert Suconic
maini is already 3.0... removed Rest, and soon the logging change will be put it in there... If I release from main now, it will be called 3.0, and we will have to do a 4.0 when we bring in the logging changes. So, I would rather cherry-pick stuff into 2.x (I will go ahead and remove 2.25.x now)

Re: HEADS-UP 2.25.1 Next week

2022-09-15 Thread Gary Tully
would it make sense to just cut 2.26.0 from main? On Wed, 14 Sept 2022 at 02:11, Clebert Suconic wrote: > > I am renaming the branch as 2.x (instead of 2.25.x). > > > Some of the candidates to cherry-pick categorize it as an enhancement, > so it would make the release next week to be named 2.26.0

Re: HEADS-UP 2.25.1 Next week

2022-09-13 Thread Clebert Suconic
I am renaming the branch as 2.x (instead of 2.25.x). Some of the candidates to cherry-pick categorize it as an enhancement, so it would make the release next week to be named 2.26.0 instead of 2.25.1) (same branch, just promoting it to 2.26 due to an enhancement being part of it). for that reaso