[GitHub] activemq-6 pull request: ACTIVEMQ6-6 - remove SPI usage

2014-12-08 Thread andytaylor
GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-6/pull/36

ACTIVEMQ6-6 - remove SPI usage

https://issues.apache.org/jira/browse/ACTIVEMQ6-6

Removed the jboss security implementations and also implemented the 
location of Transaction Managers using Service Loader and removed the jboss 
implementation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-6 master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-6/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit 78a34c3ca487ea54229f38ac44b22f088d32b2a5
Author: Andy Taylor andytay...@apache.org
Date:   2014-12-06T10:59:17Z

ACTIVEMQ6-6 - remove SPI usage

https://issues.apache.org/jira/browse/ACTIVEMQ6-6

Removed the jboss security implementations and also implemented the 
location of Transaction Managers using Service Loader and removed the jboss 
implementation.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (ACTIVEMQ6-6) Extract any JBoss SPI code replace with generic

2014-12-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ACTIVEMQ6-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237733#comment-14237733
 ] 

ASF GitHub Bot commented on ACTIVEMQ6-6:


GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-6/pull/36

ACTIVEMQ6-6 - remove SPI usage

https://issues.apache.org/jira/browse/ACTIVEMQ6-6

Removed the jboss security implementations and also implemented the 
location of Transaction Managers using Service Loader and removed the jboss 
implementation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-6 master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-6/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit 78a34c3ca487ea54229f38ac44b22f088d32b2a5
Author: Andy Taylor andytay...@apache.org
Date:   2014-12-06T10:59:17Z

ACTIVEMQ6-6 - remove SPI usage

https://issues.apache.org/jira/browse/ACTIVEMQ6-6

Removed the jboss security implementations and also implemented the 
location of Transaction Managers using Service Loader and removed the jboss 
implementation.




 Extract any JBoss SPI code replace with generic
 ---

 Key: ACTIVEMQ6-6
 URL: https://issues.apache.org/jira/browse/ACTIVEMQ6-6
 Project: Apache ActiveMQ 6
  Issue Type: Improvement
Reporter: Martyn Taylor
 Fix For: 6.0.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] activemq-6 pull request: Fixing issues with paging (browsing dep...

2014-12-08 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-6/pull/35


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (AMQ-5466) Lost persistent message sent to detached consumer before keepAliveInterval exceed

2014-12-08 Thread Nikolay Pakudin (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-5466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237828#comment-14237828
 ] 

Nikolay Pakudin commented on AMQ-5466:
--

Reason of the problem is that MQTT connector for ActiveMQ doesn't look at QoS 
flag for subscription. It contains the code below

QoS qoS;
if (message.propertyExists(QOS_PROPERTY_NAME)) {
int ordinal = message.getIntProperty(QOS_PROPERTY_NAME);
qoS = QoS.values()[ordinal];

} else {
qoS = message.isPersistent() ? QoS.AT_MOST_ONCE : QoS.AT_LEAST_ONCE;
}

So, to solve the problem is enough to set QoS for each message. If you use NMS:

For ActiveMQ 5.10

msg.Properties.SetInt(ActiveMQ.MQTT.QoS, 2);

For ActiveMQ 5.9

 msg.Properties.SetInt(QoSPropertyName, 2);

I'm not sure, that it's expected behavior - ignore QoS of subscription.

 Lost persistent message sent to detached consumer before keepAliveInterval 
 exceed
 -

 Key: AMQ-5466
 URL: https://issues.apache.org/jira/browse/AMQ-5466
 Project: ActiveMQ
  Issue Type: Bug
 Environment: Maс OS X 10.9.5
 apache-activemq-5.10.0
 java version 1.6.0_65 Java(TM) SE Runtime Environment (build 
 1.6.0_65-b14-462-11M4609) Java HotSpot(TM) 64-Bit Server VM (build 
 20.65-b04-462, mixed mode)
Reporter: Nikolay Pakudin

 What I do
 - There is a MQTT client - Android application. It connects to server and 
 creates topic.
 - Sent there message with all default settings and payload {name:1st 
 message} by ActiveMQ console. Message is successfully delivered. If open 
 Active Subscribers, enqueued = 1, and dequeued = 1
 - Turn on Airplane mode at Android, so there is no connection really, but 
 ActiveMQ still shows it in Active Subscribers.
 - Send message WITH checkbox Persistent delivery and payload 
 {name:persistent} If open Active Subscribers, enqueued = 2, and dequeued 
 = 2
 - Send message WITHOUT checkbox Persistent delivery and payload {name:not 
 persistent} If open Active Subscribers, enqueued = 3, and dequeued = 2
 - Turn off Airplane mode at Android, connection appears and only one message 
 is delivered - not persistent.
 What I tried
 - Restart ActiveMQ.
 - Send a few persistent and a few not persistent messages - not persistent 
 are delivered, persistent aren't
 - Delete ActiveMQ and extract again.
 - Rebuild Android application and clean all data at phone.
 Messages, sent after keepAliveInterval exceed are delivered successfully.
 I reproduced it at least 20 times.
 I found 
 http://activemq.2283324.n4.nabble.com/Random-persistent-messages-lost-tt3826331.html
  , but it seems, that I have the other problem.
 Configuration
 conf/activemq.xml - default, with change 1 line (twice added +nio)
 transportConnector name=mqtt+nio 
 uri=mqtt+nio://0.0.0.0:1883maximumConnections=1000amp;wireFormat.maxFrameSize=104857600/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] activemq-6 pull request: ACTIVEMQ6-9 - port to markdown

2014-12-08 Thread andytaylor
GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-6/pull/37

ACTIVEMQ6-9 - port to markdown

https://issues.apache.org/jira/browse/ACTIVEMQ6-9

remove the jboss jdocbook build and style and replace using plane markdown

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-6 markdown

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-6/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #37


commit 4245a6b4fe667021eb791543577ea9a4c99155a1
Author: Andy Taylor andytay...@apache.org
Date:   2014-12-04T15:25:29Z

ACTIVEMQ6-9 - port to markdown

https://issues.apache.org/jira/browse/ACTIVEMQ6-9

remove the jboss jdocbook build and style and replace using plane markdown




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (ACTIVEMQ6-9) Fix Documentation to remove any non ActiveMQ references / branding

2014-12-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ACTIVEMQ6-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237858#comment-14237858
 ] 

ASF GitHub Bot commented on ACTIVEMQ6-9:


GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-6/pull/37

ACTIVEMQ6-9 - port to markdown

https://issues.apache.org/jira/browse/ACTIVEMQ6-9

remove the jboss jdocbook build and style and replace using plane markdown

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-6 markdown

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-6/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #37


commit 4245a6b4fe667021eb791543577ea9a4c99155a1
Author: Andy Taylor andytay...@apache.org
Date:   2014-12-04T15:25:29Z

ACTIVEMQ6-9 - port to markdown

https://issues.apache.org/jira/browse/ACTIVEMQ6-9

remove the jboss jdocbook build and style and replace using plane markdown




 Fix Documentation to remove any non ActiveMQ references / branding
 --

 Key: ACTIVEMQ6-9
 URL: https://issues.apache.org/jira/browse/ACTIVEMQ6-9
 Project: Apache ActiveMQ 6
  Issue Type: Improvement
Reporter: Martyn Taylor
Assignee: Justin Bertram
 Fix For: 6.0.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMQ-5378) Initscript refactoring: setup function seems to be broken, removal of uneccessary files, fix various problems

2014-12-08 Thread Dejan Bosanac (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237879#comment-14237879
 ] 

Dejan Bosanac commented on AMQ-5378:


Hi Marc,

I cherry-picked and committed most of your changes. What I didn't commit is:

- default configuration - I still think sourcing the separate script is the way 
to go
- checkrunning changes -  the commands like browse, bstat, are not limited to 
only working with local broker (you can use --jmxurl to connect them to remote 
ones), so it's not a job of a script to check if broker is running locally. We 
need to improve implementation of these commands, which should be done under a 
new Jira
- changing the name of pid files - I know you mentioned multiple instances as 
the reason for this change. I'm not sure if you played with create command 
which should create a new base for multiple brokers if you want to do that. 
That should make those instance shell scripts also obsolete, as we can just 
copy env script to the new bin directory. I think we should focus on 
improving create functionality as the solution for multi-tenancy.
- I think the test script is a great idea, but didn't include it for now, as 
there's a problem with it. There's general issue with using sed -i and sed 
~s on osx (and probably other platforms), so we should avoid it. We should 
continue working on the good test script
- I also removed setup command from the script.

Thanks for your contribution so far. Please continue to provide fixes and 
improvements against the current trunk. But please, keep you patches focused on 
a single fix/improvement. It will make it easier to test and merge.

I'll try to include some of the QA folks from RedHat to test the script on 
different platforms and verify it.

For the future (especially for 6.x), I'd like us to get more in line of the 
Apollo and Karaf scripts. As for the Cygwin, as you managed to make it work, 
I'd leave it for now and see how to best support windows users in the future.

 Initscript refactoring: setup function seems to be broken, removal of 
 uneccessary files, fix various problems
 -

 Key: AMQ-5378
 URL: https://issues.apache.org/jira/browse/AMQ-5378
 Project: ActiveMQ
  Issue Type: Improvement
  Components: Broker
Affects Versions: 5.10.0
 Environment: Linux/Unix
Reporter: Marc Schöchlin
  Labels: assemblies
 Fix For: 5.11.0

 Attachments: AMQ-5378.patch


 The current initscript seems to be broken.
 I submitted the current unix init script (see AMQ-2453) - the original script 
 seems to be modified in a way which breaks the setup function
 If you call ./activemq setup ~/.activemq you get a really messy configfile.
 The current distribution also contains lots of files of the java service 
 wrapper which are not needed anymore.
 I created the following patch/pull request:
 https://github.com/apache/activemq/pull/46



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (AMQ-5477) Add Progress OpenEdge database support for JDBC persistence adapter

2014-12-08 Thread Gregory Bevan (JIRA)
Gregory Bevan created AMQ-5477:
--

 Summary: Add Progress OpenEdge database support for JDBC 
persistence adapter
 Key: AMQ-5477
 URL: https://issues.apache.org/jira/browse/AMQ-5477
 Project: ActiveMQ
  Issue Type: Improvement
  Components: Broker
Affects Versions: 5.10.0
Reporter: Gregory Bevan
Priority: Minor


The TIME word  used for naming a column in ACTIVEMQ_LOCK table is a reserved 
Word for OpenEdge database.

TIME needs to be quoted in query linked to ACTIVEMQ_LOCK table.

A specific adapter could be created to override statements that contains this 
word. It must be declared in 
META-INF\services\org\apache\activemq\store\jdbc\openedge file like others for 
Oracle or Postgresql.

I've already created and tested this specific adapter and I can attach it to 
the bug





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (AMQ-5477) Add Progress OpenEdge database support for JDBC persistence adapter

2014-12-08 Thread Gregory Bevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMQ-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gregory Bevan updated AMQ-5477:
---
Attachment: OpenEdgeJDBCAdapter.java

This is the *OpenEdgeJDBCAdapter* source file which overrides statements 
containings the reserved word TIME.

It must be integrated to *activemq-jdbc-store* project under 
*org.apache.activemq.store.jdbc.adapter* package.

 Add Progress OpenEdge database support for JDBC persistence adapter
 ---

 Key: AMQ-5477
 URL: https://issues.apache.org/jira/browse/AMQ-5477
 Project: ActiveMQ
  Issue Type: Improvement
  Components: Broker
Affects Versions: 5.10.0
Reporter: Gregory Bevan
Priority: Minor
 Attachments: OpenEdgeJDBCAdapter.java


 The TIME word  used for naming a column in ACTIVEMQ_LOCK table is a reserved 
 Word for OpenEdge database.
 TIME needs to be quoted in query linked to ACTIVEMQ_LOCK table.
 A specific adapter could be created to override statements that contains this 
 word. It must be declared in 
 META-INF\services\org\apache\activemq\store\jdbc\openedge file like others 
 for Oracle or Postgresql.
 I've already created and tested this specific adapter and I can attach it to 
 the bug



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] activemq-6 pull request: ACTIVEMQ6-9 - port to markdown

2014-12-08 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-6/pull/37


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-6 pull request: ACTIVEMQ6-6 - remove SPI usage

2014-12-08 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-6/pull/36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (ACTIVEMQ6-6) Extract any JBoss SPI code replace with generic

2014-12-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ACTIVEMQ6-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238114#comment-14238114
 ] 

ASF GitHub Bot commented on ACTIVEMQ6-6:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-6/pull/36


 Extract any JBoss SPI code replace with generic
 ---

 Key: ACTIVEMQ6-6
 URL: https://issues.apache.org/jira/browse/ACTIVEMQ6-6
 Project: Apache ActiveMQ 6
  Issue Type: Improvement
Reporter: Martyn Taylor
 Fix For: 6.0.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMQ-4543) Client already connected error when connecting to MQTT server a second time

2014-12-08 Thread James R. Semple (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-4543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238214#comment-14238214
 ] 

James R. Semple commented on AMQ-4543:
--

It looks to me like this bug has reappeared in ActiveMQ 5.10.0.  Can someone at 
ActiveMQ do a quick regression test?

 Client already connected error when connecting to MQTT server a second time 
 

 Key: AMQ-4543
 URL: https://issues.apache.org/jira/browse/AMQ-4543
 Project: ActiveMQ
  Issue Type: Bug
  Components: MQTT
Affects Versions: 5.7.0
 Environment: Win 2008
Reporter: Dorde Popovic
 Fix For: 5.9.0


 I built client that is connecting to Apache MQ set for mqtt. 
 Now on first try client establishes the connection with client id = test1, 
 sends message and closes connection
  if(!client.isConnected()){
   client.connect(conOpt);
 }
 MqttTopic topic = client.getTopic(topicName);
 MqttMessage message = new MqttMessage(payload);
   message.setQos(qos);
   MqttDeliveryToken token = topic.publish(message);
   token.waitForCompletion();
   client.disconnect();
 Then when again I run client it fails on connect ... I can see log in apache 
 mq log:
  WARN | Transport Connection to: tcp://127.0.0.1:57354 failed: 
 java.io.IOExcepti
 on: Broker: localhost - Client: test1 already connected from 
 tcp://127.0.0.1:57
 330
 in connection options I have set only setCleanSession(true). Paho client I 
 have downloaded from site as stable version.
 I have first tried to raise an issue with the Eclipse Paho project 
 (https://bugs.eclipse.org/bugs/show_bug.cgi?id=408105) and after 
 investigation their team came to conclusion that this is not on clinet side



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (ACTIVEMQ6-54) Depaging don't get started in some situations and Browsing is not looking towards paged messages

2014-12-08 Thread clebert suconic (JIRA)

 [ 
https://issues.apache.org/jira/browse/ACTIVEMQ6-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

clebert suconic updated ACTIVEMQ6-54:
-
Fix Version/s: 6.0.0

 Depaging don't get started in some situations and Browsing is not looking 
 towards paged messages
 

 Key: ACTIVEMQ6-54
 URL: https://issues.apache.org/jira/browse/ACTIVEMQ6-54
 Project: Apache ActiveMQ 6
  Issue Type: Bug
Affects Versions: 6.0.0
Reporter: clebert suconic
Assignee: clebert suconic
 Fix For: 6.0.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (ACTIVEMQ6-54) Depaging don't get started in some situations and Browsing is not looking towards paged messages

2014-12-08 Thread clebert suconic (JIRA)

 [ 
https://issues.apache.org/jira/browse/ACTIVEMQ6-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

clebert suconic closed ACTIVEMQ6-54.

Resolution: Fixed

 Depaging don't get started in some situations and Browsing is not looking 
 towards paged messages
 

 Key: ACTIVEMQ6-54
 URL: https://issues.apache.org/jira/browse/ACTIVEMQ6-54
 Project: Apache ActiveMQ 6
  Issue Type: Bug
Affects Versions: 6.0.0
Reporter: clebert suconic
Assignee: clebert suconic
 Fix For: 6.0.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (AMQ-5475) AMQP transport does not send correct response to unsupported clients

2014-12-08 Thread Timothy Bish (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMQ-5475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish resolved AMQ-5475.
---
Resolution: Fixed

Any client that connects to the transports TCP, SSL, NIO, NIO+SSL which uses an 
unsupported AMQP version or that is not sending an AMQP header that is valid 
will be sent the appropriate AMQP 1.0 header and then have the connection 
closed.  

 AMQP transport does not send correct response to unsupported clients
 

 Key: AMQ-5475
 URL: https://issues.apache.org/jira/browse/AMQ-5475
 Project: ActiveMQ
  Issue Type: Bug
  Components: AMQP
Affects Versions: 5.9.1, 5.10.0
Reporter: Timothy Bish
Assignee: Timothy Bish
 Fix For: 5.11.0


 Section 2.2 of the AMQP 1.0 spec covers protocol negotiation and states that 
 when a client connects and send an AMQP header with an unsupported version 
 the broker should send back an AMQP header with the version supported before 
 closing the socket.  This also applied if the header cannot be parsed, such 
 as a HTTP client etc connecting to the AMQP transport port.  
 We currently just close the socket which does not give the connecting client 
 any insight into why the connect failed and allow it to try again with the 
 correct protocol if supported. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMQ-5468) AMQ MQTT doesn't reject remote connection after a long time

2014-12-08 Thread Timothy Bish (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238620#comment-14238620
 ] 

Timothy Bish commented on AMQ-5468:
---

You can add the keepAlive option to your transport connector and configure the 
OS to check on a more regular interval than the default two hour value.  When 
you close the telnet session you leave a half open socket and the broker needs 
the TCP stack to signal that it has gone so keepAlive would be a good solution. 
 

 AMQ MQTT doesn't reject remote connection after a long time 
 

 Key: AMQ-5468
 URL: https://issues.apache.org/jira/browse/AMQ-5468
 Project: ActiveMQ
  Issue Type: Bug
  Components: Connector, MQTT
Affects Versions: 5.9.0, 5.9.1, 5.10.0
 Environment: Linux
Reporter: Nguyen Hong Phu

 Test steps:
 - Using jConsole to explore JMX MBean clientConnectors (MQTT+NIO connector). 
 - Using telnet client connect to MQTT+NIO port
 - On jConsole: clientConnectors/mqtt+nio/remoteAddess appear a new connection 
 with IP and local port which connect to.
 - Close telnet program
 - Waiting a long time (could be more than a day) and view remoteAddess again 
 on jConsole but Remote IP (telnet) does not remove.
 Imagine that if a human open a thousand or million connections to server, AMQ 
 not release connections after short time, then AMQ could be throws the ERROR 
 To many open files and it doesn't access new connection.
 In production server (ulimit max-open-files 65000), i'm using 2 thousand 
 clients but after 2 days, many ERROR To many open files in activemq.log to 
 be throws.
 On jConsole, number of clientId is equals with clients, but RemoteIP contains 
 more than 65000 IPs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (AMQ-5473) Race condition caused by Linkstealing might make durable subs inactive

2014-12-08 Thread Timothy Bish (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMQ-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish reassigned AMQ-5473:
-

Assignee: Timothy Bish

 Race condition caused by Linkstealing might make durable subs inactive
 --

 Key: AMQ-5473
 URL: https://issues.apache.org/jira/browse/AMQ-5473
 Project: ActiveMQ
  Issue Type: Bug
  Components: Broker
Affects Versions: 5.11.0
Reporter: AR
Assignee: Timothy Bish
 Attachments: linksteal_durablesub.patch


 Link Stealing creates a new connection and disconnects the old connection. 
 These operations are done concurrently.
 New connection triggers addConsumer() for active subscriptions and old 
 connection stop causes removeConsumer() for the same.
 Problems:
  * addConsumer() would throw exception that the sub is already active (if 
 remove did not happen before)
  * even if we go past the exception, it will not set the right (new) 
 connection context and consumer info the subs
  * removeConsumer() may remove subcription even if it had different 
 connection context (created by linkstealing)
 Patch attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (AMQ-5473) Race condition caused by Linkstealing might make durable subs inactive

2014-12-08 Thread Timothy Bish (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238649#comment-14238649
 ] 

Timothy Bish commented on AMQ-5473:
---

Were you able to reproduce this in a test case?  I'm reviewing the change.

 Race condition caused by Linkstealing might make durable subs inactive
 --

 Key: AMQ-5473
 URL: https://issues.apache.org/jira/browse/AMQ-5473
 Project: ActiveMQ
  Issue Type: Bug
  Components: Broker
Affects Versions: 5.11.0
Reporter: AR
Assignee: Timothy Bish
 Attachments: linksteal_durablesub.patch


 Link Stealing creates a new connection and disconnects the old connection. 
 These operations are done concurrently.
 New connection triggers addConsumer() for active subscriptions and old 
 connection stop causes removeConsumer() for the same.
 Problems:
  * addConsumer() would throw exception that the sub is already active (if 
 remove did not happen before)
  * even if we go past the exception, it will not set the right (new) 
 connection context and consumer info the subs
  * removeConsumer() may remove subcription even if it had different 
 connection context (created by linkstealing)
 Patch attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (AMQ-5405) Update the AMQP JMS client used in tests from 0.26 to 0.30

2014-12-08 Thread Timothy Bish (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMQ-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish resolved AMQ-5405.
---
Resolution: Fixed

 Update the AMQP JMS client used in tests from 0.26 to 0.30
 --

 Key: AMQ-5405
 URL: https://issues.apache.org/jira/browse/AMQ-5405
 Project: ActiveMQ
  Issue Type: Improvement
  Components: AMQP
Affects Versions: 5.10.0
Reporter: Timothy Bish
Priority: Minor
 Fix For: 5.11.0

 Attachments: AMQ5405.patch


 There have been two releases of now of the AMQP JMS client beyond the version 
 we use now which fixes some known issues and adds some configuration options 
 such as consumer prefetch which would be useful for testing.  There are some 
 changes needed for SSL tests to work, a patch will be attached shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (ACTIVEMQ6-7) Improve Serialization on Connection Factory.

2014-12-08 Thread clebert suconic (JIRA)

[ 
https://issues.apache.org/jira/browse/ACTIVEMQ6-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238855#comment-14238855
 ] 

clebert suconic commented on ACTIVEMQ6-7:
-

This is my next task

 Improve Serialization on Connection Factory.
 

 Key: ACTIVEMQ6-7
 URL: https://issues.apache.org/jira/browse/ACTIVEMQ6-7
 Project: Apache ActiveMQ 6
  Issue Type: Improvement
Reporter: Martyn Taylor
Assignee: clebert suconic
 Fix For: 6.0.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (ACTIVEMQ6-7) Improve Serialization on Connection Factory.

2014-12-08 Thread clebert suconic (JIRA)

 [ 
https://issues.apache.org/jira/browse/ACTIVEMQ6-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

clebert suconic reassigned ACTIVEMQ6-7:
---

Assignee: clebert suconic

 Improve Serialization on Connection Factory.
 

 Key: ACTIVEMQ6-7
 URL: https://issues.apache.org/jira/browse/ACTIVEMQ6-7
 Project: Apache ActiveMQ 6
  Issue Type: Improvement
Reporter: Martyn Taylor
Assignee: clebert suconic
 Fix For: 6.0.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Work started] (ACTIVEMQ6-7) Improve Serialization on Connection Factory.

2014-12-08 Thread clebert suconic (JIRA)

 [ 
https://issues.apache.org/jira/browse/ACTIVEMQ6-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on ACTIVEMQ6-7 started by clebert suconic.
---
 Improve Serialization on Connection Factory.
 

 Key: ACTIVEMQ6-7
 URL: https://issues.apache.org/jira/browse/ACTIVEMQ6-7
 Project: Apache ActiveMQ 6
  Issue Type: Improvement
Reporter: Martyn Taylor
Assignee: clebert suconic
 Fix For: 6.0.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (AMQ-5478) REST endpoint creates topic instead of queue

2014-12-08 Thread Paul Smith (JIRA)
Paul Smith created AMQ-5478:
---

 Summary: REST endpoint creates topic instead of queue
 Key: AMQ-5478
 URL: https://issues.apache.org/jira/browse/AMQ-5478
 Project: ActiveMQ
  Issue Type: Bug
  Components: webconsole
Affects Versions: 5.10.0
Reporter: Paul Smith
Priority: Minor


This is _possibly_ simply a Documentation bug, but I was testing the REST 
endpoints via the documentation here:

http://activemq.apache.org/rest.html

When I first tried to post a simple message to a queue (and this queue didn't 
exist yet) I used this script:

{noformat}
$ curl -d body=message -XPOST 
http://admin:admin@localhost:8161/api/message/queue/orders/input
{noformat}

The above is mostly based on the documentation.  I was surprised to find no 
queue created by looking at the web console, but i _*did*_ see a Topic created 
called 'queue.orders.input' and it contained 1 message (odd because there's no 
consumers defined).

After deleting the topic I then tried the 'other format' of the URL:

{noformat}
 curl -d body=message -XPOST 
http://admin:admin@localhost:8161/api/message/orders.input?type=queue
{noformat}

This does create a Queue of name 'orders.input' as one would expect.

I'm not exactly clear then from the documentation where in the URL one is 
defining it as a queue using the former syntax.  The URL in the documentation 
sort of _implies_ that the 'queue' prefix of the URL is creating a queue named 
'orders.input' but it doesn't turn out that way.

So either this is a bug, or the documentation needs tweaking.







--
This message was sent by Atlassian JIRA
(v6.3.4#6332)