Re: Message Priority test

get it connection.MessagePrioritySupported = true -- View this message in context: http://activemq.2283324.n4.nabble.com/Message-Priority-test-tp4723158p4723280.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.

Re: [VOTE] Release ActiveMQ Artemis 1.5.4 (RC1)

+1 (binding) nice one!!! On Wed, Mar 8, 2017 at 10:56 AM, Howard Gao wrote: > +1 > > On Wed, Mar 8, 2017 at 4:31 PM, nigro_franz wrote: > >> +1 (unbinding) >> >> >> >> -- >> View this message in context: http://activemq.2283324.n4. >>

Re: [VOTE] Release ActiveMQ Artemis 1.5.4 (RC1)

I wasn't thinking of it as a -1, forgot to respond. I can update the NOTICE and re-roll. No big deal. LMK. John On Wed, Mar 8, 2017 at 8:18 PM Clebert Suconic wrote: > Was that a -1? > > > I wouldn't hold it for that. I would fix it for next ones. > > > > On Wed,

Re: [VOTE] Release ActiveMQ Artemis 1.5.4 (RC1)

Was that a -1? I wouldn't hold it for that. I would fix it for next ones. On Wed, Mar 8, 2017 at 12:51 PM Timothy Bish wrote: > > Started to review the release, noticed the year range is incorrect in > the NOTICE file should be [2014-2017] now. Will keep poking

Re: [VOTE] Release ActiveMQ Artemis 1.5.4 (RC1)

+1 * Checked signature and checksums * Built from source and ran some tests * Ran the binary distro broker and ran some samples against it. * Checked license and notice files On 03/07/2017 10:14 PM, John D. Ament wrote: Hello all, I'd like to propose an Apache Artemis 1.5.4 release (RC1).

Re: Public Key

Fingerprint: AC00 1153 A449 F942 5951 E034 F65D 88E0 295B 2B2F Key ID: 295B2B2F Hopefully that's what you're looking for. John On Wed, Mar 8, 2017 at 12:11 PM Timothy Bish wrote: > Can you add the uid bits from the export so it's clear whose this is in > the KEYS file?

Re: [VOTE] Release ActiveMQ Artemis 1.5.4 (RC1)

I didn't find any other issues so won't make a fuss about it, I'd recommend you go ahead and fix them in the repo now for the 2.x and 1.x branches before someone forgets. Will cast a vote separately On 03/08/2017 08:25 PM, John D. Ament wrote: I wasn't thinking of it as a -1, forgot to

[GitHub] activemq-artemis issue #1072: ARTEMIS-1024 Management operation causes Class...

Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1072 Sure I'll add a test. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Message Priority test

On 03/07/2017 09:00 PM, Green wrote: get it connection.MessagePrioritySupported = true Just note that if you haven't enabled priority support on the broker side than this only applies priority ordering to messages that sit in the prefetch buffer, so if the buffer is not holding a backlog

Re: [VOTE] Release ActiveMQ Artemis 1.5.4 (RC1)

Started to review the release, noticed the year range is incorrect in the NOTICE file should be [2014-2017] now. Will keep poking around. On 03/07/2017 10:14 PM, John D. Ament wrote: Hello all, I'd like to propose an Apache Artemis 1.5.4 release (RC1). This revision release of Apache

Re: Public Key

Can you add the uid bits from the export so it's clear whose this is in the KEYS file? Not essential but nice to have. I'll add it for you to the dist version today. On 03/07/2017 09:45 PM, John D. Ament wrote: Hey guys Would someone mind adding my key to the KEYS file? I'm trying to roll

[GitHub] activemq-artemis pull request #1073: AMQP changes (see commits)

Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1073#discussion_r105024895 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java --- @@

[GitHub] activemq-artemis pull request #1073: AMQP changes (see commits)

GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1073 AMQP changes (see commits) You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis artemis-1021

[GitHub] activemq-artemis pull request #1073: AMQP changes (see commits)

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1073#discussion_r105025094 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java --- @@

[GitHub] activemq-artemis pull request #1071: Add a test for MQTT will message with n...

GitHub user orpiske opened a pull request: https://github.com/apache/activemq-artemis/pull/1071 Add a test for MQTT will message with non-retain flag This patch adds a new test that verifies if the broker is able to send a will message if the retain flag is set to false. You

[GitHub] activemq-artemis issue #1073: AMQP changes (see commits)

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1073 Fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] activemq-artemis pull request #1072: ARTEMIS-1024 Management operation cause...

GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/1072 ARTEMIS-1024 Management operation causes ClassNotFoundException Artemis expose createQueue() method to management console like Jon. If the queue to be created already exists it

Re: [VOTE] Release ActiveMQ Artemis 1.5.4 (RC1)

+1 On Wed, Mar 8, 2017 at 4:31 PM, nigro_franz wrote: > +1 (unbinding) > > > > -- > View this message in context: http://activemq.2283324.n4. > nabble.com/VOTE-Release-ActiveMQ-Artemis-1-5-4-RC1-tp4723293p4723307.html > Sent from the ActiveMQ - Dev mailing list archive at

[GitHub] activemq-artemis issue #1072: ARTEMIS-1024 Management operation causes Class...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1072 a problem with fixes without tests.. is that if I break this again later.. I won't know I broke it.. is there a way you could add a test? --- If your project is set

[GitHub] activemq-artemis pull request #1073: AMQP changes (see commits)

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1073#discussion_r105046718 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java --- @@

Re: [DISCUSS] ActiveMQ Artemis 2.x stream

FWIW, I commented [1] on ARTEMIS-1001 regarding this issue to clear up a few things. Additionally, I'm fine with adding time-unit notation parsing, but it's worth noting that IMO this isn't as pressing as the byte notation because multiplying by 60 is quite a bit simpler than multiplying by

Re: [DISCUSS] ActiveMQ Artemis 2.x stream

FWIW, I commented [1] on ARTEMIS-1001 regarding this issue to clear up a few things. Additionally, I'm fine with adding time-unit notation parsing, but it's worth noting that IMO this isn't as pressing as the byte notation because multiplying by 60 is quite a bit simpler than multiplying by

Re: [DISCUSS] ActiveMQ Artemis 2.x stream

Mirek, I'd prefer not to change the default value, but instead make our configuration options include a units parameter. If we add a units parameter like discussed above users can specify however which way they'd like to time slice their window, changing it to only support 5 minutes might be

Re: [VOTE] Release ActiveMQ Artemis 1.5.4 (RC1)

+1 (unbinding) -- View this message in context: http://activemq.2283324.n4.nabble.com/VOTE-Release-ActiveMQ-Artemis-1-5-4-RC1-tp4723293p4723307.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.

Re: [DISCUSS] ActiveMQ Artemis 2.x stream

Thanks Clebert!!! Yes and I'll ask if makes sense to add something about the datasync option too -- View this message in context: http://activemq.2283324.n4.nabble.com/DISCUSS-ActiveMQ-Artemis-2-x-stream-tp4721815p4723306.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.

[GitHub] activemq-artemis pull request #1070: [docs] migration guide - authorization

GitHub user dejanb opened a pull request: https://github.com/apache/activemq-artemis/pull/1070 [docs] migration guide - authorization You can merge this pull request into a Git repository by running: $ git pull https://github.com/dejanb/activemq-artemis migration-guide

Re: [DISCUSS] ActiveMQ Artemis 2.x stream

Thanks Martyn, I just had this impression from the code and wanted to check it with you in [1] . Let's leave it as it is and not break things. Mirek [1]