[GitHub] activemq-artemis issue #1679: ARTEMIS-1523 Allow MQTT with dynamic cluster

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1679
  
The single commit here is much easier to understand so thanks for that.

However, I don't believe technical solution is viable as it relies on the 
address for the subscription matching the address in the cluster-connection 
which would likely only happen if it was specifically configured that way which 
would preclude other clustered addresses.

I think the real solution would be to address why the 
message-load-balancing-type isn't being set on the subscription queues in the 
first place.


---

[GitHub] activemq-artemis pull request #1680: ARTEMIS-1530 Fix expiry statistics

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1680


---

Contribute a properties-based SQL Provider

[Jeff Mesnil]

Hi,

We have integrated Artemis 1.x in WildFly application server with a
different SQLProvider implementation to support Artemis JDBC store.
The issue we had at the time with Artemis SQLProvider was that
supporting a new databases required to add a new class to specify its
specific JDBC statements and ultimately require new releases for each
new DB we wanted to test & support.

To circumvent this issue, we wrote a SQLProvider[1] to use for Artemis
JDBC store that is using a Properties file[2] and a simple overridding
mechanism to provide DB-specific statements.
For example to support Oracle DB, Artemis mechanism required to write
(and maintain) this class:
https://github.com/apache/activemq-artemis/blob/master/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/oracle/Oracle12CSQLProvider.java

Using our property-based implementation, we only need to add 2 lines
to the properties file:

https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/org/wildfly/extension/messaging-activemq/main/database/journal-sql.properties#L43-L45

When the SQLProvider will be queried for a SQL statement, it will
first searched for a DB-specific dialect and falls back to a generic
one else:

https://github.com/wildfly/wildfly/blob/master/messaging-activemq/src/main/java/org/wildfly/extension/messaging/activemq/PropertySQLProviderFactory.java#L249

The dialect itself is determined used DataSource properties and metadata:

https://github.com/wildfly/wildfly/blob/master/messaging-activemq/src/main/java/org/wildfly/extension/messaging/activemq/PropertySQLProviderFactory.java#L85

In addition, this properties file can be easily modified by users
without requiring a new release to support another database.

We have started development on WildFly 12 and I am looking to
integrate Artemis 2.4.x.
I don't want to have to maintain a 2nd implementation of the SQL
provider in WildFly codebase and I really think that our
properties-based approach is sounder than the current Artemis
implementation.

I'd like to propose to contribute back this properties-based SQL
provider to Artemis codebase in replacement to its current
implementation. I think this would be beneficial for Artemis as it
would reduce the amount of work to support a new DB, reduce the number
of classes for a better maintainability and, of course, ease the
integration of Artemis into WildFly.

What do you think?

jeff

[1] 
https://github.com/wildfly/wildfly/blob/master/messaging-activemq/src/main/java/org/wildfly/extension/messaging/activemq/PropertySQLProviderFactory.java
[2] 
https://github.com/wildfly/wildfly/blob/master/feature-pack/src/main/resources/modules/system/layers/base/org/wildfly/extension/messaging-activemq/main/database/journal-sql.properties
-- 
Jeff Mesnil
jmes...@gmail.com
http://jmesnil.net/weblog/

[GitHub] activemq-artemis issue #1675: ARTEMIS-1526 NullpointerException in ActiveMQS...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1675
  
@pgfox you need to rebase this...


---

[GitHub] activemq pull request #266: AMQ-5669 Update Karaf feature files to add requi...

[amarkevich]

GitHub user amarkevich opened a pull request:

https://github.com/apache/activemq/pull/266

AMQ-5669 Update Karaf feature files to add required namespace (minimal

available version)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/amarkevich/activemq activemq-5.15.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq/pull/266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #266


commit 2e43b7011ac145af84a4b613af53c46a7d559c2a
Author: amarkevich 
Date:   2017-11-30T12:22:24Z

AMQ-5669 Update Karaf feature files to add required namespace (minimal
available version)




---

[GitHub] activemq pull request #265: AMQ-5669 Update Karaf feature files to add requi...

[amarkevich]

GitHub user amarkevich opened a pull request:

https://github.com/apache/activemq/pull/265

AMQ-5669 Update Karaf feature files to add required namespace (minimal

available version)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/amarkevich/activemq AMQ-5669

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #265


commit 8661b4fe3ea48b93e097d66c20de3844e1a96505
Author: amarkevich 
Date:   2017-11-30T12:22:24Z

AMQ-5669 Update Karaf feature files to add required namespace (minimal
available version)




---

[GitHub] activemq-cpp pull request #4: Tiny example fixes

[Pingmin]

GitHub user Pingmin opened a pull request:

https://github.com/apache/activemq-cpp/pull/4

Tiny example fixes

Hi, I just read some examples in these days and here are just some tiny 
fixes. Thanks!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Fenlly/activemq-cpp tiny-example-fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-cpp/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4


commit c258b22100ab7f9a52d9da83cf6521a2b7beb642
Author: 平民·寻梦(Pingmin Fenlly Liu) 
Date:   2017-11-30T08:22:27Z

Just align the indentation

commit a6aa67d7ed97e31589d0778de7fde46e7f0b5bbc
Author: 平民·寻梦(Pingmin Fenlly Liu) 
Date:   2017-11-30T08:23:16Z

Fix the typo error of "new"




---