[GitHub] activemq-artemis pull request #1793: ARTEMIS-1498: Openwire internal headers...

2018-01-19 Thread RaiSaurabh
GitHub user RaiSaurabh opened a pull request: https://github.com/apache/activemq-artemis/pull/1793 ARTEMIS-1498: Openwire internal headers should not be part of message You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #1791: ARTEMIS-1622 Reduce memory footprint of QueueI...

2018-01-19 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1791 @michaelandrepearce That's the best I could think to reduce the number of changes but honestly `MessageReferenceImpl` isn't *really* forced to use himself as a parameter ---

[GitHub] activemq-artemis pull request #1786: ARTEMIS-1616 OpenWire improvements

2018-01-19 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1786#discussion_r162636748 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java --- @@ -361,13 +371,68 @@ public int

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

2018-01-19 Thread RaiSaurabh
Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/1793 Ok, @franz1981 I will wait for the merging. ---

[GitHub] activemq-artemis pull request #1786: ARTEMIS-1616 OpenWire improvements

2018-01-19 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1786#discussion_r162610245 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java --- @@ -361,13 +371,68 @@ public int hashCode()

[GitHub] activemq-artemis issue #1793: ARTEMIS-1498: Openwire internal headers should...

2018-01-19 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1793 Please check this too https://github.com/apache/activemq-artemis/pull/1786 Probably will be easier to wait mine to be merged: the changes I've pushed are including some refactoring

[GitHub] activemq-artemis issue #1795: [ARTEMIS-1609] Add distinct name/address for J...

2018-01-19 Thread jmesnil
Github user jmesnil commented on the issue: https://github.com/apache/activemq-artemis/pull/1795 While testing Artemis master branch, I found an issue with my previous commit. ---

[GitHub] activemq-artemis pull request #1786: ARTEMIS-1616 OpenWire improvements

2018-01-19 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1786#discussion_r162637206 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java --- @@ -361,13 +371,68 @@ public int

[GitHub] activemq-artemis issue #1791: ARTEMIS-1622 Reduce memory footprint of QueueI...

2018-01-19 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1791 @franz1981 looks good to me. ---

[GitHub] activemq-artemis issue #1786: ARTEMIS-1616 OpenWire improvements

2018-01-19 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1786 @franz1981 I assume you’ll squash commits once your ready right? ---

[GitHub] activemq-artemis issue #1786: ARTEMIS-1616 OpenWire improvements

2018-01-19 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1786 @michaelandrepearce TBH that's what I was thinking to do, but @clebertsuconic suggested that having all the commits but just 1 pr wasn't a bad thing at all: he has more experience than

[GitHub] activemq-artemis pull request #1794: [ARTEMIS-1552] differenciate empty fram...

2018-01-19 Thread gtully
GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/1794 [ARTEMIS-1552] differenciate empty frame from no frame such that a nu… …ll response is accepted when valid You can merge this pull request into a Git repository by running: $ git

[GitHub] activemq-artemis pull request #1795: [ARTEMIS-1609] Add distinct name/addres...

2018-01-19 Thread jmesnil
GitHub user jmesnil opened a pull request: https://github.com/apache/activemq-artemis/pull/1795 [ARTEMIS-1609] Add distinct name/address for JMS destinations Fix internalCreateTopic method: the topics are keyed by their core addresses, not their JMS names. You can merge this

[GitHub] activemq-artemis pull request #1796: ARTEMIS-1623 ActiveMQServerPlugin impl ...

2018-01-19 Thread pgfox
GitHub user pgfox opened a pull request: https://github.com/apache/activemq-artemis/pull/1796 ARTEMIS-1623 ActiveMQServerPlugin impl for logging various broker events Similar concept to the ActiveMQ 5.x loggingBrokerPlugin. Commit includes: - plugin impl - tests

Re: ActiveMQ real time and protocol performance tests

2018-01-19 Thread Francesco Nigro
Hi! Considering that I'm talking about soft-real time (is people do not die if too slow) please take a look to Artemis (with core protocol) too! Cheers, Franz Il ven 19 gen 2018, 21:29 kai ha scritto: > Hello together, > > if have found this article to ActiveMQ

ActiveMQ real time and protocol performance tests

2018-01-19 Thread kai
Hello together, if have found this article to ActiveMQ real time: http://activemq.apache.org/features.html but i can't found this feature. - Also I can't running the Running Maven 2 Performance Test

Re: [DISCUSS] Rework NMS.AMQP

2018-01-19 Thread cmorgan
I have created Jira issue AMQNET-575, https://issues.apache.org/jira/browse/AMQNET-575, with a few sub tasks. I plan to add more when/if needed. Duane and are working on documenting features of the API NMS will be implemented. The current repo is not feature complete although it is close to

Re: [DISCUSS] Rework NMS.AMQP

2018-01-19 Thread Timothy Bish
On 01/19/2018 05:23 PM, cmorgan wrote: I have created Jira issue AMQNET-575, https://issues.apache.org/jira/browse/AMQNET-575, with a few sub tasks. I plan to add more when/if needed. Duane and are working on documenting features of the API NMS will be implemented. The current repo is not

[GitHub] activemq-artemis issue #1791: ARTEMIS-1622 Reduce memory footprint of QueueI...

2018-01-19 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1791 @michaelandrepearce I will try to maintain the generics too if possible (not simple to fight with generics!) and about the cast it will be put already by the JVM with a thing called

[GitHub] activemq-artemis issue #1791: ARTEMIS-1622 Reduce memory footprint of QueueI...

2018-01-19 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1791 I've already run CI on it and it seems to be safe. Just few numbers to justify it... On master:

[GitHub] activemq-artemis issue #1791: ARTEMIS-1622 Reduce memory footprint of QueueI...

2018-01-19 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1791 @franz1981 why did we need to loose the generics on Node? it now means theres a cast on get, and alot of un-needed change IMO. if it was due to the extension now made

[GitHub] activemq-artemis issue #1791: ARTEMIS-1622 Reduce memory footprint of QueueI...

2018-01-19 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1791 Makes sense and agreed anyone using the list wouldn’t be exposed to the node ---

[GitHub] activemq-artemis pull request #1791: ARTEMIS-1622 Reduce memory footprint of...

2018-01-19 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1791 ARTEMIS-1622 Reduce memory footprint of QueueImpl LinkedListImpl is turned into an optionally intrusive linked list by allowing message references to extend Node You can merge this

[GitHub] activemq-artemis pull request #1792: ARTEMIS-1621 Make producerWindowSize co...

2018-01-19 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/1792 ARTEMIS-1621 Make producerWindowSize configurable on clusterconnection bridges The cluster connection bridge hard codes its producerWindowSize to -1 (meaning no producer flow

[GitHub] activemq-artemis issue #1791: ARTEMIS-1622 Reduce memory footprint of QueueI...

2018-01-19 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1791 @michaelandrepearce The fact is that what Node contains is "enforced" by who use it and that is already generics (ie `LinkedListImpl`) and adding generic to `Node' won't add any value