Github user franz1981 commented on the pull request:
https://github.com/apache/activemq-artemis/commit/ca6548d1739d4dba1e7114742ddf06a2a84aae3a#commitcomment-27343031
Good catch!!!
Please add a test (if possible, because concurrency is tricky to be tested)
or at least open a JIRA
Github user shoukunhuai commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1827#discussion_r165955807
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java
---
@@ -152,14 +153,14 @@ protected
I am not able to get the messages saved in database for a topic with an
offline durable subscriber. Because of this, if I restart the activemq, the
messages in the topic are lost (not delivered to durable subscriber), where
as the:
1. message expiry time has not yet reached
2. and
Github user shoukunhuai commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1827#discussion_r165955062
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/MessageReference.java
---
@@ -38,6 +38,10 @@ public static
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/1851
fix npe bug while getting element in the process of rehash
Hi, we found a bug in ConcurrentLongHashMap, as follows:
12:32:31,000 WARN
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1849#discussion_r165944067
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1849#discussion_r165944739
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1852#discussion_r165983987
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java
---
@@ -64,7 +64,7 @@
GitHub user treblereel opened a pull request:
https://github.com/apache/activemq-artemis/pull/1852
[ARTEMIS-1662] Reduce log of "INFO [org.apache.activemq.artemis.core.â¦
â¦client] (Thread-27 (ActiveMQ-client-global-threads))
jira:
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1849#discussion_r165979537
--- Diff:
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1849#discussion_r165979719
--- Diff:
Github user treblereel commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1852#discussion_r165982642
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java
---
@@ -64,7 +64,7 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1852#discussion_r165977653
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java
---
@@ -64,7 +64,7 @@
Github user treblereel commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1852#discussion_r165997110
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java
---
@@ -64,7 +64,7 @@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1849#discussion_r166001057
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1813
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1849#discussion_r166001786
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1849#discussion_r166011829
--- Diff:
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1832
@franz1981 seems no objections, you still ok to merge?
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1828
@stanlyDoge thanks, will merge shortly.
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1783
@mtaylor I assume you still working on this, as the TODO is still there?
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1783
Will do
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1783
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1828
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1783
I meant to merge this. If someone could merge it please ?
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1824
@grandinj i think the PR build issues are resolved, sorry if its a pain,
could you just force update to make it trigger again?
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1846#discussion_r165901274
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -437,7 +437,11 @@
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/1850
init pagingFactory with journalBufferTimeout_NIO
PagingFactory is wrongly initialized with journalBufferSize_NIO not
journalBufferTimeout_NIO.
You can merge this pull request into a Git
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/1853
This PR is quite large so I would appreciate if multiple people take a look
to make sure it looks ok.
---
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1850
@wy96f can you do the forced push to trigger a new Jenkins build?
---
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/commit/8f47cd6e14d4f51995272feaae9460dd95e03fe5#commitcomment-27350953
In
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java:
In
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1846#discussion_r166100953
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -437,7 +437,11 @@ public
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166178175
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionCounterImpl.java
---
@@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166178431
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
@@ -1309,4
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166178773
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountRecordV2.java
---
@@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166178732
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountRecordIncV2.java
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166179104
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueuePendingMessageMetrics.java
---
@@ -0,0
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166179369
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PageSubscription.java
---
@@ -161,4 +165,9 @@
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1846
---
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1853
ARTEMIS-1663 - Add new message count and size metrics
Adding new metrics for tracking message counts and sizes on a Queue.
This includes tracking metrics for pending, delivering and
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1834
---
41 matches
Mail list logo
