[GitHub] activemq-artemis pull request #1884: NO-JIRA typo in jmx-ssl example pom fil...

2018-02-22 Thread stanlyDoge
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1884 NO-JIRA typo in jmx-ssl example pom file + code format You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-artemis

[GitHub] activemq-artemis pull request #1888: ARTEMIS-1697 give ActivateCallback defa...

2018-02-22 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1888 ARTEMIS-1697 give ActivateCallback default methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #1887: ARTEMIS-1696 allow empty 'address' for ...

2018-02-22 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1887 ARTEMIS-1696 allow empty 'address' for grouping-handler You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #1886: ARTEMIS-1695 - Improve STOMP compatibli...

2018-02-22 Thread cshannon
GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/1886 ARTEMIS-1695 - Improve STOMP compatiblity with 5.x clients Also make sure on authentication error in version 1.0 a client will disconnect You can merge this pull request into a Git

[GitHub] activemq-artemis pull request #1889: ARTEMIS-1698 support 'instance' web dep...

2018-02-22 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1889 ARTEMIS-1698 support 'instance' web deployments You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis issue #1837: ARTEMIS-1603 fixed browsing tables under JMX t...

2018-02-22 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1837 +1 LGTM. @stanlyDoge has got me thinking, we should a some sort of unit/integration testing framework to introduce to the web console maybe so we can start building a

[GitHub] activemq-artemis pull request #1884: NO-JIRA typo in jmx-ssl example pom fil...

2018-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1884 ---

[GitHub] activemq-artemis pull request #1886: ARTEMIS-1695 - Improve STOMP compatibli...

2018-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1886 ---

[GitHub] activemq-artemis pull request #1837: ARTEMIS-1603 fixed browsing tables unde...

2018-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1837 ---

[GitHub] activemq-artemis pull request #1864: ARTEMIS-1677:Wrong documentation descri...

2018-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1864 ---

[GitHub] activemq-artemis issue #1888: ARTEMIS-1697 give ActivateCallback default met...

2018-02-22 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1888 Cleans the code nicely up , not on hot path, so defaults method is fine +1 from me. ---

[GitHub] activemq-artemis pull request #1888: ARTEMIS-1697 give ActivateCallback defa...

2018-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1888 ---

[GitHub] activemq-artemis issue #1877: ARTEMIS-1692 fixed filtering consumers in hawt...

2018-02-22 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1877 +1 LGTM. ---

[GitHub] activemq-artemis pull request #1890: NO-JIRA fix JMX examples

2018-02-22 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1890 NO-JIRA fix JMX examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis jmxExamples Alternatively you

[GitHub] activemq-artemis issue #1851: ARTEMIS-1664 fix npe bug while getting element...

2018-02-22 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1851 @jbertram i have taken @wy96f just rebased and done a PR so travis CI will build see https://github.com/apache/activemq-artemis/pull/1891 If that passes we can merge

[GitHub] activemq-artemis pull request #1877: ARTEMIS-1692 fixed filtering consumers ...

2018-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1877 ---

[GitHub] activemq-artemis pull request #1891: ARTEMIS-1664 fix npe bug while getting ...

2018-02-22 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/1891 ARTEMIS-1664 fix npe bug while getting element in the process of rehash https://github.com/apache/activemq-artemis/pull/1851 You can merge this pull request into a Git

[GitHub] activemq-artemis pull request #1887: ARTEMIS-1696 allow empty 'address' for ...

2018-02-22 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1887#discussion_r170118840 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java --- @@ -1671,7

[GitHub] activemq-artemis pull request #1891: ARTEMIS-1664 fix npe bug while getting ...

2018-02-22 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/1891 ---

[GitHub] activemq-artemis pull request #1892: ARTEMIS-1664 fix npe bug while getting ...

2018-02-22 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/1892 ARTEMIS-1664 fix npe bug while getting element in the process of rehash You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #1892: ARTEMIS-1664 fix npe bug while getting ...

2018-02-22 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/1892 ---

[GitHub] activemq-artemis pull request #1892: ARTEMIS-1664 fix npe bug while getting ...

2018-02-22 Thread michaelandrepearce
GitHub user michaelandrepearce reopened a pull request: https://github.com/apache/activemq-artemis/pull/1892 ARTEMIS-1664 fix npe bug while getting element in the process of rehash You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #1851: ARTEMIS-1664 fix npe bug while getting element...

2018-02-22 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1851 Seems first time travis build failed for unrelated reason second attempt https://github.com/apache/activemq-artemis/pull/1892 is fine. ---

[GitHub] activemq-artemis pull request #1887: ARTEMIS-1696 allow empty 'address' for ...

2018-02-22 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1887#discussion_r170153460 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java --- @@ -1671,7 +1671,7 @@

[GitHub] activemq-artemis pull request #1892: ARTEMIS-1664 fix npe bug while getting ...

2018-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1892 ---

[GitHub] activemq-artemis issue #1892: ARTEMIS-1664 fix npe bug while getting element...

2018-02-22 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1892 closing as https://github.com/apache/activemq-artemis/pull/1851 is what should be merged was just branching from there to get a PR build done to check it. ---

[GitHub] activemq-artemis issue #1851: ARTEMIS-1664 fix npe bug while getting element...

2018-02-22 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1851 @wy96f could you rebase (it seems clebert merged my branch (which had your original code) i used for checking that the build passed in the night) Also once rebased

[GitHub] activemq-artemis issue #1851: ARTEMIS-1664 fix npe bug while getting element...

2018-02-22 Thread wy96f
Github user wy96f commented on the issue: https://github.com/apache/activemq-artemis/pull/1851 @franz1981 lazySet is used to update capacity. Please review it :) ---

[GitHub] activemq-artemis issue #1851: ARTEMIS-1664 fix npe bug while getting element...

2018-02-22 Thread wy96f
Github user wy96f commented on the issue: https://github.com/apache/activemq-artemis/pull/1851 Sorry for the late reply. Using lazySet to update capacity filed is a good point. As for the test, I modified test as follows: @Test public void

[GitHub] activemq-artemis pull request #1893: NO-JIRA make MessageConsumerTest determ...

2018-02-22 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1893 NO-JIRA make MessageConsumerTest deterministic The method testStopConnectionDuringOnMessage in this class was relying on sleep() calls for critical timing. This test fails sometimes

[GitHub] activemq-artemis pull request #1885: ARTEMIS-1694 fix graceful-shutdown doc

2018-02-22 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1885 ARTEMIS-1694 fix graceful-shutdown doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1694

Re: Active MQ-CPP library core dumps

2018-02-22 Thread Timothy Bish
Please direct questions to the users list, the dev list is for discussion of ongoing ActiveMQ development. On 02/21/2018 11:16 PM, duttaab wrote: Hi, Hope not braking the sanctity of this Dev forum by posting it and not in User forum, as I believe dev folks can identify the bt clearly. I