[GitHub] activemq-artemis pull request #1904: ARTEMIS-1700 Using IOExecutors for more...

2018-02-27 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1904 ARTEMIS-1700 Using IOExecutors for more IO tasks You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #1899: ARTEMIS-1700 Fixed deadlock in paging state

2018-02-27 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1899 @shoukunhuai see #1904 ---

[GitHub] activemq-artemis pull request #1903: ARTEMIS-1706 - Add support for wantClie...

2018-02-27 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1903#discussion_r171060932 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java --- @@ -468,8 +473,12 @@ public

[GitHub] activemq-artemis pull request #1904: ARTEMIS-1700 Using IOExecutors for more...

2018-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1904 ---

[GitHub] activemq-artemis issue #1903: ARTEMIS-1706 - Add support for wantClientAuth

2018-02-27 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1903 can you rebase against master? I have sent a fix to the JORAM tests.. this would be a helpful as a test as well. ---

Website Discussion

2018-02-27 Thread Martyn Taylor
All, I wanted to pick up the website discussion again since it seems to have stalled. The last conversation we had was around us setting up a video call or hackathon to get the ball rolling. I had a conversation with Michael Pearce earlier in the week who's put together a potential site map as

[GitHub] activemq-artemis pull request #1903: ARTEMIS-1706 - Add support for wantClie...

2018-02-27 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1903#discussion_r171066273 --- Diff: docs/user-manual/en/configuring-transports.md --- @@ -403,6 +403,15 @@ following additional properties: This property is only

[GitHub] activemq-artemis issue #1849: ARTEMIS-1656 OpenWire scalability improvements

2018-02-27 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1849 @michaelandrepearce Yep, it has passed the same tests as master with no regressions, hence it can be merged :+1: ---

[GitHub] activemq-artemis issue #1895: ARTEMIS-1702 ConcurrentLongHashMap and Concurr...

2018-02-27 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1895 @michaelandrepearce Yes, tested yesterday: exactly the same :+1: (and for free :P) ---

[GitHub] activemq-artemis issue #1862: ARTEMIS-1676 Support overriding of JAVA_ARGS v...

2018-02-27 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1862 @mtaylor can you update the Windows artemis.profile.cmd, I can test it on Windows. ---

[GitHub] activemq-artemis issue #1849: ARTEMIS-1656 OpenWire scalability improvements

2018-02-27 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1849 @franz1981 @michaelandrepearce I think it's good and am going to merge it. ---

[GitHub] activemq-artemis pull request #1849: ARTEMIS-1656 OpenWire scalability impro...

2018-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1849 ---

[GitHub] activemq-artemis issue #1896: ARTEMIS-1661 Support splitting of broker.xml

2018-02-27 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1896 @adirubin good point. I'm going to merge this and improve it in a separate commit. ---

[GitHub] activemq-artemis issue #1896: ARTEMIS-1661 Support splitting of broker.xml

2018-02-27 Thread adirubin
Github user adirubin commented on the issue: https://github.com/apache/activemq-artemis/pull/1896 Hi michaelandrepearce, thanks! If I'm not mistaken, the server won't monitor the x-included files for changes, which could be a problem. ---

[GitHub] activemq-artemis issue #1837: ARTEMIS-1603 fixed browsing tables under JMX t...

2018-02-27 Thread stanlyDoge
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1837 AFAIK there is some effort to create some Selenium tests. I am not sure when it could get into upstream. ---

[GitHub] activemq-artemis pull request #1889: ARTEMIS-1698 support 'instance' web dep...

2018-02-27 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1889#discussion_r170900438 --- Diff: artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java --- @@ -95,34 +95,51 @@ public void

[GitHub] activemq-artemis issue #1896: ARTEMIS-1661 Support splitting of broker.xml

2018-02-27 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1896 @adirubin thats correct, you'll need to "touch" the broker.xml file still, this is very similar to the support for config modularity such as log4j e.g. there also you need to

[GitHub] activemq-artemis issue #1896: ARTEMIS-1661 Support splitting of broker.xml

2018-02-27 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1896 @gaohoward Updated docs 👍 ---

[GitHub] activemq-artemis pull request #1896: ARTEMIS-1661 Support splitting of broke...

2018-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1896 ---

[GitHub] activemq-artemis pull request #1903: ARTEMIS-1706 - Add support for wantClie...

2018-02-27 Thread cshannon
GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/1903 ARTEMIS-1706 - Add support for wantClientAuth Support setting wantClientAuth on a netty acceptor You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #1899: ARTEMIS-1700 Fixed deadlock in paging state

2018-02-27 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1899 You're right.. Man!!! you're good! :) I will send another PR! ---

[GitHub] activemq-artemis pull request #1905: ARTEMIS-1707 Check for already exists e...

2018-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1905 ---

[GitHub] activemq-artemis pull request #1906: NO-JIRA Improving test and queue.flush(...

2018-02-27 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1906 NO-JIRA Improving test and queue.flush() You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis

[GitHub] activemq-artemis pull request #1889: ARTEMIS-1698 support 'instance' web dep...

2018-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1889 ---

[GitHub] activemq-artemis pull request #1907: ARTEMIS-1705 Queue stop deliver after r...

2018-02-27 Thread morefuntang
GitHub user morefuntang opened a pull request: https://github.com/apache/activemq-artemis/pull/1907 ARTEMIS-1705 Queue stop deliver after remove all paged message over JMX I remove all messages in Queue via removeAllMessages in JMX After removed all paged message, queue

[GitHub] activemq-artemis pull request #1906: NO-JIRA Improving test and queue.flush(...

2018-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1906 ---

[GitHub] activemq-artemis issue #1903: ARTEMIS-1706 - Add support for wantClientAuth

2018-02-27 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1903 @cshannon rebase it... are you addressing @tabish121's comments or that doesn't apply? ---

[GitHub] activemq-artemis issue #1903: ARTEMIS-1706 - Add support for wantClientAuth

2018-02-27 Thread cshannon
Github user cshannon commented on the issue: https://github.com/apache/activemq-artemis/pull/1903 I am going to update my PR with Tim’s suggestion to have it match 5.x and rebase in the morning ---

[GitHub] activemq-artemis pull request #1905: ARTEMIS-1707 Check for already exists e...

2018-02-27 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1905 ARTEMIS-1707 Check for already exists exceptions and ignore For address and queue create check for the already exists exceptions and ignore as another client might have just created