Github user nlippke commented on the issue:
https://github.com/apache/activemq-artemis/pull/1986
@franz1981 :+1:
---
GitHub user TomasHofman opened a pull request:
https://github.com/apache/activemq-artemis/pull/1987
[ENTMQBR-1034] Connector parameters not backward compatible
https://issues.jboss.org/browse/ENTMQBR-1034
Fixing backward compatibility with HornetQ:
* Translate transport
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1986
@nlippke
> Statement-checks are all uppercase. Implementors using this method need
to be aware of it
Thanks for the note :+1: I have added a `String::toUpperCase`
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1984#discussion_r178814438
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
---
@@ -127,9
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1986#discussion_r178806417
--- Diff:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
---
@@ -191,9 +191,18
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1989
ARTEMIS-1772 Reduce memory footprint and allocations of QueueImpl
It includes:
- Message References: no longer uses boxed primitives and AtomicInteger
- Node: intrusive nodes no
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1985
I updated the patch to remove the duplicate decode which seems to have been
the root cause of the other test failure.
---
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1984#discussion_r178819137
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
---
@@ -127,9 +126,6
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1987
It would be nice to have a compatibility test added.
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1989
---
Github user TomasHofman commented on the issue:
https://github.com/apache/activemq-artemis/pull/1987
@clebertsuconic could you point me to where you keep similar tests? So far
I have a deal with EAP QE that they would create it for EAP.
---
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1988
ARTEMIS-1782 fix for displaying hawtio console sub-level tabs
You can merge this pull request into a Git repository by running:
$ git pull
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1987
@TomasHofman look under master/tests/compatiblity-tests
There are a bunch of tests where we mix different versions using
classLoading and groovy to avoid syntax
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1985
@tabish121 this passed earlier today and failed now...
Can you rebase (change the commit id) just to force another build please?
---
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1985
That's twice now today I've rebased. Test failure doesn't seem related to
AMQP
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1985
Thanks a lot. I will check whatâs going on. Thanks.
---
Github user rstancel commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1990#discussion_r178928320
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
---
@@ -29,12 +29,7 @@
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1990#discussion_r178924323
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
---
@@ -29,12 +29,7 @@
Github user rstancel commented on the issue:
https://github.com/apache/activemq-artemis/pull/1990
While clear shutdown it makes no sence to throw any exception. It should be
sufficient just to log message about whats happening.
---
GitHub user rstancel opened a pull request:
https://github.com/apache/activemq-artemis/pull/1990
[ARTEMIS-1770] Log warning instead of stacktrace while shutdown
Jira: https://issues.apache.org/jira/browse/ARTEMIS-1770
You can merge this pull request into a Git repository by
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1984
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1983
@ingo1121 actually I'm reverting this PR. These examples are not running
after your change. I shouldn't have merged it in the first place
---
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1986
ARTEMIS-1653 Allow database tables to be created externally
The previous commit about this feature wasn't using the right ResultSet
to count the rows in a table.
Additional
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1986
@clebertsuconic I haven't reverted tha change made by
https://github.com/apache/activemq-artemis/commit/ef74221684e8bf7f5ad0992f2c4ef81aa2ff986e
but isn't necessary anymore, because
24 matches
Mail list logo
