My recommendation is to use the Failover transport and the
TransportListener interface.
To use the failover transport, just use the following syntax for the broker
url:
failover://(*_original_broker_url_*)
For example, with a broker at localhost:61616,
failover://(tcp://localhost:61616),
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2113
@jostbg that's a good point actually
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2113
@jostbg can you add some pointers on your use case.. why this change was
needed?
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191918917
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
We recently updated from (ancient) ActiveMQ 5.10.x to 5.15.4. I've noticed
that text messages are now sporadically returning null as their message
bodies when they were sent with bodies.
After failing to make a unit test showing this error, I created a project
that reproduces part of what our
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191917895
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191921539
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
---
@@ -355,10 +355,27 @@ default Message
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191922206
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191924187
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2115
I got 100% on the testsuite for this change.
I have seen a few unrelated failures here.. but they are just noise.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2115
I can change it.
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191915585
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191947996
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Try turning the broker and client logging up to trace and see what the
logging shows for the message content.
Also, try the following:
- Same test with a Java producer (using plain ActiveMQ libs) instead of the
Scala producer
- Same test with a Java consumer (using plain ActiveMQ libs) instead of
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191946396
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
---
@@ -355,10 +355,27 @@ default Message
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2115
full testsuite pass here as well
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
Looks good to me
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2113
@mtaylor @jbertram why did we implement it by hand instead of using the
wildcard there?
@jostbg an updated idea on the usecase would help as well.
thanks
---
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191721270
--- Diff:
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191715800
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191680587
--- Diff:
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191714303
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Github user jostbg commented on the issue:
https://github.com/apache/activemq-artemis/pull/2113
Interestingly the regex-based wildcard matcher implemented in
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2116
ARTEMIS-1895 - Add duplicate metadata failure callback to
ActiveMQServerPlugin
Add a callback on duplicate metadata which will allow extra functionality
to be added.
You can merge
Hi,
I have implemented client producer to ActiveMQ broker but find with
firewalls in our environment that there can be regular interrupt/resume
cycles between the broker and connector. In the connector, when we get a
resume we set a boolean isConnected and check this when we go to send a
request
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r19182
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191757281
--- Diff:
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191756950
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191758985
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191760666
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2115
@gemmellr / @michaelandrepearce changes made
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2116#discussion_r191777420
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java
---
@@ -263,6 +264,8 @@
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2115
The build failed with something unrelated. I amended the commit hash to
rebuild the test.
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191778368
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
@michaelandrepearce - good point, i fixed it to bubble up the
ActiveMQException and so it is handled properly by the client
---
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2116#discussion_r191788973
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/SessionMetadataAddExceptionTest.java
---
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191792711
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2116#discussion_r191793991
--- Diff:
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191796188
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2116
I removed the re-throw and the expect for the JMSException so it will only
pass on InvalidClientIDException as that is the only type that should be thrown
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191797149
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2115#discussion_r191779067
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
---
@@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2116#discussion_r191783207
--- Diff:
Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2116#discussion_r191787441
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/SessionMetadataAddExceptionTest.java
---
44 matches
Mail list logo
