Github user gemmellr commented on the issue:
https://github.com/apache/activemq-nms-amqp/pull/2
I cant really help on the code side as .NET isn't an area I play, but from
a skim over the file list for curiosity it seemed like there are various
non-code elements in this PR which
Thank you all! Much appreciated ;-).
Bruce
On Mon, Jul 9, 2018 at 12:32 PM Justin Bertram wrote:
> I added a little more information on the Artemis releases.
>
>
> Justin
>
> On Mon, Jul 9, 2018 at 1:12 PM, Christopher Shannon <
> christopher.l.shan...@gmail.com> wrote:
>
> > I added the
Github user RagnarPaulson commented on the issue:
https://github.com/apache/activemq-nms-amqp/pull/2
Good catch. In my eagerness to compress several commits into one pull
request I lost the .gitignore and inadvertently committed all the
binaries/output. I've removed them all now.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2175#discussion_r201392536
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -270,6 +271,15 @@
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2175
note: seems test failure is related to
https://github.com/apache/activemq-artemis/pull/2173
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2173
@jbertram , @gtully It seems since this is merged there is an issue in
building master. LDAPLoginModuleTest.testLoginPooled fails consistently
---
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-nms-amqp/pull/2
It is generally best practice to squash commits into one on a PR to make
life easier for the reviews and to make the commit history simpler. We don't
really need to preserve a commit
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-nms-amqp/pull/1
This looks like it could be closed now given a new PR(#2) with the client
code is now open
---
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2177
fixing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis tests
Alternatively you can
