[GitHub] franz1981 commented on issue #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuffer pooling and alignment

2019-01-15 Thread GitBox
franz1981 commented on issue #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuffer pooling and alignment URL: https://github.com/apache/activemq-artemis/pull/2479#issuecomment-454343022 @clebertsuconic Please wait to merge this: probably I will change the thread-local pool with

[GitHub] gaohoward opened a new pull request #2499: ARTEMIS-2229 Qpid jms consumer cannot receive from multicast queue using FQQN

2019-01-15 Thread GitBox
gaohoward opened a new pull request #2499: ARTEMIS-2229 Qpid jms consumer cannot receive from multicast queue using FQQN URL: https://github.com/apache/activemq-artemis/pull/2499 If a client sends a message to a multicast address and using a qpid-jms client to receive the message

[ANNOUNCE] Apache Roadshow Chicago, Call for Presentations

2019-01-15 Thread Trevor Grant
Hello Devs! You're receiving this email because you are subscribed to one or more Apache developer email lists. I’m writing to let you know about an exciting event coming to the Chicago area: The Apache Roadshow Chicago. It will be held May 13th and 14th at three bars in the Logan Square

[GitHub] franz1981 edited a comment on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-15 Thread GitBox
franz1981 edited a comment on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-454285382 @CNNJYB in this case it is wanted: compaction was leaking buffers big as the

[GitHub] michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

2019-01-15 Thread GitBox
michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247864160 ## File path:

[GitHub] michaelandrepearce edited a comment on issue #2498: ARTEMIS-2228 Large Messages over Management

2019-01-15 Thread GitBox
michaelandrepearce edited a comment on issue #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#issuecomment-454450983 Just fyi, Re your failed pr build since some recent merges to master ive been getting more intermittent build

[GitHub] clebertsuconic commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

2019-01-15 Thread GitBox
clebertsuconic commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247954437 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

2019-01-15 Thread GitBox
clebertsuconic commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247954437 ## File path:

[GitHub] asfgit merged pull request #2498: ARTEMIS-2228 Large Messages over Management

2019-01-15 Thread GitBox
asfgit merged pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@activemq.apache.org

[GitHub] clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API

2019-01-15 Thread GitBox
clebertsuconic commented on issue #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497#issuecomment-454520641 Can you close this one please? This is an

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-15 Thread GitBox
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454488334 @franz1981 good to go? This is an automated message from

[GitHub] asfgit closed pull request #2499: ARTEMIS-2229 Qpid jms consumer cannot receive from multicast queue using FQQN

2019-01-15 Thread GitBox
asfgit closed pull request #2499: ARTEMIS-2229 Qpid jms consumer cannot receive from multicast queue using FQQN URL: https://github.com/apache/activemq-artemis/pull/2499 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list,

[GitHub] asfgit closed pull request #2477: ARTEMIS-2190 move tests

2019-01-15 Thread GitBox
asfgit closed pull request #2477: ARTEMIS-2190 move tests URL: https://github.com/apache/activemq-artemis/pull/2477 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@activemq.apache.org

[GitHub] clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-15 Thread GitBox
clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454544429 Great work here! I'm running testsuite just to make sure everything is covered.

[GitHub] clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-15 Thread GitBox
clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454575214 I tried pulling your branch, but the conflict that I thought I fixed caused a compilation error. do you mind rebasing

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-15 Thread GitBox
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454585309 rebased This is an automated message from the Apache Git

[GitHub] michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-15 Thread GitBox
michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-454585309 @clebertsuconic rebased This is an automated

[GitHub] gaohoward closed pull request #2497: ARTEMIS-2228 Check message size sent over management API

2019-01-15 Thread GitBox
gaohoward closed pull request #2497: ARTEMIS-2228 Check message size sent over management API URL: https://github.com/apache/activemq-artemis/pull/2497 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@activemq.apache.org

[GitHub] michaelandrepearce commented on issue #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging

2019-01-15 Thread GitBox
michaelandrepearce commented on issue #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging URL: https://github.com/apache/activemq-artemis/pull/2459#issuecomment-454606274 Whats occuring on this one? This

[GitHub] michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

2019-01-15 Thread GitBox
michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-454607131 Theres an outstanding item on this, Still need to find a way to

[GitHub] michaelandrepearce commented on a change in pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

2019-01-15 Thread GitBox
michaelandrepearce commented on a change in pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#discussion_r248116612 ## File path:

[GitHub] michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

2019-01-15 Thread GitBox
michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-454607131 Theres an outstanding item on this, Still need to find a way to

[GitHub] michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

2019-01-15 Thread GitBox
michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-454607131 Still need to find a way to optimise so we dont have to for loop round

[GitHub] michaelandrepearce commented on issue #2498: ARTEMIS-2228 Large Messages over Management

2019-01-15 Thread GitBox
michaelandrepearce commented on issue #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#issuecomment-454450983 Just fyi, Re your failed pr build since some recent merges to master ive been getting more intermittent build failures

[GitHub] franz1981 commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

2019-01-15 Thread GitBox
franz1981 commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454338688 > @franz1981 thx for recommending this tool, much easier to use than jfr! I was sure you would have like it: is