[GitHub] activemq-artemis pull request #1456: ARTEMIS-1342: Support Netty Native KQue...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1456


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1456: ARTEMIS-1342: Support Netty Native KQue...

[michaelandrepearce]

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1456

ARTEMIS-1342: Support Netty Native KQueue on macOS - Logging fix

Correct the logging id to correct matching id for level

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1342-LOG

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1456


commit c79026f7e9de85902c598ba3d8370e8c5560e9d4
Author: Michael Andre Pearce 
Date:   2017-08-10T01:20:26Z

ARTEMIS-1342: Support Netty Native KQueue on macOS - Logging fix

Correct the logging id to correct matching id for level




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1455: ARTEMIS-1335 Update Netty to 4.1.14 - M...

[michaelandrepearce]

Github user michaelandrepearce closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1455


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1455: ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1455
  
build box still has perm issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1455: ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1455
  
@clebertsuconic @mtaylor found the problem in MQTT when upgrade of Netty 
and fixed it, and sorted it. If you could merge/validate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1455: ARTEMIS-1335 Update Netty to 4.1.14 - M...

[michaelandrepearce]

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1455

ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix

Fix for MQTT in connect due to deprecated methods bug causing NPE, call new 
methods and null check ourselves.

Also raised https://github.com/netty/netty/issues/7076 upstream but i guess 
we will keep this, as the old methods are deprecated anyhow.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1335-FIX

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1455


commit ea623c963eb738ebc00f60f702058a43c474f931
Author: Michael Andre Pearce 
Date:   2017-08-10T00:18:00Z

ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix

Fix for MQTT in connect due to deprecated methods bug causing NPE, call new 
methods and null check ourselves.

Also raised https://github.com/netty/netty/issues/7076 upstream but i guess 
we will keep this, as the old methods are deprecated anyhow.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1453: minor update to log message in browser command

[pgfox]

Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/1453
  
@clebertsuconic  @michaelandrepearce  Sure, your suggested changes should 
be in the pull request now. Thanks






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1453#discussion_r132295112
  
--- Diff: 
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConsumerThread.java
 ---
@@ -124,7 +124,7 @@ public void browse() {
  }
   }
 
-  System.out.println(threadName + " Consumer thread finished");
+  System.out.println(threadName + " thread finished");
--- End diff --

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1453#discussion_r132295056
  
--- Diff: 
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConsumerThread.java
 ---
@@ -81,7 +81,7 @@ public void browse() {
  while (enumBrowse.hasMoreElements()) {
 Message msg = enumBrowse.nextElement();
 if (msg != null) {
-   System.out.println(threadName + " Received " + (msg 
instanceof TextMessage ? ((TextMessage) msg).getText() : 
msg.getJMSMessageID()));
+   System.out.println(threadName + " Browsing " + (msg 
instanceof TextMessage ? ((TextMessage) msg).getText() : 
msg.getJMSMessageID()));
--- End diff --

@pgfox you think you can change that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1453: minor update to log message in browser command

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1453
  
@clebertsuconic cool beans. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1454: ARTEMIS-1342: Support Netty Native KQueue on m...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1454
  
@clebertsuconic I'm guessing thats something you or a committer or PMC can 
only do? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1454: ARTEMIS-1342: Support Netty Native KQue...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1454


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1454: ARTEMIS-1342: Support Netty Native KQueue on m...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1454
  
don't worry about conflicts.. I used the merge-PR script and it rebased 
fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1453: minor update to log message in browser command

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1453
  
@michaelandrepearce I was going to merge this with NO-JIRA ammended



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1452: ARTEMIS-1335 Update Netty to 4.1.14

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1452


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1451: a few fixes

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1451


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1451: a few fixes

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1451
  
ready to be merged.. I'm doing it myself


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1454: ARTEMIS-1342: Support Netty Native KQueue on m...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1454
  
@michaelandrepearce we would need to talk to infra.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1453: minor update to log message in browser command

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1453
  
@pgfox can you open a JIRA for this and update the commit message to 
include it, e.g.

ARTEMIS- changed log message to state browse/browsing instead of 
consume/consuming
 
where  is the jira number.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1454: ARTEMIS-1342: Support Netty Native KQueue on m...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1454
  
@clebertsuconic can someone look at H21 build agent it seems it has a disk 
permission issue. TimeUnitsTest is failing and all it is doing is making a file 
myfile.txt in a new temporary folder. This code is not changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1453#discussion_r132276525
  
--- Diff: 
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConsumerThread.java
 ---
@@ -81,7 +81,7 @@ public void browse() {
  while (enumBrowse.hasMoreElements()) {
 Message msg = enumBrowse.nextElement();
 if (msg != null) {
-   System.out.println(threadName + " Received " + (msg 
instanceof TextMessage ? ((TextMessage) msg).getText() : 
msg.getJMSMessageID()));
+   System.out.println(threadName + " Browsing " + (msg 
instanceof TextMessage ? ((TextMessage) msg).getText() : 
msg.getJMSMessageID()));
--- End diff --

consistency of casing, maybe lowercase Browsing? either that or make others 
Capitalised.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1453#discussion_r132276246
  
--- Diff: 
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConsumerThread.java
 ---
@@ -115,7 +115,7 @@ public void browse() {
 finished.countDown();
  }
  if (consumer != null) {
-System.out.println(threadName + " Consumed: " + 
this.getReceived() + " messages");
+System.out.println(threadName + " browsed: " + 
this.getReceived() + " messages");
--- End diff --

capitalise "Browsed: " to match other capitalisation in other sys outs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1453#discussion_r132276032
  
--- Diff: 
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConsumerThread.java
 ---
@@ -124,7 +124,7 @@ public void browse() {
  }
   }
 
-  System.out.println(threadName + " Consumer thread finished");
+  System.out.println(threadName + " thread finished");
--- End diff --

Browser thread finished


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1452: ARTEMIS-1335 Update Netty to 4.1.14

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1452
  
Ok so happy we merge this, then, i assume. With he jproton and qpid-jms 
bits merged already, i would be keen for this to make it in, before tagging of 
2.3.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1454: ARTEMIS-1342: Support Netty Native KQue...

[michaelandrepearce]

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1454

ARTEMIS-1342: Support Netty Native KQueue on macOS

Add support for KQueue for when server or client runs on macOS. This is 
inline with the epoll support for linux

This currently is branched off 
https://github.com/apache/activemq-artemis/pull/1452, as such that PR needs to 
go first.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1342

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1454.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1454


commit 09efc8b698bd7b273563a750e15fb32979802c63
Author: Michael André Pearce 
Date:   2017-08-09T07:51:33Z

ARTEMIS-1335 Update Netty to 4.1.14

Update Netty to 4.1.14

commit 6b1ad9db6edb9f26a0eee37099d53c9f15884daa
Author: Michael Andre Pearce 
Date:   2017-08-09T16:43:40Z

ARTEMIS-1342: Support Netty Native KQueue on macOS

Add support for KQueue for when server or client runs on macOS. This is 
inline with the epoll support for linux




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1452: ARTEMIS-1335 Update Netty to 4.1.14

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1452
  
You did already good :) 
I was talking about my previous work on that class


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

[pgfox]

GitHub user pgfox opened a pull request:

https://github.com/apache/activemq-artemis/pull/1453

minor update to log message in browser command



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pgfox/activemq-artemis log_message_update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1453


commit 2f6e4c5491d95696e0e141e16149c1b88a399698
Author: Pat Fox 
Date:   2017-08-09T16:28:27Z

minor update to log message in browse command




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1452: ARTEMIS-1335 Update Netty to 4.1.14

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1452
  
Or do you mean should we make it a static method and then invoke that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1452: ARTEMIS-1335 Update Netty to 4.1.14

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1452
  
@franz1981 it is just copy paste of the code that was in the util in 
previous version before it was removed so code length is the same


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1452: ARTEMIS-1335 Update Netty to 4.1.14

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1452
  
Seems ok to me! Looking at the code I've written some time ago I probably 
need to check if every method is inlined or not...some methods look very long!!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Netty Kqueue

[Michael André Pearce]

Hi All,

As you know we added support in artemis for netty native epoll on Linux 
platforms earlier this year.

Since there is now netty native kqueue for MacOS/BSD, which has now had a good 
few releases and time in the wild on the netty project:

http://netty.io/wiki/native-transports.html

I would like to add this more due to the fact whilst server side predominantly 
seem to favour deployments in Linux env, thus epoll and aio.

We can have clients on almost any platform and for us we have clients that are 
on MacOS so to support KQueue would be great.

I am looking to implement this similar to how I did epoll. 

Cheers
Mike

Sent from my iPhone

[GitHub] activemq-artemis pull request #1452: ARTEMIS-1335 Update Netty to 4.1.14

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1452#discussion_r132223462
  
--- Diff: 
artemis-journal/src/main/java/io/netty/buffer/UnpooledUnsafeDirectByteBufWrapper.java
 ---
@@ -563,7 +564,11 @@ protected SwappedByteBuf newSwappedByteBuf() {
@Override
public ByteBuf setZero(int index, int length) {
   if (hasMemoryAddress()) {
- UnsafeByteBufUtil.setZero(this, addr(index), index, length);
+ if (length == 0) {
--- End diff --

@franz1981 if you want to quickly just check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1452: ARTEMIS-1335 Update Netty to 4.1.14

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1452
  
@clebertsuconic this is ready.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1449
  
Hi Guys again,

As @clebertsuconic noted on his PR it seem it was environmental , since the 
big restart of jenkins that occured this morning, it seems to have cleared out. 

ignore, sorry.
Mike


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1451: a few fixes

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1451
  
@clebertsuconic agreed, since the big restart of jenkins that occured this 
morning, it seems to have cleared out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1452: ARTEMIS-1335 Update Netty to 4.1.14

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1452#discussion_r132177518
  
--- Diff: 
artemis-journal/src/main/java/io/netty/buffer/UnpooledUnsafeDirectByteBufWrapper.java
 ---
@@ -563,7 +564,11 @@ protected SwappedByteBuf newSwappedByteBuf() {
@Override
public ByteBuf setZero(int index, int length) {
   if (hasMemoryAddress()) {
- UnsafeByteBufUtil.setZero(this, addr(index), index, length);
+ if (length == 0) {
--- End diff --

We have to do this as UnsafeByteBufUtil.setZero(this, addr(index), index, 
length); util method is removed in 4.1.14 this was the underlying util logic.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1451: a few fixes

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1451
  
do not merge this yet please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1451: a few fixes

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1451
  
@michaelandrepearce I think those are env


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1451: a few fixes

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1451
  
@clebertsuconic failures look related to this PR that was merged 
https://github.com/apache/activemq-artemis/pull/1449


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1449: [ARTEMIS-1310] SASL GSSAPI support

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1449
  
Hi Guys, this seems to have caused a bunch of test failures, which now 
merged means all subsequent PR's are failing.

```
org.apache.activemq.artemis.utils.TimeUnitsTest.testWaitOnBoolean

org.apache.activemq.artemis.core.config.impl.ConfigurationImplTest.testAbsolutePath

org.apache.activemq.artemis.core.config.impl.DefaultsFileConfigurationTest.testAbsolutePath

org.apache.activemq.artemis.core.config.impl.FileConfigurationTest.testContextClassLoaderUsage

org.apache.activemq.artemis.core.config.impl.FileConfigurationTest.testAbsolutePath

org.apache.activemq.artemis.core.security.jaas.JAASSecurityManagerTest.testLoginClassloading[newLoader=(true)]

org.apache.activemq.artemis.core.security.jaas.JAASSecurityManagerTest.testLoginClassloading[newLoader=(false)]

org.apache.activemq.artemis.core.security.jaas.LDAPLoginModuleTest.org.apache.activemq.artemis.core.security.jaas.LDAPLoginModuleTest

org.apache.activemq.artemis.core.security.jaas.LDAPModuleRoleExpansionTest.org.apache.activemq.artemis.core.security.jaas.LDAPModuleRoleExpansionTest

org.apache.activemq.artemis.core.security.jaas.PropertiesLoginModuleRaceConditionTest.raceConditionInUsersAndGroupsLoading
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---