Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1621
@clebertsuconic thanks!
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1631
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1621
Please.. do not merge this Pull Request.. let me do some tests with it...
@gaohoward nothing wrong with it.. it's actually great.. helped me a
lot... just that what I'm doi
+1
Ran a few examples and tests. checked tags...
Nice one Justin!
On Wed, Nov 1, 2017 at 5:21 PM, Timothy Bish wrote:
> On 11/01/2017 02:53 AM, Justin Bertram wrote:
>>
>> I would like to propose an Apache ActiveMQ Artemis 2.4.0 release.
>>
>> We had these new features and improvements added as
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1631
+1..
I can't merge it now as my workspace is a mess.. anyone feel free to merge
this if I don't get here soon.
---
Github user Haydend closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1634
---
Github user Haydend commented on the issue:
https://github.com/apache/activemq-artemis/pull/1634
Understood, thank you for your time looking into this. I will close the PR.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1634
@Haydend you don't need to set ARTEMIS.HOME as a variable.
All you do is:
from where you installed artemis:
"c:\program files\activemq-artemis\bin\art
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1634
Usually we donât do that. You just call artemis.cmd and it will read the
artemis.profile.
It seems this is break other usage.
---
Github user Haydend commented on the issue:
https://github.com/apache/activemq-artemis/pull/1634
Sorry, I'm not sure what you are asking. This is a fresh install and have
not touched the artemis.profile. It is not installed as a service. I'm setting
it up as a development instance on
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1634
Are you setting this with command line as opposed to the profile ?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1634
How do you set it on your artemis.profile ?
---
Github user Haydend commented on the issue:
https://github.com/apache/activemq-artemis/pull/1634
Running on Windows 10
%ARTEMIS_HOME% is set to "C:\Program
Files\Apache\Artemis\apache-artemis-2.3.0"
That's including the quote marks, so that when you run "echo
%ARTEMIS_HOME%" t
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1634
I donât see this error.
Please give us right steps to produce the error you saw.
Perhaps you should discuss on users or dev list.
---
GitHub user Haydend opened a pull request:
https://github.com/apache/activemq-artemis/pull/1634
Removed quotation marks from if statement in artemis.cmd
These were causing an error when %ARTEMIS_HOME% string contains quotes
also, for example : "C:\Program Files\Apache\Artemis\apache
Github user Haydend closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1633
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1633
Can you close this PR please?
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1633#discussion_r148565519
--- Diff: artemis-distribution/src/main/resources/bin/artemis.cmd ---
@@ -25,7 +25,7 @@ set ARTEMIS_HOME="%CD%"
POPD
:CHECK_
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1630
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1632
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1621#discussion_r148532812
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
---
+1 from me
On Thu, Nov 2, 2017 at 12:43 AM, Christopher Shannon <
christopher.l.shan...@gmail.com> wrote:
> I think lazy concensus is ok. As long as no one has any objections I would
> think it's ok to move ahead with it under PMC control as Tim pointed out.
> But Tim is right that should give i
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1629#discussion_r148531299
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java
---
@@
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1633
I'm handling this...
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1630#discussion_r148524207
--- Diff: RELEASING.md ---
@@ -16,16 +16,32 @@ Things to do before issuing a new release:
* Test the standalone release (this sho
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1629#discussion_r148523746
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1629
---
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1629#discussion_r148502455
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
---
@@ -1621,6 +1621,7 @@
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1629#discussion_r148502940
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java
---
@@ -1
GitHub user Haydend opened a pull request:
https://github.com/apache/activemq-artemis/pull/1633
Modified artemis.cmd to be able to handle an ARTEMIS_HOME containing spaces
For example : 'C:\Program Files\Apache\Artemis\apache-artemis-2.3.0'.
You can merge this pull request into a Gi
30 matches
Mail list logo
