[GitHub] activemq-artemis issue #1920: Added acknowledgements for messages expired wi...

2018-03-05 Thread ilkkavi
Github user ilkkavi commented on the issue: https://github.com/apache/activemq-artemis/pull/1920 Excellent, thank you! ---

[GitHub] activemq-artemis pull request #1920: Added acknowledgements for messages exp...

2018-03-05 Thread ilkkavi
Github user ilkkavi closed the pull request at: https://github.com/apache/activemq-artemis/pull/1920 ---

[GitHub] activemq-artemis pull request #1931: ARTEMIS-1719 fix threadleakrule after N...

2018-03-05 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1931 ARTEMIS-1719 fix threadleakrule after Netty upgrade You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMI

[GitHub] activemq-artemis pull request #1922: [ARTEMIS-1724] Create Artemis Openwire ...

2018-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1922 ---

[GitHub] activemq-artemis issue #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS 2.0 Co...

2018-03-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1733 @clebertsuconic nudge nudge wink wink :) ---

[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...

2018-03-05 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1913#discussion_r172316762 --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js --- @@ -96,6 +96,9 @@ var ARTEMIS = (function(ARTEMI

[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...

2018-03-05 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1913#discussion_r172316744 --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js --- @@ -231,6 +234,17 @@ var ARTEMIS = (function(ART

[GitHub] activemq-artemis pull request #1930: ARTEMIS-1730 fix expiry without address...

2018-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1930 ---

[GitHub] activemq-artemis pull request #1917: ARTEMIS-1719 Update Netty to 4.1.22-Fin...

2018-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1917 ---

[GitHub] activemq-artemis issue #1920: Added acknowledgements for messages expired wi...

2018-03-05 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1920 I wanted to keep your commit, but I also wanted to get this merged so it can be included in the upcoming 2.5 release. Therefore, I sent #1930 which has your commit with and updated commi

[GitHub] activemq-artemis pull request #1930: ARTEMIS-1730 fix expiry without address...

2018-03-05 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1930 ARTEMIS-1730 fix expiry without address or bindings You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMI

[GitHub] activemq-artemis pull request #1925: ARTEMIS-1727 - Make sure transport is s...

2018-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1925 ---

[GitHub] activemq-artemis issue #1925: ARTEMIS-1727 - Make sure transport is stopped ...

2018-03-05 Thread cshannon
Github user cshannon commented on the issue: https://github.com/apache/activemq-artemis/pull/1925 @tabish121 - PR has been updated to use the broker's scheduled pool ---

[GitHub] activemq-artemis issue #1929: ARTEMIS-1728 Reclaim memory when page cursor c...

2018-03-05 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1929 Good catch!! ---

[GitHub] activemq-artemis pull request #1929: ARTEMIS-1728 Reclaim memory when page c...

2018-03-05 Thread shoukunhuai
GitHub user shoukunhuai opened a pull request: https://github.com/apache/activemq-artemis/pull/1929 ARTEMIS-1728 Reclaim memory when page cursor complete Free hash set used to hold page position for acks and removed refs. The two set is cleared, but they still hold a big array.

[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...

2018-03-05 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1913#discussion_r172121469 --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/html/deleteDivert.html --- @@ -0,0 +1,24 @@ + + --- End diff

[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...

2018-03-05 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1913#discussion_r172121106 --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/html/deleteDivert.html --- @@ -0,0 +1,24 @@ + + --- End diff

[GitHub] activemq-artemis pull request #1913: ARTEMIS-1715 Disable to remove a divert...

2018-03-05 Thread stanlyDoge
Github user stanlyDoge commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1913#discussion_r172115995 --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/html/deleteDivert.html --- @@ -0,0 +1,24 @@ + + --- End diff --