[GitHub] activemq-artemis pull request #1973: ARTEMIS-375:When use ./artemis data exp...

2018-03-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1973 ---

[GitHub] activemq-artemis issue #1973: ARTEMIS-375:When use ./artemis data exp, the x...

2018-03-23 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1973 on master, you can use --output filename now... but I will merge this. ---

[GitHub] activemq-artemis pull request #1964: [ARTEMIS-1761] Log one warning if clust...

2018-03-23 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1964#discussion_r176795441 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java --- @@ -927,9 +927,7 @@

[GitHub] activemq-artemis pull request #1961: [ARTEMIS-1758] support SASL EXTERNAL wi...

2018-03-23 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1961#discussion_r176769932 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPConnectionCallback.java ---

[GitHub] activemq-artemis pull request #1961: [ARTEMIS-1758] support SASL EXTERNAL wi...

2018-03-23 Thread gtully
Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1961#discussion_r176762803 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPConnectionCallback.java ---

Re: [HEADS-UP] 2.5.1 in one week

2018-03-23 Thread Clebert Suconic
I won't be able to do it next week... I want to push it in 4 weeks from now. (Unless someone has an urgent need for this release.. on which case i will need someone else to be the release manager as I can't for personal reasons ...) On Thu, Mar 15, 2018 at 10:33 PM, Clebert Suconic

[GitHub] activemq-artemis pull request #1964: [ARTEMIS-1761] Log one warning if clust...

2018-03-23 Thread rstancel
Github user rstancel commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1964#discussion_r176724023 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java --- @@ -927,9 +927,7 @@ protected

[GitHub] activemq-artemis pull request #1961: [ARTEMIS-1758] support SASL EXTERNAL wi...

2018-03-23 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1961#discussion_r176719439 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPConnectionCallback.java ---

[GitHub] activemq-artemis pull request #1961: [ARTEMIS-1758] support SASL EXTERNAL wi...

2018-03-23 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1961#discussion_r176719562 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPConnectionCallback.java ---

[GitHub] activemq-artemis pull request #1973: ARTEMIS-375:When use ./artemis data exp...

2018-03-23 Thread RaiSaurabh
GitHub user RaiSaurabh opened a pull request: https://github.com/apache/activemq-artemis/pull/1973 ARTEMIS-375:When use ./artemis data exp, the xml printed to stdout with logging infomation Now the logging information is not printed in the stdout. You can merge this pull request

[GitHub] activemq-artemis pull request #1964: [ARTEMIS-1761] Log one warning if clust...

2018-03-23 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1964#discussion_r176662690 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java --- @@ -927,9 +927,7 @@

[GitHub] activemq-artemis issue #1969: ARTEMIS-1762 JdbcNodeManager shouldn't be used...

2018-03-23 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1969 looks ok to me ---