[GitHub] activemq-artemis issue #1983: ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1983
  
@ingo1121 actually I'm reverting this PR. These examples are not running 
after your change. I shouldn't have merged it in the first place


---

[GitHub] activemq-artemis pull request #1984: ARTEMIS-1779 ClusterConnectionBridge ma...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1984


---

[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[rstancel]

Github user rstancel commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1990#discussion_r178928320
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
 ---
@@ -29,12 +29,7 @@
 import java.util.concurrent.atomic.AtomicInteger;
 
 import org.apache.activemq.artemis.api.config.ActiveMQDefaultConfiguration;
-import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
-import org.apache.activemq.artemis.api.core.ActiveMQBuffers;
-import org.apache.activemq.artemis.api.core.ActiveMQException;
-import org.apache.activemq.artemis.api.core.ActiveMQExceptionType;
-import org.apache.activemq.artemis.api.core.Message;
-import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.api.core.*;
--- End diff --

@jbertram Fixed.


---

[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[jbertram]

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1990#discussion_r178924323
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
 ---
@@ -29,12 +29,7 @@
 import java.util.concurrent.atomic.AtomicInteger;
 
 import org.apache.activemq.artemis.api.config.ActiveMQDefaultConfiguration;
-import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
-import org.apache.activemq.artemis.api.core.ActiveMQBuffers;
-import org.apache.activemq.artemis.api.core.ActiveMQException;
-import org.apache.activemq.artemis.api.core.ActiveMQExceptionType;
-import org.apache.activemq.artemis.api.core.Message;
-import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.api.core.*;
--- End diff --

Star imports like this are not allowed by our checkstyle config. You'll 
need to change this for the PR build to pass.


---

[GitHub] activemq-artemis issue #1990: [ARTEMIS-1770] Log warning instead of stacktra...

[rstancel]

Github user rstancel commented on the issue:

https://github.com/apache/activemq-artemis/pull/1990
  
While clear shutdown it makes no sence to throw any exception. It should be 
sufficient just to log message about whats happening.


---

[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[rstancel]

GitHub user rstancel opened a pull request:

https://github.com/apache/activemq-artemis/pull/1990

[ARTEMIS-1770] Log warning instead of stacktrace while shutdown

Jira: https://issues.apache.org/jira/browse/ARTEMIS-1770

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rstancel/jboss-activemq-artemis ARTEMIS-1770

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1990.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1990


commit 1b8eb06a14fcf03e37c29091e686748abb54d505
Author: Radovan Stancel 
Date:   2018-04-03T11:29:33Z

[ARTEMIS-1770] Log warning when connection is closed




---

[GitHub] activemq-artemis issue #1985: ARTEMIS-1780 Handle conversion of large Object...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1985
  
Thanks a lot.  I will check what’s going on. Thanks. 


---

[GitHub] activemq-artemis issue #1985: ARTEMIS-1780 Handle conversion of large Object...

[tabish121]

Github user tabish121 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1985
  
That's twice now today I've rebased.  Test failure doesn't seem related to 
AMQP


---

[GitHub] activemq-artemis issue #1985: ARTEMIS-1780 Handle conversion of large Object...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1985
  
@tabish121  this passed earlier today and failed now...

Can you rebase (change the commit id) just to force another build please?


---

[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1987
  
@TomasHofman look under master/tests/compatiblity-tests


There are a bunch of tests where we mix different versions using 
classLoading and groovy to avoid syntax dependency on specific versions...


Talk to me offline (you know where to find me) if you have issues on 
writing one.. or if you can't for any other reason.


---

[GitHub] activemq-artemis pull request #1989: ARTEMIS-1772 Reduce memory footprint an...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1989


---

[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

[TomasHofman]

Github user TomasHofman commented on the issue:

https://github.com/apache/activemq-artemis/pull/1987
  
@clebertsuconic could you point me to where you keep similar tests? So far 
I have a deal with EAP QE that they would create it for EAP.


---

[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1987
  
It would be nice to have a compatibility test added.


---

[GitHub] activemq-artemis pull request #1989: ARTEMIS-1772 Reduce memory footprint an...

[franz1981]

GitHub user franz1981 opened a pull request:

https://github.com/apache/activemq-artemis/pull/1989

ARTEMIS-1772 Reduce memory footprint and allocations of QueueImpl

It includes:
- Message References: no longer uses boxed primitives and AtomicInteger
- Node: intrusive nodes no longer need a reference field holding itself
- RefCountMessage: no longer uses AtomicInteger, but 
AtomicIntegerFieldUpdater

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/franz1981/activemq-artemis msg_ref_footprint

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1989.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1989


commit 611cd0d16c2c402dd85416bb01c72bfc3b99e1d8
Author: Francesco Nigro 
Date:   2018-03-20T09:16:24Z

ARTEMIS-1772 Reduce memory footprint and allocations of QueueImpl

It includes:
- Message References: no longer uses boxed primitives and AtomicInteger
- Node: intrusive nodes no longer need a reference field holding itself
- RefCountMessage: no longer uses AtomicInteger, but 
AtomicIntegerFieldUpdater




---

[GitHub] activemq-artemis pull request #1988: ARTEMIS-1782 fix for displaying hawtio ...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/1988

ARTEMIS-1782 fix for displaying hawtio console sub-level tabs



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis E1166

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1988.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1988


commit 46d1be6f6293c86cc11abfc10b3eee5246bcb200
Author: Stanislav Knot 
Date:   2018-04-03T13:23:08Z

ARTEMIS-1782 fix for displaying hawtio console sub-level tabs




---

[GitHub] activemq-artemis issue #1985: ARTEMIS-1780 Handle conversion of large Object...

[tabish121]

Github user tabish121 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1985
  
I updated the patch to remove the duplicate decode which seems to have been 
the root cause of the other test failure. 


---

[GitHub] activemq-artemis pull request #1984: ARTEMIS-1779 ClusterConnectionBridge ma...

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1984#discussion_r178819137
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
 ---
@@ -127,9 +126,6 @@ public ClusterConnectionBridge(final ClusterConnection 
clusterConnection,
   this.managementNotificationAddress = managementNotificationAddress;
   this.flowRecord = flowRecord;
 
-  // we need to disable DLQ check on the clustered bridges
-  queue.setInternalQueue(true);
--- End diff --

Thanks!


---

[GitHub] activemq-artemis pull request #1984: ARTEMIS-1779 ClusterConnectionBridge ma...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1984#discussion_r178814438
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
 ---
@@ -127,9 +126,6 @@ public ClusterConnectionBridge(final ClusterConnection 
clusterConnection,
   this.managementNotificationAddress = managementNotificationAddress;
   this.flowRecord = flowRecord;
 
-  // we need to disable DLQ check on the clustered bridges
-  queue.setInternalQueue(true);
--- End diff --

Ok.. I see..

I have a small refactoring on this.. instead of trusting queue.isInternal I 
think we should move nodeUp to Bridge, and @override on the ClusterBridge.

I'm running some tests before I merge it.


---

[GitHub] activemq-artemis pull request #1986: ARTEMIS-1653 Allow database tables to b...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1986#discussion_r178806417
  
--- Diff: 
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
 ---
@@ -191,9 +191,18 @@ private void createTableIfNotExists(String tableName, 
String... sqls) throws SQL
 } else {
try (Statement statement = connection.createStatement();
  ResultSet cntRs = 
statement.executeQuery(sqlProvider.getCountJournalRecordsSQL())) {
-  if (rs.next() && rs.getInt(1) > 0) {
+  int rows;
+  if (cntRs.next() && (rows = cntRs.getInt(1)) > 0) {
  logger.tracef("Table %s did exist but is not empty. 
Skipping initialization.", tableName);
+ if (logger.isDebugEnabled()) {
+final long expectedRows = 
Stream.of(sqls).map(String::toUpperCase).filter(sql -> sql.contains("INSERT 
INTO")).count();
--- End diff --

Are you sure you meant this INSERT to only happen if debug?


---

[GitHub] activemq-artemis issue #1986: ARTEMIS-1653 Allow database tables to be creat...

[nlippke]

Github user nlippke commented on the issue:

https://github.com/apache/activemq-artemis/pull/1986
  
@franz1981 :+1:


---

[GitHub] activemq-artemis issue #1986: ARTEMIS-1653 Allow database tables to be creat...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1986
  
@nlippke 

> Statement-checks are all uppercase. Implementors using this method need 
to be aware of it

Thanks for the note :+1: I have added a `String::toUpperCase` while 
performing the checks as well.
Are not perfect/safe enough to be used as proper checks (throwing 
anything), but at least could help to spot regressions on tests due to some 
changes/configurations.


---

[GitHub] activemq-artemis pull request #1987: [ENTMQBR-1034] Connector parameters not...

[TomasHofman]

GitHub user TomasHofman opened a pull request:

https://github.com/apache/activemq-artemis/pull/1987

[ENTMQBR-1034] Connector parameters not backward compatible

https://issues.jboss.org/browse/ENTMQBR-1034

Fixing backward compatibility with HornetQ:
* Translate transport parameters to dash notation instead of camel-case 
when talking to legacy clients.
* Do not add passwordCodec parameter unless maskPassword is true.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TomasHofman/activemq-artemis 
JBEAP-14190-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1987.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1987


commit a09b374b8613f3216b9d683f4bfb2e4a9e62e463
Author: Tomas Hofman 
Date:   2018-03-28T13:07:21Z

[ENTMQBR-1034] Connector parameters not backward compatible




---

[GitHub] activemq-artemis issue #1986: ARTEMIS-1653 Allow database tables to be creat...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1986
  
@clebertsuconic I haven't reverted tha change made by 
https://github.com/apache/activemq-artemis/commit/ef74221684e8bf7f5ad0992f2c4ef81aa2ff986e
 but isn't necessary anymore, because with this fix it works without the change 
too.
@nlippke how it seems now? I have added a couple of checks to simplify 
spotting weird initialisation errors on tests too.


---

[GitHub] activemq-artemis pull request #1986: ARTEMIS-1653 Allow database tables to b...

[franz1981]

GitHub user franz1981 opened a pull request:

https://github.com/apache/activemq-artemis/pull/1986

ARTEMIS-1653 Allow database tables to be created externally

The previous commit about this feature wasn't using the right ResultSet
to count the rows in a table.
Additional checks have been added to:
- verify that the first SQL statement is a CREATE TABLE
- log if the existing rows are less than the expected ones

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-1653

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1986.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1986


commit 66c442dd6a4eae02f7ac0d84eb0bffd6df9a01b3
Author: Francesco Nigro 
Date:   2018-04-03T08:11:04Z

ARTEMIS-1653 Allow database tables to be created externally

The previous commit about this feature wasn't using the right ResultSet
to count the rows in a table.
Additional checks have been added to:
- verify that the first SQL statement is a CREATE TABLE
- log if the existing rows are less than the expected ones




---