[GitHub] activemq-artemis pull request #2039: [ARTEMIS-1823] - Log warning on boot wh...

2018-04-23 Thread JiriOndrusek
Github user JiriOndrusek commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2039#discussion_r183613601 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -2323,6 +2324,16 @@ synch

[GitHub] activemq-artemis pull request #2041: ARTEMIS-1825 Live-backup topology not c...

2018-04-23 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2041 ARTEMIS-1825 Live-backup topology not correctly displayed on console You can merge this pull request into a Git repository by running: $ git pull https://github.com/gaohoward/acti

[GitHub] activemq-artemis pull request #2036: ARTEMIS-1821 LDAPLoginModule always ret...

2018-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2036 ---

[GitHub] activemq-artemis pull request #2013: ARTEMIS-1805 fix for broker operations ...

2018-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2013 ---

[GitHub] activemq-artemis pull request #2039: [ARTEMIS-1823] - Log warning on boot wh...

2018-04-23 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2039#discussion_r183472200 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -2323,6 +2324,16 @@ syn

[GitHub] activemq-artemis pull request #2040: ARTEMIS-1824 running broker from path w...

2018-04-23 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2040#discussion_r183471882 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/XMLUtil.java --- @@ -323,7 +323,7 @@ public static double pa

[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...

2018-04-23 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2010#discussion_r183418125 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java --- @@ -2712,6 +2714,11 @@ private Mess

[GitHub] activemq-artemis issue #2010: ARTEMIS-1801 removing null-unchecked dereferen...

2018-04-23 Thread stanlyDoge
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/2010 @clebertsuconic polished :) ---

[GitHub] activemq-artemis issue #2013: ARTEMIS-1805 fix for broker operations in hawt...

2018-04-23 Thread stanlyDoge
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/2013 @gaohoward Done. ---

[GitHub] activemq-artemis pull request #2040: ARTEMIS-1824 running broker from path w...

2018-04-23 Thread stanlyDoge
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/2040 ARTEMIS-1824 running broker from path with non-ascii chars You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/activemq-art

[GitHub] activemq-artemis pull request #2039: [ARTEMIS-1823] - Log warning on boot wh...

2018-04-23 Thread JiriOndrusek
GitHub user JiriOndrusek opened a pull request: https://github.com/apache/activemq-artemis/pull/2039 [ARTEMIS-1823] - Log warning on boot when persistence is disabled and… … paging enabled Issue: https://issues.apache.org/jira/browse/ARTEMIS-1823 Added warning i

[GitHub] activemq-artemis issue #2035: [ARTEMIS-1819] Missing fields on listAllConsum...

2018-04-23 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2035 I think the first thing to clarify is exactly what information is missing which your clients need. ---

[GitHub] activemq-artemis issue #2035: [ARTEMIS-1819] Missing fields on listAllConsum...

2018-04-23 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2035 It’s on the address and queue information ---

[GitHub] activemq-artemis issue #2035: [ARTEMIS-1819] Missing fields on listAllConsum...

2018-04-23 Thread iweiss
Github user iweiss commented on the issue: https://github.com/apache/activemq-artemis/pull/2035 @michaelandrepearce @jbertram Thanks for your comments. Where would be the best place to add this information back to a consumer of these methods? ---