Re: [VOTE] Apache ActiveMQ Artemis 2.6.0

2018-05-16 Thread Howard Gao
+1 On Thu, May 17, 2018 at 10:49 AM, Clebert Suconic wrote: > I would like to propose an Apache ActiveMQ Artemis 2.6.0 release. > > The release notes can be found here: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > version=12342903&=12315920 > > There

[DISCUSS] Commits report

2018-05-16 Thread Clebert Suconic
Before someone asks on the VOTE Thread.. I wanted to point out that I made a small project to parse git commit and generate a report. I have ran the report on top of artemis and I'm adding a commit report here that can be useful at least on the voter's thread:

[VOTE] Apache ActiveMQ Artemis 2.6.0

2018-05-16 Thread Clebert Suconic
I would like to propose an Apache ActiveMQ Artemis 2.6.0 release. The release notes can be found here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342903&=12315920 There is a new commits report I made that I'm introducing on this release:

Re: [HEADS-UP] 2.5.1 in one week

2018-05-16 Thread Clebert Suconic
I have been pushing this for a few weeks. I thought it was more than clear. I didn’t mean to get anyone by surprise. Along the conversation here 2.5.1 will just be renamed as 2.6.0. I’m traveling today and I wanted to tag and upload from home. And I wanted something to do tonight at the

Re: [HEADS-UP] 2.5.1 in one week

2018-05-16 Thread Timothy Bish
On 05/16/2018 11:09 AM, Clebert Suconic wrote: I just tagged as 2.6.0... It's uploading... I will cleanup JIRA tonight / tomorrow.. should send the voting thread soon (tonight or tomorrow) This seems a bit backwards to me.  I'd think in the future it'd be nice to send some notice before you

Re: Reword NMS for AMQPNetLite

2018-05-16 Thread Duane Pauls
To clarify, Ragnar is referring to the NMS.AMQP rework proposed earlier on the dev list. I believe what was agreed to in principle was to donate the contents of our github repo: https://github.com/cjwmorgan-sol-sys/nms-amqp To replace the contents of the existing NMS.AMQP repo:

Re: What is the best architecture to set up an activemq cluster to achieve high service and data availability

2018-05-16 Thread maheedhar1010
Thanks MichaelAndrePearce. we will take a look at it -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

Re: [HEADS-UP] 2.5.1 in one week

2018-05-16 Thread Clebert Suconic
I just tagged as 2.6.0... It's uploading... I will cleanup JIRA tonight / tomorrow.. should send the voting thread soon (tonight or tomorrow) On Thu, May 10, 2018 at 10:33 AM, Clebert Suconic wrote: > I have been clearing the testsuite. Other guys are working with me

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866: Make wait time for reply configu...

2018-05-16 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @RaiSaurabh > ReplicatedPolicyConfiguration::quorumVoteWait I did not change to final as the value will remain the default value until not changed from the configuration

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866: Make wait time for reply configu...

2018-05-16 Thread RaiSaurabh
Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @franz1981 Thanks for the review further. ReplicatedPolicyConfiguration::quorumVoteWait I did not change to final as the value will remain the default value until not changed from the

[GitHub] activemq-artemis pull request #2090: ARTEMIS-1868 Openwire doesn't add deliv...

2018-05-16 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2090#discussion_r188604772 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java ---

[GitHub] activemq-artemis pull request #2090: ARTEMIS-1868 Openwire doesn't add deliv...

2018-05-16 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2090#discussion_r188604794 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java ---

[GitHub] activemq-artemis pull request #2091: ARTEMIS-1870:Missing documentation for ...

2018-05-16 Thread RaiSaurabh
GitHub user RaiSaurabh opened a pull request: https://github.com/apache/activemq-artemis/pull/2091 ARTEMIS-1870:Missing documentation for parameter jdbc-journal-sync-period You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866: Make wait time for reply configu...

2018-05-16 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @RaiSaurabh Good job!! `ReplicatedPolicyConfiguration::quorumVoteWait` is still not final and expose setter when not needed ---

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866: Make wait time for reply configu...

2018-05-16 Thread RaiSaurabh
Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 I have replied and added changes that you suggested and also updated the documentation. Could you please review. ---

[GitHub] activemq-artemis pull request #2089: ARTEMIS-1866: Make wait time for reply ...

2018-05-16 Thread RaiSaurabh
Github user RaiSaurabh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2089#discussion_r188589717 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ha/ReplicatedPolicy.java --- @@ -61,6 +61,8 @@

[GitHub] activemq-artemis pull request #2089: ARTEMIS-1866: Make wait time for reply ...

2018-05-16 Thread RaiSaurabh
Github user RaiSaurabh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2089#discussion_r188589506 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/SharedNothingBackupQuorum.java --- @@ -90,6

[GitHub] activemq-artemis pull request #2089: ARTEMIS-1866: Make wait time for reply ...

2018-05-16 Thread RaiSaurabh
Github user RaiSaurabh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2089#discussion_r188589019 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/SharedNothingBackupQuorum.java --- @@ -297,7

[GitHub] activemq-artemis pull request #2090: ARTEMIS-1868 Openwire doesn't add deliv...

2018-05-16 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2090#discussion_r188532813 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java ---

[GitHub] activemq-artemis pull request #2090: ARTEMIS-1868 Openwire doesn't add deliv...

2018-05-16 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2090#discussion_r188530577 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java ---

[GitHub] activemq-artemis pull request #2090: ARTEMIS-1868 Openwire doesn't add deliv...

2018-05-16 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2090 ARTEMIS-1868 Openwire doesn't add delivery count in client ack mode If a client ack mode consumer receives a message and closes without acking it, the redelivery of the message