[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 @franz1981 non durable also needs it. ---

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 @michaelandrepearce it looks fine to me: probably I would have performed the check about the queue existence just for the durable ones ---

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 @clebertsuconic email is on its way. ---

Re: [VOTE] Apache ActiveMQ Artemis 2.6.0

Hi All, On upgrading to 2.5.0 we have found quite a blocking issue to 2.5.0 for anyone who secures durable queue creation so clients cannot create, but doesn’t secure non-durable. https://issues.apache.org/jira/browse/ARTEMIS-1872 In summary prior to 2.5.0 the security check incorrectly

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 Can you bring this up on the voting thread? ---

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 @clebertsuconic well the bug is been there for ages, just more evident/exposed since 2.5.0 where security check was corrected, so made it more apparent. If its easy to re-spin

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 Wouldn’t this make a blocker for 2.6.0? Or this is not that critical ? I’m reading on the iPhone with limited visibility of the changes. But it seems to warrant a

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 @andytaylor ---

[GitHub] activemq-artemis issue #2093: ARTEMIS-1872 Check for queue exists before cre...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2093 See for full description of the problem, or see test case. https://issues.apache.org/jira/browse/ARTEMIS-1872 ---

[GitHub] activemq-artemis pull request #2093: ARTEMIS-1872 Check for queue exists bef...

GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2093 ARTEMIS-1872 Check for queue exists before creating shared queue 1. Add tests case to verify issue and fix, tests also tests for same behavior using CORE, OPENWIRE and AMQP

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 Can we make sure a test exists that checks for default 30 is used if not set or configured I note all tests seem to be update to set this explicitly now which means nothing is

[GitHub] activemq-artemis pull request #2089: ARTEMIS-1866 Make Quorum vote result wa...

Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2089#discussion_r189334490 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/ha/ReplicaPolicyConfiguration.java --- @@ -47,7 +47,10

Re: Join to the group

Anyone can open a pull request against the GitHub mirrors, and anyone can [create an account and then] raise JIRAs. The GitHub mirrors cant have 'issues' raised against them by anyone, they arent enabled for issue tracking. On 18 May 2018 at 00:19, Arthur Naseef wrote: > Hey

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @RaiSaurabh Great, it seems near perfect to me: it would be super-perfect if you can change the commit message in something shorter like "ARTEMIS-1866 Make Quorum vote result wait time

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 @franz1981 I have updated the code. Could you please review. ---

[GitHub] activemq-artemis issue #2089: ARTEMIS-1866 Make Quorum vote result wait time...

Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/2089 retest this please ---