Hello!
I'm using Artemis as an embedded server, so I want to disable all
connection ttl checking. To do so I set connection ttl to -1 for Client
Connection Factory. But from time to time I got messages like these in log
647236 [WARN] client: AMQ212037: Connection failure has been detected:
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2111
ARTEMIS-1882 fix failing SecurityTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1882
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2110
---
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2110
ARTEMIS-1872 fix examples broken after authn change
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2108
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2107
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2106
---
GitHub user SaivR1t reopened a pull request:
https://github.com/apache/activemq/pull/283
AMQ-6963 Fix calling the toString() method in case of different log level.
Avoid calling toString() method in case of different log level, because
toString() could create additional objects or
Github user SaivR1t closed the pull request at:
https://github.com/apache/activemq/pull/283
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2107
Iâm handling this. I already added a test and I will merge this directly
on master.
---
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/2109
ARTEMIS-1888 - Fix SSL order of precedence in core client
Local connection SSL settings should be preferred over javax.ssl
settings
You can merge this pull request into a Git
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2108
ARTEMIS-1872 fix security tests
After the new authn change for creating addresses a bunch of tests need
to be updated to include the proper permissions.
You can merge this pull
Github user shailendra14k commented on the issue:
https://github.com/apache/activemq-artemis/pull/2106
@jbertram @clebertsuconic @tabish121 Thank you for the review.
I had attached a sample reproducer to the JIRA, The issue is caused while
calling both consumer.close() and
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2106
If it is fixing something then it needs a test. If it is not fixing
something than the JIRA description needs to be changed as it makes it sound
like it is fixing something, and
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2102
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2106
I mean.. based on visual inspection... and the fact that there two counters
is an issue by itself.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2106
@jbertram / @tabish121 I think we can merge this one without a test.. but
we should indicate on a comment clearly why a test is not needed on the commit.
It gets easier when we
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2106
> Perhaps the AMQP is calling removeConsumer twice... and not the same as I
did on checking if the set was empty or not?
That is what I assumed was happening.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2106
@jbertram Perhaps the AMQP is calling removeConsumer twice... and not the
same as I did on checking if the set was empty or not?
I don't see what issue this is fixing..
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2106
@jbertram I didn't find a decrement... did I miss it?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2106
@clebertsuconic, I have actually been meaning to remove the `noConsumers`
variable because I found it confusing (since the consumer count was already
tracked - first by
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2106
@clebertsuconic, I'm not sure I'm following you here. The PR removes
`noConsumers` entirely, including where it is incremented and decremented.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2106
@jbertram although I can see an issue by inspecting the code. not just for
AMQP but noConsumers is only increased.. if you open a consumer... close it..
and open it again...
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2107
@RaiSaurabh, the changes you made to SecureConfigurationTest.java have
already been merged in a different PR. Also, this fix needs a test-case to
validate it. Can you add one?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2106
@tabish121, good point. @shailendra14k, please add a test to validate this
fix.
---
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2106
There's no tests here, how do we know this does or does not fix an issue
that may or may not exist given there's no test provided to observe it ?
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2106
Please rebase this and push -f to kick off another PR build. The issue
that caused the failure should be addressed now. Thanks!
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2102#discussion_r190585655
--- Diff:
tests/compatibility-tests/src/main/resources/servers/artemisServer.groovy ---
@@ -44,7 +44,7 @@ try {
if
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2105
---
GitHub user RaiSaurabh opened a pull request:
https://github.com/apache/activemq-artemis/pull/2107
ARTEMIS-1887 Setting default-max-consumers in address-setting not working
When setting "default-max-consumers" in addressing setting in broker.xml
It has no effect on the
GitHub user shailendra14k opened a pull request:
https://github.com/apache/activemq-artemis/pull/2106
[ARTEMIS-1885]max-consumers attribute in queue definition does not work for
AMQP client.
Jira:- https://issues.apache.org/jira/browse/ARTEMIS-1885
You can merge this pull request
31 matches
Mail list logo
