GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/1342
NO-JIRA fix typos in documentation
fix some typos in documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bennetelli
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
ok. strange. will check that. thanks for mertging @clebertsuconic ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
@clebertsuconic yep. thx. thought I would have fixed it myself..
the steps I did:
- git rebase -i HEAD~1
- change commit message
- git push --force
what
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
@clebertsuconic why? do you mean specifics like version numbers or IntelliJ
specifics in general?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1281
Argh.. So you need to reject it, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/1281
ARTEMIS-1147 Update Hacking Guide Documentation: IDE Integration
the IntelliJ import wizard doesn't contain a sentence like:"Select "Import
from existing model&quo
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/1231
squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/1231
ARTEMIS-904 Remove cyclic dependencies from artemis-cli
move classes and methods to their correct location to avoid cyclic
dependencies between packages and classes. I also removed
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/1159
Update examples.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bennetelli/activemq-artemis patch-1
Alternatively you can
Github user bennetelli closed the pull request at:
https://github.com/apache/activemq-artemis/pull/944
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/944
sh**. Created the branch from my previous ARTEMIS-903 branch. Would be good
if we could close the second one (ARTEMIS-904) and I will open a new PR later.
---
If your project is set up
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/944
Can't find any checkstyle warnings. Where are you looking for it?
The Jenkins build failed because of an error in LDAP stuff which I didn't
touch with my new markdown documentation
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/944
@clebertsuconic argh. Thought another branch would result in a separate
pull request. Let me know if you have trouble with it :/
---
If your project is set up for it, you can reply
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/944
ARTEMIS-904 - Remove cyclic dependencies from artemis-cli
To ensure a maintainability in future I refactored the cli project and
removed all cyclic dependencies between classes
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/943
Happy new year, Clebert :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/943
ARTEMIS-903 Add documentation for updating Artemis to newer versions
Currently there is no documentation about updating ActiveMQ Artemis in the
Artemis user manual. This commit adds
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/873
closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bennetelli closed the pull request at:
https://github.com/apache/activemq-artemis/pull/873
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bennetelli closed the pull request at:
https://github.com/apache/activemq-artemis/pull/873
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bennetelli reopened a pull request:
https://github.com/apache/activemq-artemis/pull/873
ARTEMIS-830 Remove cyclic dependencies from artemis-jdbc-store
Removes cyclic dependencies between classes and packages in the
artemis-jdbc-store projetct by moving classes
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/873
Okay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/873
ARTEMIS-830 Remove cyclic dependencies
Removes cyclic dependencies between classes and packages in the
artemis-jdbc-store projetct by moving classes and methods to other locations
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/780
thanks clebert.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/780
will take a look at this pr at thursday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/780
typically I don't do those things with git. Squashing commits and working
with github pull request is new to me as well. Will do it better in future. I
promise ;) Thanks for your help
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/780
Removed unused JMS class and Test from artemis-rest
The JMS class in the artemis-rest project seems to be unused.
You can merge this pull request into a Git repository by running
Github user bennetelli closed the pull request at:
https://github.com/apache/activemq-artemis/pull/757
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/757
-
-
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bennetelli/activemq-artemis master
Alternatively you can review and apply
Github user bennetelli commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/718#discussion_r74697287
--- Diff:
integration/activemq-vertx-integration/src/main/java/org/apache/activemq/artemis/integration/vertx/ActiveMQVertxLogger.java
Github user bennetelli commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/718#discussion_r74622899
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/vertx/ActiveMQVertxUnitTest.java
---
@@ -792,4
Github user bennetelli commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/718#discussion_r74622451
--- Diff:
integration/activemq-vertx-integration/src/main/java/org/apache/activemq/artemis/integration/vertx/ActiveMQVertxLogger.java
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/718
Thanks for the hints @jbertram. Will squash it together and fix the
violations as well. Sorry.. didn't know that.
---
If your project is set up for it, you can reply to this email
Github user bennetelli commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/718#discussion_r74494900
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/vertx/ActiveMQVertxUnitTest.java
---
@@ -282,19
Github user bennetelli commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/718#discussion_r74493624
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/vertx/ActiveMQVertxUnitTest.java
---
@@ -282,19
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/718
Here the open improvement ticket:
https://issues.apache.org/jira/browse/ARTEMIS-680
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/718
just some refactorings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bennetelli/activemq-artemis master
Alternatively you can
36 matches
Mail list logo
