[GitHub] activemq-artemis pull request #1975: [ARTEMIS-1761] Log warning if cluster i...
Github user rstancel closed the pull request at: https://github.com/apache/activemq-artemis/pull/1975 ---
[GitHub] activemq-artemis issue #1975: [ARTEMIS-1761] Log warning if cluster is not a...
Github user rstancel commented on the issue: https://github.com/apache/activemq-artemis/pull/1975 Closing this PR as requested by Justin Bertram @jbertram ---
[GitHub] activemq-artemis pull request #2063: [ART] Fix opening SSL connection in IBM...
GitHub user rstancel opened a pull request: https://github.com/apache/activemq-artemis/pull/2063 [ART] Fix opening SSL connection in IBM JDK in tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/rstancel/jboss-activemq-artemis ARTEMIS-1844 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2063.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2063 commit 2390e3020c8aa195e34c8c04fc3da09f778116dc Author: Radovan Stancel <rstancel@...> Date: 2018-05-03T08:31:21Z [ARTEMIS-1844] Fix opening SSL connection in IBM JDK in tests ---
[GitHub] activemq-artemis pull request #1975: [ARTEMIS-1761] Log warning if cluster i...
Github user rstancel commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1975#discussion_r180048729
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
---
@@ -930,9 +930,7 @@ protected void connect() {
scheduleRetryConnectFixedTimeout(this.retryInterval);
return;
} else {
- if (logger.isDebugEnabled()) {
- logger.debug("Bridge " + this + " is unable to connect
to destination. Retrying", e);
--- End diff --
@clebertsuconic it was different issues.
https://github.com/apache/activemq-artemis/pull/1990 . Should I create new PR
in master?
---
[GitHub] activemq-artemis pull request #1995: [ARTEMIS-1770] Log warning when connect...
GitHub user rstancel opened a pull request: https://github.com/apache/activemq-artemis/pull/1995 [ARTEMIS-1770] Log warning when connection is closed Jira: https://issues.apache.org/jira/browse/ARTEMIS-1770 Master PR: https://github.com/apache/activemq-artemis/pull/1990 You can merge this pull request into a Git repository by running: $ git pull https://github.com/rstancel/jboss-activemq-artemis ARTEMIS-1770_1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1995.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1995 ---
[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...
Github user rstancel commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1990#discussion_r179361706
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
---
@@ -1539,6 +1540,8 @@ public void end(final Xid xid, final int flags)
throws XAException {
startCall();
try {
sessionContext.xaEnd(xid, flags);
+} catch (ActiveMQNotConnectedException ex) {
+
ActiveMQClientLogger.LOGGER.connectionClosedWarn(ex.getType(), ex.getMessage());
--- End diff --
@clebertsuconic Done.
---
[GitHub] activemq-artemis issue #1990: [ARTEMIS-1770] Log warning instead of stacktra...
Github user rstancel commented on the issue: https://github.com/apache/activemq-artemis/pull/1990 Can someone please run retest? I have the same issue on Travis as this PR: https://github.com/apache/activemq-artemis/pull/1985 and I think it has nothing to do with my PR ---
[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...
Github user rstancel commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1990#discussion_r178928320 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -29,12 +29,7 @@ import java.util.concurrent.atomic.AtomicInteger; import org.apache.activemq.artemis.api.config.ActiveMQDefaultConfiguration; -import org.apache.activemq.artemis.api.core.ActiveMQBuffer; -import org.apache.activemq.artemis.api.core.ActiveMQBuffers; -import org.apache.activemq.artemis.api.core.ActiveMQException; -import org.apache.activemq.artemis.api.core.ActiveMQExceptionType; -import org.apache.activemq.artemis.api.core.Message; -import org.apache.activemq.artemis.api.core.SimpleString; +import org.apache.activemq.artemis.api.core.*; --- End diff -- @jbertram Fixed. ---
[GitHub] activemq-artemis issue #1990: [ARTEMIS-1770] Log warning instead of stacktra...
Github user rstancel commented on the issue: https://github.com/apache/activemq-artemis/pull/1990 While clear shutdown it makes no sence to throw any exception. It should be sufficient just to log message about whats happening. ---
[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...
GitHub user rstancel opened a pull request: https://github.com/apache/activemq-artemis/pull/1990 [ARTEMIS-1770] Log warning instead of stacktrace while shutdown Jira: https://issues.apache.org/jira/browse/ARTEMIS-1770 You can merge this pull request into a Git repository by running: $ git pull https://github.com/rstancel/jboss-activemq-artemis ARTEMIS-1770 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1990.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1990 commit 1b8eb06a14fcf03e37c29091e686748abb54d505 Author: Radovan Stancel <rstancel@...> Date: 2018-04-03T11:29:33Z [ARTEMIS-1770] Log warning when connection is closed ---
[GitHub] activemq-artemis issue #1975: [ARTEMIS-1761] Log warning if cluster is not a...
Github user rstancel commented on the issue: https://github.com/apache/activemq-artemis/pull/1975 @clebertsuconic Clebert, can you please merge also this PR? thanks ---
[GitHub] activemq-artemis pull request #1975: [ARTEMIS-1761] Log warning if cluster i...
GitHub user rstancel opened a pull request: https://github.com/apache/activemq-artemis/pull/1975 [ARTEMIS-1761] Log warning if cluster is not able to connect at startup Jira: https://issues.apache.org/jira/browse/ARTEMIS-1761 master commit: https://github.com/apache/activemq-artemis/commit/373c3db2ac4c3b79d4f777ee32498c924176eba6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/rstancel/jboss-activemq-artemis ARTEMIS-1761_1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1975.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1975 commit 6c397fda732837191c63e65507ad58a16b25bf70 Author: Radovan Stancel <rstancel@...> Date: 2018-03-21T17:26:20Z [ARTEMIS-1761] Log warning if cluster is not able to connect at startup ---
[GitHub] activemq-artemis issue #1964: [ARTEMIS-1761] Log one warning if cluster coul...
Github user rstancel commented on the issue: https://github.com/apache/activemq-artemis/pull/1964 @clebertsuconic yeap, I will do that once it will be approved ---
[GitHub] activemq-artemis issue #1964: [ARTEMIS-1761] Log one warning if cluster coul...
Github user rstancel commented on the issue: https://github.com/apache/activemq-artemis/pull/1964 @michaelandrepearce Done. Can you please check? Thanks ---
[GitHub] activemq-artemis pull request #1964: [ARTEMIS-1761] Log one warning if clust...
Github user rstancel commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1964#discussion_r176724023
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
---
@@ -927,9 +927,7 @@ protected void connect() {
scheduleRetryConnectFixedTimeout(this.retryInterval);
return;
} else {
- if (logger.isDebugEnabled()) {
- logger.debug("Bridge " + this + " is unable to connect
to destination. Retrying", e);
- }
+ logger.warn("Bridge " + this + " is unable to connect to
destination. Retrying...");
--- End diff --
@michaelandrepearce I have used the same message as in another if-else
condition. is it ok?
---
[GitHub] activemq-artemis pull request #1964: [ARTEMIS-1761] Log one warning if clust...
GitHub user rstancel opened a pull request: https://github.com/apache/activemq-artemis/pull/1964 [ARTEMIS-1761] Log one warning if cluster could not be formed because⦠⦠it's not possible to connect to other cluster node Jira: https://issues.apache.org/jira/browse/ARTEMIS-1761 You can merge this pull request into a Git repository by running: $ git pull https://github.com/rstancel/jboss-activemq-artemis ARTEMIS-1761 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1964.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1964 commit 0aad3b89948df94fa414e81d4b5190505940f4b1 Author: Radovan STANCEL <rstancel@...> Date: 2018-03-21T17:26:20Z [ARTEMIS-1761] Log one warning if cluster could not be formed because it's not possible to connect to other cluster node ---
