[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...

2018-11-05 Thread mtaylor 
Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/2415
  
@franz1981 Thanks for making the requested changes.  Merging


---

[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...

2018-11-05 Thread andytaylor 
Github user andytaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/2415
  
This looks fine


---

[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...

2018-11-04 Thread franz1981 
Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/2415
  
According to the CI results:

![image](https://user-images.githubusercontent.com/13125299/47982793-4ed26c80-e0d1-11e8-9254-e9c15e2ae2e5.png)
On the left is master, while on the right is this PR branch +1
There are about 6 less failures and 1 more, but are almost intermittent 
ones, so it seems stable similarly to master.


---

[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...

2018-11-04 Thread franz1981 
Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/2415
  
I'm running a full CI run on this one to check if it is safe :+1: 


---