[GitHub] activemq-artemis issue #1986: ARTEMIS-1653 Allow database tables to be creat...

2018-04-03 Thread nlippke 
Github user nlippke commented on the issue:

https://github.com/apache/activemq-artemis/pull/1986
  
@franz1981 :+1:


---

[GitHub] activemq-artemis issue #1986: ARTEMIS-1653 Allow database tables to be creat...

2018-04-03 Thread franz1981 
Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1986
  
@nlippke 

> Statement-checks are all uppercase. Implementors using this method need 
to be aware of it

Thanks for the note :+1: I have added a `String::toUpperCase` while 
performing the checks as well.
Are not perfect/safe enough to be used as proper checks (throwing 
anything), but at least could help to spot regressions on tests due to some 
changes/configurations.


---

[GitHub] activemq-artemis issue #1986: ARTEMIS-1653 Allow database tables to be creat...

2018-04-03 Thread franz1981 
Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1986
  
@clebertsuconic I haven't reverted tha change made by 
https://github.com/apache/activemq-artemis/commit/ef74221684e8bf7f5ad0992f2c4ef81aa2ff986e
 but isn't necessary anymore, because with this fix it works without the change 
too.
@nlippke how it seems now? I have added a couple of checks to simplify 
spotting weird initialisation errors on tests too.


---