Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/780
thanks clebert.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/780
I did this now since I'm about to make a release and wanted to finish most
of what I could.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/780
I fixed it myself with some git-fu while I merged it (amends and stuff)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/780
will take a look at this pr at thursday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/780
Any update on this PR? It not only needs to be squashed, but the commit
message needs to be amended to follow the 50/72 pattern discussed in the
[Hacking
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/780
typically I don't do those things with git. Squashing commits and working
with github pull request is new to me as well. Will do it better in future. I
promise ;) Thanks for your help
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/780
I see what you did, you changed the title of the PR. you have to change the
title of the committs.. look at my previous comment.
---
If your project is set up for it, you can reply
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/780
You should make JIRA to be part of the commits... the PR name will get lost
once merged.
do this:
git rebase -i HEAD~2
edit the name of
