[GitHub] activemq-artemis pull request #1857: ARTEMIS-1669 JMS message is not receive...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1857


---

[GitHub] activemq-artemis pull request #1857: ARTEMIS-1669 JMS message is not receive...

[JiriOndrusek]

Github user JiriOndrusek commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1857#discussion_r170531201
  
--- Diff: 
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java
 ---
@@ -122,6 +122,10 @@
 
private String entries;
 
+   //fix of JBEAP-12720 - propagated value of transactional attribute 
JMSConnectionFactoryDefinition annotation with the
--- End diff --

Hi, I've missed this reference, too, I'll change it to ARTEMIS-1669.


---

[GitHub] activemq-artemis pull request #1857: ARTEMIS-1669 JMS message is not receive...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1857#discussion_r170513149
  
--- Diff: 
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java
 ---
@@ -122,6 +122,10 @@
 
private String entries;
 
+   //fix of JBEAP-12720 - propagated value of transactional attribute 
JMSConnectionFactoryDefinition annotation with the
--- End diff --

Should this reference an Apache jira?


---

[GitHub] activemq-artemis pull request #1857: ARTEMIS-1669 JMS message is not receive...

[jbertram]

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1857#discussion_r168862534
  
--- Diff: 
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRASessionFactoryImpl.java
 ---
@@ -819,13 +819,12 @@ protected ActiveMQRASession 
allocateConnection(boolean transacted,
 //from createSession
 // In a Java EE web or EJB container, when there is an active 
JTA transaction in progress:
 //Both arguments {@code transacted} and {@code 
acknowledgeMode} are ignored.
-if (inJtaTransaction()) {
+// fix of JBEAP-12720 - when a JMSConnectionFactoryDefinition 
annotation with the transactional attribute set to false="false" is set
--- End diff --

This should reference the ARTEMIS JIRA rather than JBEAP.


---

[GitHub] activemq-artemis pull request #1857: ARTEMIS-1669 JMS message is not receive...

[JiriOndrusek]

GitHub user JiriOndrusek opened a pull request:

https://github.com/apache/activemq-artemis/pull/1857

ARTEMIS-1669 JMS message is not received when using a non-transaction…

…al JMSConnectionFactoryDefinition

Issue: https://issues.apache.org/jira/browse/ARTEMIS-1669

If JMSConnectionFactoryDefinition annotation with the transactional 
attribute set to false, connections should not participate in transactions. 
I've added parameter ignoreJTA (by default false - to keep current behavior). 
If parameter is set to true (== value in annotation is false), 
ActiveMQRASessionFactoryImpl.java then force correct behavior.

Integration test IgnoreJTATest.java makes sure, that it works.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/JiriOndrusek/activemq-artemis ARTEMIS-1669

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1857.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1857


commit 12892e2285f5e546de776bd3869524225f65f876
Author: JiriOndrusek 
Date:   2018-02-08T11:47:10Z

ARTEMIS-1669 JMS message is not received when using a non-transactional 
JMSConnectionFactoryDefinition




---