[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...

2018-08-13 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2238#discussion_r209819327 --- Diff: artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java ---

[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...

2018-08-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2238 ---

[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...

2018-08-13 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2238#discussion_r209626842 --- Diff: artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java --- @@

[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...

2018-08-13 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2238#discussion_r209621351 --- Diff: artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java ---

[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...

2018-08-13 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2238#discussion_r209618198 --- Diff: artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java --- @@

[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...

2018-08-12 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2238#discussion_r209466147 --- Diff: artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java ---

[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...

2018-08-11 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2238#discussion_r209438668 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java --- @@ -885,7 +891,7 @@ public

[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...

2018-08-11 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2238#discussion_r209438598 --- Diff: artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java ---

[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...

2018-08-10 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2238 ARTEMIS-2023 Support 1x prefixes for JMS dests created using session In some cases users who migrate from 1.x to 2.x may still want to keep the legacy prefixes for their JMS