[GitHub] activemq-artemis pull request #2492: ARTEMIS-2222 why the position remains u...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2492


---

[GitHub] activemq-artemis pull request #2492: ARTEMIS-2222 why the position remains u...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2492#discussion_r246538095
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
 ---
@@ -1315,9 +1315,7 @@ private PagedReference moveNext() {
   }
}
 
-   if (!ignored) {
-  position = message.getPosition();
-   }
+   position = message.getPosition();
--- End diff --

I think this made sense at some point, but after a few fixes later it's 
harmless.

I don't think this needs a JIRA as there's no issue I think.

I will merge and keep the JIRA, but I will rename the commit from being a 
question into something more affirmative.


---

[GitHub] activemq-artemis pull request #2492: ARTEMIS-2222 why the position remains u...

[CNNJYB]

GitHub user CNNJYB opened a pull request:

https://github.com/apache/activemq-artemis/pull/2492

ARTEMIS- why the position remains unchanged if ignored is set to true

I am a bit confused about this, When CursorIterator:next is called during 
queue depage, if ignored is set to true, why the position remains unchanged.
  
if (!ignored) {
position = message.getPosition();
}   
For example, the client sends some messages to the topic subscriber ta 
(this topic has two subscribers ta and tb), every time tb depage continuous 
PagePositions that ignored are set to true will be traversed again.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/CNNJYB/activemq-artemis 
dev-CursorIterator-moveNext-ignored

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2492.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2492


commit 49f8bcd99640209c825c22e54a32c872850cc000
Author: andytaylor 
Date:   2018-10-24T10:21:52Z

ARTEMIS-2144 - tx begin failure in ra doesn't get cleaned up

https://issues.apache.org/jira/browse/ARTEMIS-2144

commit 7ae39f7d7218e7c5a93eaecb8f24af3d6186e6f3
Author: yb <17061955@...>
Date:   2019-01-08T09:14:18Z

ARTEMIS- why the position remains unchanged if ignored is set to true




---