Re: [RESULT][VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-17 Thread Jean-Baptiste Onofre
Hi I identified several broken links (including download locations). I’m fixing that. Thanks, Regards JB > Le 17 déc. 2020 à 11:34, Robbie Gemmell a écrit : > > Will there be an announcement mail? The 5.15.13 page also didn't look > to change in the website update commit, so the links will

Re: [RESULT][VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-17 Thread Jean-Baptiste Onofre
Ah 5.15.13, let me fix that (I thought 5.15.14 which should be fine ;) ). I’m fixing that and I will send the announcement email. Regards JB > Le 17 déc. 2020 à 11:34, Robbie Gemmell a écrit : > > Will there be an announcement mail? The 5.15.13 page also didn't look > to change in the website

Re: [RESULT][VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-17 Thread Jean-Baptiste Onofre
Hi Robbie, The website should be up to date. Let me check (I pushed the update couple of days ago). And yes for the announcement email. Regards JB > Le 17 déc. 2020 à 11:34, Robbie Gemmell a écrit : > > Will there be an announcement mail? The 5.15.13 page also didn't look > to change in the

Re: [RESULT][VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-17 Thread Robbie Gemmell
Will there be an announcement mail? The 5.15.13 page also didn't look to change in the website update commit, so the links will remain broken. On Thu, 10 Dec 2020 at 16:53, Robbie Gemmell wrote: > > Are you using an alternative or layered client? The result doesnt > present as the typical output

Re: [RESULT][VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-10 Thread Robbie Gemmell
Are you using an alternative or layered client? The result doesnt present as the typical output of working remotely with repository URLs, instead indicating a pure add rather than referencing the originating commit, and perhaps more notably also doing a simultaneous removal. On Thu, 10 Dec 2020

Re: [RESULT][VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-10 Thread Jean-Baptiste Onofre
I did svn remote, but had "flaky" connection today. It’s now OK. Regards JB > Le 10 déc. 2020 à 15:07, Robbie Gemmell a écrit : > > The commit email and below suggests you are manually adding the files > again and resending them upon check in? Please just do a remote > operation instead, it

Re: [RESULT][VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-10 Thread Robbie Gemmell
The commit email and below suggests you are manually adding the files again and resending them upon check in? Please just do a remote operation instead, it is much less error prone, and far faster too given you dont need to resend the data. Example later. The mail also shows you just removed

Re: [RESULT][VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-10 Thread Jean-Baptiste Onofre
It’s in progress (got some connection issue yesterday evening). Regards JB > Le 10 déc. 2020 à 14:00, Robbie Gemmell a écrit : > > The maven staging repo was promoted and the bits are listed on > central, but the source release / binary conveniences have not been > copied to the dist release

Re: [RESULT][VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-10 Thread Robbie Gemmell
The maven staging repo was promoted and the bits are listed on central, but the source release / binary conveniences have not been copied to the dist release area and so aren't yet started mirroring. On Wed, 9 Dec 2020 at 16:45, Jean-Baptiste Onofre wrote: > > Hi guys, > > This vote passed with

[RESULT][VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-09 Thread Jean-Baptiste Onofre
Hi guys, This vote passed with the following result: +1 (binding): JB Onofré, Dan Kulp, Christopher Shannon +1 (non binding): Jamie Goodyear, François Papon Art started to review and I didn’t see his vote. I’m promoting the artifacts on Maven Central and dist.apache.org

Re: [VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-08 Thread Christopher Shannon
+1 On Mon, Dec 7, 2020 at 5:21 PM Francois Papon wrote: > +1 (non-binding) > > regards, > > François > fpa...@apache.org > > Le 07/12/2020 à 20:29, Matt Pavlovich a écrit : > > +1 > > > > [PASSED] Ran full build with unit tests against the tag/5.15.14 > > [PASSED] Ran internal test suite

Re: [VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-07 Thread Francois Papon
+1 (non-binding) regards, François fpa...@apache.org Le 07/12/2020 à 20:29, Matt Pavlovich a écrit : > +1 > > [PASSED] Ran full build with unit tests against the tag/5.15.14 > [PASSED] Ran internal test suite validating various configurations > > Thanks JB! > >> On Dec 4, 2020, at 6:41 AM,

Re: [VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-07 Thread Matt Pavlovich
+1 [PASSED] Ran full build with unit tests against the tag/5.15.14 [PASSED] Ran internal test suite validating various configurations Thanks JB! > On Dec 4, 2020, at 6:41 AM, Jean-Baptiste Onofre wrote: > > +1 (binding) > > Regards > JB > >> Le 3 déc. 2020 à 06:03, Jean-Baptiste Onofre a

Re: [VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-04 Thread Daniel Kulp
+1 Dan > On Dec 3, 2020, at 12:03 AM, Jean-Baptiste Onofre wrote: > > Hi everyone, > > I submit Apache ActiveMQ 5.15.14 to your vote. This second take includes > fixes on jetty-realm file protocol and new updates. > This release includes CVE related updates and bug fixes. > > Please take a

Re: [VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-04 Thread Arthur Naseef
I have started to run the build after updating the tag. Thank you JB. Art On Fri, Dec 4, 2020 at 1:20 PM Jamie G. wrote: > +1 > > Cheers, > Jamie > > On Fri, Dec 4, 2020 at 9:11 AM Jean-Baptiste Onofre > wrote: > > > > +1 (binding) > > > > Regards > > JB > > > > > Le 3 déc. 2020 à 06:03,

Re: [VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-04 Thread Jamie G.
+1 Cheers, Jamie On Fri, Dec 4, 2020 at 9:11 AM Jean-Baptiste Onofre wrote: > > +1 (binding) > > Regards > JB > > > Le 3 déc. 2020 à 06:03, Jean-Baptiste Onofre a écrit : > > > > Hi everyone, > > > > I submit Apache ActiveMQ 5.15.14 to your vote. This second take includes > > fixes on

Re: [VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-04 Thread Jean-Baptiste Onofre
+1 (binding) Regards JB > Le 3 déc. 2020 à 06:03, Jean-Baptiste Onofre a écrit : > > Hi everyone, > > I submit Apache ActiveMQ 5.15.14 to your vote. This second take includes > fixes on jetty-realm file protocol and new updates. > This release includes CVE related updates and bug fixes. > >

[VOTE] Apache ActiveMQ 5.15.14 release (take #2)

2020-12-02 Thread Jean-Baptiste Onofre
Hi everyone, I submit Apache ActiveMQ 5.15.14 to your vote. This second take includes fixes on jetty-realm file protocol and new updates. This release includes CVE related updates and bug fixes. Please take a look on the Release Notes for details:

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-02 Thread Arthur Naseef
Oh nice. I missed this earlier. Thanks! Art On Wed, Dec 2, 2020 at 2:09 AM Jean-Baptiste Onofre wrote: > FYI, I fixed the issues (very quick fix) the InMemory test. > > Regards > JB > > > Le 2 déc. 2020 à 05:54, Jean-Baptiste Onofre a écrit : > > > > Hi Art, > > > > Thanks for the update !

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-02 Thread Arthur Naseef
Makes sense. Glad to hear the tests are run even if we have a few that fail consistently. When I did a few official AMQ builds, I learned to use "mvn -fn" to run through the entire build, then go back and re-run the tests that failed. At that time, running the tests more than once usually got

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-02 Thread Jean-Baptiste Onofre
FYI, I fixed the issues (very quick fix) the InMemory test. Regards JB > Le 2 déc. 2020 à 05:54, Jean-Baptiste Onofre a écrit : > > Hi Art, > > Thanks for the update ! > > Yeah, those tests are some of I would like to fix (they fail for quite long > now, since at least 5.15.9). > > I think

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-01 Thread Jean-Baptiste Onofre
Hi Art, Thanks for the update ! Yeah, those tests are some of I would like to fix (they fail for quite long now, since at least 5.15.9). I think some tests should be removed because they don’t make sense anymore. I will take a look (I’m also improving the Karaf tests which are flaky). By the

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-01 Thread Arthur Naseef
So the ClassCastException happens in 5.15.13 and 5.15.10 when I run that test specifically. I suspect we have a case where the test class inheritance is causing confusion. If so, then the fix here is to bypass the base-class test method. Can someone look at the test method

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-01 Thread Arthur Naseef
Looks like I'm finding 2 problems with the InMemeoryJmsSchedulerTest: 1. The ClassCastException in one test, and 2. "Didn't receive the message" problem in the other. Digging into the ClassCastException, all the code appears to be unchanged for at least 6 months. Could this have been

Re: [CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-12-01 Thread Arthur Naseef
So it looks like my build only had 2 test failures. The first we discussed already. The second is as follows: [INFO] Running org.apache.activemq.broker.scheduler.memory.InMemeoryJmsSchedulerTest [ERROR] Tests run: 8, Failures: 1, Errors: 1, Skipped: 0, Time elapsed: 41.993 s <<< FAILURE! - in

[CANCEL][VOTE] Apache ActiveMQ 5.15.14 release

2020-11-30 Thread Jean-Baptiste Onofre
Hi everyone, Due to an issue with the fix for AMQ-8045, I cancel this vote to prepare a new one. Sorry about that. And thanks Art to find this. A new vote will start today. Regards JB > Le 24 nov. 2020 à 08:00, Jean-Baptiste Onofre a écrit : > > Hi everyone, > > I submit Apache ActiveMQ

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-30 Thread Arthur Naseef
Ahh, thanks for letting me know. I'll wait for the fix on that one and look at the other tests. Art On Mon, Nov 30, 2020 at 10:11 PM Jean-Baptiste Onofre wrote: > Hi Arthur, > > That’s a real issue due a change introduce in the default jetty.xml to > load the jetty-realm. > > My bad, I will

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-30 Thread Jean-Baptiste Onofre
Hi Arthur, That’s a real issue due a change introduce in the default jetty.xml to load the jetty-realm. My bad, I will fix that. Thanks ! Regards JB > Le 1 déc. 2020 à 05:00, Arthur Naseef a écrit : > > I'm running the build on an Ubuntu system and getting 4 test failures. I > retried 1

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-30 Thread Arthur Naseef
I'm running the build on an Ubuntu system and getting 4 test failures. I retried 1 and it repeated. I'll look at the failures more tomorrow. Here are the errors from the test I retried: [ERROR]

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-30 Thread Christopher Shannon
+1, -verified checksum and gpg signature -ran a build and ran through smoke tests -ran broker from release to verify it starts On Fri, Nov 27, 2020 at 8:43 PM Robbie Gemmell wrote: > The issues I was noting were with the staged dist repo contents rather > than the maven repo. There is a helper

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-27 Thread Robbie Gemmell
The issues I was noting were with the staged dist repo contents rather than the maven repo. There is a helper script for prepping the dist area contents inc verifying the gpg sig at https://dist.apache.org/repos/dist/dev/activemq/activemq/ On Fri, 27 Nov 2020 at 17:43, Matt Pavlovich wrote: > >

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-27 Thread Robbie Gemmell
Yep, looks better now. On Fri, 27 Nov 2020 at 16:29, Jean-Baptiste Onofre wrote: > > NB: upload is still on the way, it should be OK in 10mn or so. > > > Le 27 nov. 2020 à 16:56, Robbie Gemmell a écrit : > > > > The issues I noted (.md5 present, -bin files missing) dont appear to > > be fixed

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-27 Thread Matt Pavlovich
Robbie- Here is a release validation script: https://github.com/apache/activemq/pull/587 You can pass an arg to change the Maven repo. Currently it validates: 1. Download tar.gz and zip files 2. Validates SHA1 and MD5 3. Extracts the zip and

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-27 Thread Jean-Baptiste Onofre
NB: upload is still on the way, it should be OK in 10mn or so. > Le 27 nov. 2020 à 16:56, Robbie Gemmell a écrit : > > The issues I noted (.md5 present, -bin files missing) dont appear to > be fixed for 5.15.14 yet? Still showing via the dist area HTTP view > and svn directly for me at least. >

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-27 Thread Jean-Baptiste Onofre
No problem at all ! And thanks for your feedback. It helps ! I will keep on fixing flaky tests ;) Regards JB > Le 27 nov. 2020 à 17:08, Matt Pavlovich a écrit : > > JB- > > Thanks for all your efforts. In no way was my response intended to be > critical— the hope was to be informative if

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-27 Thread Jean-Baptiste Onofre
My bad, I forgot svn commit ;) It should be OK now. I will check the prepare-release.sh (for the empty sha512 file). Regards JB > Le 27 nov. 2020 à 16:56, Robbie Gemmell a écrit : > > The issues I noted (.md5 present, -bin files missing) dont appear to > be fixed for 5.15.14 yet? Still

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-27 Thread Matt Pavlovich
JB- Thanks for all your efforts. In no way was my response intended to be critical— the hope was to be informative if others were seeing the same. The fact that you have the code base down to *only* 7 failing tests is remarkable! I should have indicated that in my note =). -Matt > On Nov

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-27 Thread Robbie Gemmell
The issues I noted (.md5 present, -bin files missing) dont appear to be fixed for 5.15.14 yet? Still showing via the dist area HTTP view and svn directly for me at least. On Fri, 27 Nov 2020 at 15:21, Jean-Baptiste Onofre wrote: > > It’s already fixed for the 5.15.14 release and I will push the

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-27 Thread Jean-Baptiste Onofre
It’s already fixed for the 5.15.14 release and I will push the fix on the script. Regards JB > Le 27 nov. 2020 à 16:10, Robbie Gemmell a écrit : > > I would fix the dist problems before starting another release > personally, so that any new voters can properly inspect things. > > Aside, I

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-27 Thread Robbie Gemmell
I would fix the dist problems before starting another release personally, so that any new voters can properly inspect things. Aside, I since saw that you only added the .md5 this morning along with the .sha512 contents. I'm not sure how so many people managed to vote for it without verifying the

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-27 Thread Jean-Baptiste Onofre
Yeah I know ;) Not a problem. We can wait ! I will move forward on 5.16.1 in the meantime. Thanks ! Regards JB > Le 27 nov. 2020 à 12:48, Robbie Gemmell a écrit : > > Many of the people you are looking to remind are likely not around to > see it, being on vacation either for or just around

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-27 Thread Robbie Gemmell
Many of the people you are looking to remind are likely not around to see it, being on vacation either for or just around the US Thanksgiving. It's probably the second worst point of the year to have a release vote open unfortunately. I'd note that the binary archives are missing from the dist

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-26 Thread Jean-Baptiste Onofre
Gently reminder about this vote. Thanks ! Regards JB > Le 24 nov. 2020 à 08:00, Jean-Baptiste Onofre a écrit : > > Hi everyone, > > I submit Apache ActiveMQ 5.15.14 to your vote. > This release includes CVE related updates and bug fixes. > > Please take a look on the Release Notes for

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-26 Thread Fraser
+1 Regards, FC On Tue, 24 Nov 2020 at 07:00, Jean-Baptiste Onofre wrote: > Hi everyone, > > I submit Apache ActiveMQ 5.15.14 to your vote. > This release includes CVE related updates and bug fixes. > > Please take a look on the Release Notes for details: > >

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-26 Thread Jean-Baptiste Onofre
+1 (binding) Regards JB > Le 24 nov. 2020 à 08:00, Jean-Baptiste Onofre a écrit : > > Hi everyone, > > I submit Apache ActiveMQ 5.15.14 to your vote. > This release includes CVE related updates and bug fixes. > > Please take a look on the Release Notes for details: >

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-25 Thread Jean-Baptiste Onofre
Thanks for the feedback Matt. We have lot of flacky tests. I fixed some but others are still there. I will keep on fixing ;) > Le 25 nov. 2020 à 19:16, Matt Pavlovich a écrit : > > +1 > > Full build and unit tests executed on CentOS using JDK 1.8u221 > > 7 unit test failures: > >

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-25 Thread Matt Pavlovich
+1 Full build and unit tests executed on CentOS using JDK 1.8u221 7 unit test failures: org.apache.activemq.broker.scheduler.memory.InMemeoryJmsSchedulerTest.testScheduleFullRecoveryRestart

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-24 Thread Francois Papon
+1 (non-binding) Thanks JB! regards, François fpa...@apache.org Le 24/11/2020 à 08:00, Jean-Baptiste Onofre a écrit : > Hi everyone, > > I submit Apache ActiveMQ 5.15.14 to your vote. > This release includes CVE related updates and bug fixes. > > Please take a look on the Release Notes for

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-24 Thread Daniel Kulp
+1 Dan > On Nov 24, 2020, at 2:00 AM, Jean-Baptiste Onofre wrote: > > Hi everyone, > > I submit Apache ActiveMQ 5.15.14 to your vote. > This release includes CVE related updates and bug fixes. > > Please take a look on the Release Notes for details: >

Re: [VOTE] Apache ActiveMQ 5.15.14 release

2020-11-24 Thread Jamie G.
+1 Cheers, Jamie On Tue, Nov 24, 2020 at 3:30 AM Jean-Baptiste Onofre wrote: > > Hi everyone, > > I submit Apache ActiveMQ 5.15.14 to your vote. > This release includes CVE related updates and bug fixes. > > Please take a look on the Release Notes for details: >

[VOTE] Apache ActiveMQ 5.15.14 release

2020-11-23 Thread Jean-Baptiste Onofre
Hi everyone, I submit Apache ActiveMQ 5.15.14 to your vote. This release includes CVE related updates and bug fixes. Please take a look on the Release Notes for details: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210=12348294