Re: [DISCUSS] consolidate dag scheduling params

2022-08-06 Thread Jarek Potiuk
Yep. I think immediate deprecation is the way to go. Those who care will change. For those who don't care - well, they don't care so it doesn't matter. On Sat, Aug 6, 2022 at 9:10 PM Daniel Standish wrote: > It's not addressed explicitly in the vote. Personally I think we should > add a

Re: [DISCUSS] consolidate dag scheduling params

2022-08-06 Thread Daniel Standish
It's not addressed explicitly in the vote. Personally I think we should add a deprecation warning immediately. I understand that there is the thought to "give users time to make the change" before adding the warning. But deprecation warnings are probably the most effective, most relied upon

Re: [DISCUSS] consolidate dag scheduling params

2022-08-06 Thread Ash Berlin-Taylor
One question: are we deprecating the existing parameters straight away or leaving it without a warning for one release? (I think someone talked about that at one point) On 6 August 2022 19:46:02 BST, Daniel Standish wrote: >Well, thanks for forcing us to make the case :) > >I'll initiate a

[LAZY CONSENSUS] consolidate scheduling params with new param `schedule`

2022-08-06 Thread Daniel Standish
Proposal: - add new DAG param `schedule` that accepts everything *currently *supported by `schedule_interval`, `timetable`, and `schedule_on` - (note schedule_on, added for AIP-48, has not been in any release yet; only present in main) - remove param schedule_on immediately

Re: [DISCUSS] consolidate dag scheduling params

2022-08-06 Thread Daniel Standish
Well, thanks for forcing us to make the case :) I'll initiate a lazy consensus "vote" On Fri, Aug 5, 2022 at 1:01 PM Vikram Koka wrote: > Fair points all. > I withdraw my objection and agree with the consolidation proposal. > > Vikram > > > On Fri, Aug 5, 2022 at 10:06 AM Jarek Potiuk wrote:

Re: Wiki access please?

2022-08-06 Thread Jarek Potiuk
What do you think, Pablo about the "being out" vs. "being in" the official repo? On Thu, Jul 28, 2022 at 3:51 PM Jarek Potiuk wrote: > Anyone :) ? > > On Mon, Jul 18, 2022 at 10:38 AM Jarek Potiuk wrote: > >> I would love to hear what others think about the "in/out" approach - mine >> is just

Re: [DISCUSS] Trimming down Airlfow Versions in issues

2022-08-06 Thread Jarek Potiuk
Crearted PR here: https://github.com/apache/airflow/pull/25564 On Sat, Aug 6, 2022 at 9:26 AM Jarek Potiuk wrote: > Free text field seems better for those. But we should make it required :) > > On Sat, Aug 6, 2022 at 1:40 AM Jed Cunningham > wrote: > >> So far we've been talking about Airflow

Re: [DISCUSS] Move all airflow infra hooks from settings.py to its own file

2022-08-06 Thread Jarek Potiuk
Yeah. I feel like having one place where you can add custom code is better, especially that there are a number of conf settings that you can also add your custom code (think hostname_callable) so having one "dedicated" module at least as an entrypoint sounds reasonable and yeah - you can import

Re: [DISCUSS] Trimming down Airlfow Versions in issues

2022-08-06 Thread Jarek Potiuk
Free text field seems better for those. But we should make it required :) On Sat, Aug 6, 2022 at 1:40 AM Jed Cunningham wrote: > So far we've been talking about Airflow core bugs, but we do have 2 other > issue templates that ask for the Airflow version - chart and providers. > > Both of those

Re: [DISCUSS] Move all airflow infra hooks from settings.py to its own file

2022-08-06 Thread Ash Berlin-Taylor
I think for 99% of users this file is empty or tiny, so it works well as it is for most of our users. If you want to reorganize the file you can use python imports ``` from mymodule import task_policy ``` On 6 August 2022 01:13:14 BST, Ping Zhang wrote: >Hi all, > >Currently, those infra