Re: [DISCUSS] AIP-52 updates - setup / teardown tasks

2023-03-27 Thread Daniel Standish
Happy to see the engagement on this one. Thanks to everyone for thinking it through and contributing their thoughts. re niko > - Context managers: > I found most of the context manager syntax proposals a little hard to > understand, but some better than others. Ultimately if I put my DAG

Re: [VOTE] Release Airflow 2.5.3 from 2.5.3rc1

2023-03-27 Thread Jarek Potiuk
I just corrected the milestone in 29112 to 2.6.0 the milestone was moved to 2.6 when we decided not to cherry-pick that one and moved it to 2.6.0 (task long handler in main branch is vastly different than the one in 2.5 after Daniel's change so this one does not cleanly cherry-pick and we

RE: [VOTE] Release Airflow 2.5.3 from 2.5.3rc1

2023-03-27 Thread Scheffler Jens (XC-DX/ETV5)
Hi Pirerre, Thanks for cutting the release, from Release Notes and PR https://github.com/apache/airflow/pull/30123 notes it is not clear for me - is the bugfix from PR30123 included? >From "Milestone" log it seems so but Release Notes do not mention bug 29112 Mit freundlichen Grüßen / Best

Re: [DISCUSS] AIP-52 updates - setup / teardown tasks

2023-03-27 Thread Jarek Potiuk
I think teardown should always happen no matter the short cricuit. Short circuit IMHO should be updated so that it should not be able to skip teardown. Also I think Dennis later point about preserving the output / intermediate resources is sometimes important, but this is a debugging technique

Re: [DISCUSS] AIP-52 updates - setup / teardown tasks

2023-03-27 Thread Ferruzzi, Dennis
> If the set-up ran then the short circuit shouldn't be able to skip it >> I think this is overly and unnecessarily opinionated and limiting. I would not be concerned with having the default be one way or another, but to say that "you should not be able to skip it", I disagree with the notion

Re: [DISCUSS] AIP-52 updates - setup / teardown tasks

2023-03-27 Thread Ferruzzi, Dennis
Feel free to ignore my last message, sorry about that. I just came back from a vacation and it's Monday and I didn't realize I was missing an entire thread of discussion there. Outlook does not handle the mailinglist message threading at all. Apologies, it's not my intention to fork the

[VOTE] Release Airflow 2.5.3 from 2.5.3rc1

2023-03-27 Thread Pierre Jeambrun
Hey fellow Airflowers, I have cut Airflow 2.5.3rc1. This email is calling a vote on the release, which will last at least 72 hours, from Monday, March 27, 2023 at 7:50 pm UTC until Thursday, March 30, 2023 at 7:50 pm UTC, and until 3 binding +1 votes have been received. Status of testing of the

Re: [DISCUSS] AIP-52 updates - setup / teardown tasks

2023-03-27 Thread Oliveira, Niko
Chiming in on a few of the topics discussed so far: - Context managers: I found most of the context manager syntax proposals a little hard to understand, but some better than others. Ultimately if I put my DAG author hat on, I find this declaration the most straightforward, clear and it's easy

Re: [DISCUSS] AIP-52 updates - setup / teardown tasks

2023-03-27 Thread Ferruzzi, Dennis
I really like the idea of this AIP and I'm looking forward to seeing how you implement it. I know you've put lots of effort into it, and I'm not looking to derail your plans. It may be entirely too late at this point, but if you are doing a rework, how would you feel about the idea of the

Re: [DISCUSS] AIP-55 Rule-based timetable with logical composition

2023-03-27 Thread Oliveira, Niko
I love this idea, it's definitely helpful! I think an interesting topic to discuss for this project would be some kind of UI based date/calendar picker to help users construct these logical compositions. Something like `days("D1", "D2", "THU-SAT", "4>", "L1")` is quite inscrutable. A UI

Re: [DISCUSS] a cache for Airflow Variables

2023-03-27 Thread Vandon, Raphael
My initial goal when working on this cache was mostly to shorten DAG parsing times, simply because that's what I was looking at, so I'd be happy with restricting this cache to dag parsing. I'm still relatively new to airflow codebase, so I don't know all the implications this change has, so I'm

Re: [DISCUSS] AIP-52 updates - setup / teardown tasks

2023-03-27 Thread Daniel Standish
> > 1) I am not sure if we should make it private (I am not even sure what > it would mean to be private:) ). But If it means that setting the rule > type for non-teardown task should raise an error (and of course > documenting this rule as only (and automatically) being applied to > teardown task

Re: Updating Provider dependencies for development.

2023-03-27 Thread Kristopher Kane
Awesome thanks. I must have coincidentally done it with Breeze since I did see the generated providers updated but I must have never gone back to run the pip install. I have a working environment now to run with. Kris On Fri, Mar 24, 2023 at 1:48 PM Jarek Potiuk wrote: > > The

Re: [DISCUSS] AIP-52 updates - setup / teardown tasks

2023-03-27 Thread Jarek Potiuk
My view: 1) I am not sure if we should make it private (I am not even sure what it would mean to be private:) ). But If it means that setting the rule type for non-teardown task should raise an error (and of course documenting this rule as only (and automatically) being applied to teardown task -

[DISCUSS] Exclude some providers that hold us back from releasing

2023-03-27 Thread Jarek Potiuk
Hello Everyone, TL;DR; I wanted to raise a discussion and make a proposal about option to skip some niche providers of our from releasing if they are holding us back, regarding the dependencies We are going through some troubles with dependencies of our providers - mostly around some outdated

Re: [DISCUSS] AIP-52 updates - setup / teardown tasks

2023-03-27 Thread Ash Berlin-Taylor
If the set-up ran then the tear down _must_ run. No question. Nothing should be able to change this fact. If you can, then they don't fulfill the stated purpose of tear down tasks in the AIP: to tidy up resources created by a set up task. On 27 March 2023 06:22:47 BST, Daniel Standish