Re: [PROPOSAL] Deprecate URI Connection representation in favor of JSON

2023-11-18 Thread Andrey Anshin
Hey guys! Thanks for all your feedback and suggestions. I see here couple of examples with postgresql, however I would like to remind that postgresql it is not a valid connection type which doesn't register into the providers manager, and we have an exclusive hack to turn this connection type

Re: [DISCUSS] Move FAB auth manager to a new provider

2023-11-18 Thread utkarsh sharma
+1 to moving it to providers, since it gives more flexibility. Thanks, Utkarsh Sharma On Fri, Nov 17, 2023 at 5:50 PM Jarek Potiuk wrote: > Ah ... put it in a wrong thread, sorry :) ... > > On Fri, Nov 17, 2023 at 12:39 PM Jarek Potiuk wrote: > > > OK. Seeing that - I think I will do the next

Re: [PROPOSAL] Deprecate URI Connection representation in favor of JSON

2023-11-18 Thread utkarsh sharma
I do think the URI format for airflow connections also serves the purpose of conveying the intent, similar to how we URI in a browser to connect to a website. We use Ariflow Connection URI to connect to one of the services supported by Airflow. Due to this reason, I lean toward Jarek's proposal of

Re: [PROPOSAL] Deprecate URI Connection representation in favor of JSON

2023-11-18 Thread cary hawkins
I would also be a -1 for deprecating URI connection representation, this is one of the defacto standards across Python. I do agree with the suggestion from Jarek that it could be less confusing if it follows SQLAlchemy style formatting. That is a known format that users are likely going to be

Re: [PROPOSAL] Deprecate URI Connection representation in favor of JSON

2023-11-18 Thread Bolke de Bruin
So -1 on deprecating. I think we should do the opposite and go all in. The suggestion by Jarek makes sense in this case, as it remains and is fully standards compliant. The JSON representation isn't: it is our own crafted format. My 2 cents, Bolke On Sat, 18 Nov 2023 at 22:15, Jarek Potiuk

Re: [PROPOSAL] Deprecate URI Connection representation in favor of JSON

2023-11-18 Thread Jarek Potiuk
I agree with Ash that it's much easier to define a lot of simpler connections this way. But it is also very confusing the way now how you can mix the "real" url with "airflow connection" URL. And Daniel is very right about the magnitude of breaking change. But possibly there is a way to eat

Re: [PROPOSAL] Deprecate URI Connection representation in favor of JSON

2023-11-18 Thread Daniel Standish
The thing that makes *me* hesitant to deprecate is the sheer magnitude of breaking it would bring (even though we're only talking about a hypothetical 3.0 release), balanced against the actual pain it causes. I.e. it's confusing to use, and takes up space in docs (when, if removed, we could just

Re: [DISCUSS] Airflow UI DAG Composer

2023-11-18 Thread Ash Berlin-Taylor
If your company doesn’t allow the doc to be public please create it on a personal account. We can’t comment I agree with what Jarek said though, and also: Why does this need to be _in_ core Airflow at all? Given that it is possible to extend the Webserver via plugins, what in your proposal

Re: [PROPOSAL] Deprecate URI Connection representation in favor of JSON

2023-11-18 Thread Ash Berlin-Taylor
-1 — for the simple case the URI format is perfect: AIRFLOW_CONN_MY_DB=postgresql://user:pass@host We can push JSON format for more complex cases, and/or limit URI to only the simple cases as long as we don’t remove it entirely. -ash > On 17 Nov 2023, at 22:44, Andrey Anshin wrote: > >