Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Vikram Koka
Awesome! Congratulations Wei! Very well deserved. A tremendous amount of contributions in a relatively short time! On Mon, Apr 8, 2024 at 2:27 PM Oliveira, Niko wrote: > Congrats Wei! Well deserved :) > > > From: Scheffler Jens (XC-AS/EAE-ADA-T) .INVALID> >

Re: [DISCUSS] Proposal for adding Telemetry via Scarf

2024-04-08 Thread Hussein Awala
> Other than that I don't mind it being e.g. optional provider. I don't think it is possible to implement it in a provider because it is a js package installed on the webserver; we could implement it as a plugin (Blueprint), but in this case, the user must make an effort to register it. It would

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Oliveira, Niko
Congrats Wei! Well deserved :) From: Scheffler Jens (XC-AS/EAE-ADA-T) Sent: Monday, April 8, 2024 2:12:41 PM To: dev@airflow.apache.org Subject: RE: [EXTERNAL] [COURRIEL EXTERNE] [ANNOUNCE] New committer: Wei Lee CAUTION: This email originated from outside of

RE: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Scheffler Jens (XC-AS/EAE-ADA-T)
Welcome to the "club" @ash Haha in the name a copy error from previous welcome  welcome WEI 拾 Mit freundlichen Grüßen / Best regards Jens Scheffler Alliance: Enabler - Tech Lead (XC-AS/EAE-ADA-T) Robert Bosch GmbH | Hessbruehlstraße 21 | 70565 Stuttgart-Vaihingen | GERMANY | www.bosch.com

Re: [DISCUSS] Asynchronous SQLAlchemy

2024-04-08 Thread Andrey Anshin
If I do not miss something, usage of DB is not covered by Airflow Public Interface, in this case we could easily replace one-by-one sync methods by async. There is some places exists where it might be mixin, as mentioned before Secrets Backend, but it could be done by wrapping it into the: -

Re: [DISCUSS] Asynchronous SQLAlchemy

2024-04-08 Thread Hussein Awala
> Yeah do we have concrete examples of places where asyncio would be a non-starter? Are there enough of these examples to kill this idea? I really don't like the idea of needing to maintain both sync and async. I had the SQL queries in mind, where the sync driver would return the result and the

Re: [DISCUSS] Asynchronous SQLAlchemy

2024-04-08 Thread Daniel Imberman
Yeah do we have concrete examples of places where asyncio would be a non-starter? Are there enough of these examples to kill this idea? I really don't like the idea of needing to maintain both sync and async. On Mon, Apr 8, 2024 at 1:39 PM Hussein Awala wrote: > > we definitely need a way to

Re: [DISCUSS] Asynchronous SQLAlchemy

2024-04-08 Thread Hussein Awala
> we definitely need a way to opt-out for the ones who aren't interested I disagree, what I propose is to infer the async connection from the sync configuration using a translation method, with the possibility of providing the async connection configuration explicitly. This will help to

Re: [DISCUSS] Asynchronous SQLAlchemy

2024-04-08 Thread Daniel Imberman
Agreed with Daniel and Ash, I'm a big +1 for "all", I also think there is work we can also do to make some of the executor work async (particularly around the KubernetesExecutor which is slowed down by calls to the k8s API) On Mon, Apr 8, 2024 at 1:08 PM Daniel Standish wrote: > If nothing

Re: [DISCUSS] Asynchronous SQLAlchemy

2024-04-08 Thread Daniel Standish
https://github.com/omnilib/aiosqlite maybe? On Mon, Apr 8, 2024 at 1:03 PM Scheffler Jens (XC-AS/EAE-ADA-T) wrote: > I understand the „all-in“ approach as we were dropping MSSQL… how can we > keep one codenase bit cooe with sqlite? I assume we must support this at > least for dev setups. > >

Re: [DISCUSS] Asynchronous SQLAlchemy

2024-04-08 Thread Daniel Standish
If nothing else, write an ugly adapter using sync_to_async? On Mon, Apr 8, 2024 at 1:06 PM Daniel Standish < daniel.stand...@astronomer.io> wrote: > https://github.com/omnilib/aiosqlite maybe? > > On Mon, Apr 8, 2024 at 1:03 PM Scheffler Jens (XC-AS/EAE-ADA-T) > wrote: > >> I understand the

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Ferruzzi, Dennis
Congrats, and welcome! - ferruzzi From: Tomasz Urbaszek Sent: Monday, April 8, 2024 12:42 PM To: dev@airflow.apache.org Subject: RE: [EXTERNAL] [COURRIEL EXTERNE] [ANNOUNCE] New committer: Wei Lee CAUTION: This email originated from outside of the

Re: [DISCUSS] Asynchronous SQLAlchemy

2024-04-08 Thread Scheffler Jens (XC-AS/EAE-ADA-T)
I understand the „all-in“ approach as we were dropping MSSQL… how can we keep one codenase bit cooe with sqlite? I assume we must support this at least for dev setups. Sent from Outlook for iOS From: Jarek Potiuk Sent: Monday, April 8,

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Tomasz Urbaszek
Congrats! On Mon, 8 Apr 2024 at 19:56, Ankit Chaurasia wrote: > Congratulations Wei > > *Ankit Chaurasia* > HomePage | LinkedIn > > > > > > > > On Mon, 8 Apr 2024 at 23:38, Pierre Jeambrun > wrote: > > > Congratulations!

Re: [DISCUSS] DRAFT AIP-67 Multi-tenant deployment of Airflow components

2024-04-08 Thread Jarek Potiuk
Hello here. I applied a number of comments mostly from TP, Ash, Daniel who were concerned about the scope of the AIP (including the DB changes) but Also Shubham, Nikolas and others. The small (but most visible) change where "multi-tenant" might promise too much. I also talked to at least a few

Re: [DISCUSS] Asynchronous SQLAlchemy

2024-04-08 Thread Jarek Potiuk
Yep. If we can make both Postgres and MySQL work with Async - I am also all for the "All" approach. If it means that we need to support only certain drivers and certain versions of the DBs - so be it. As mentioned in my original comments (long time ago when we had MSSQL support) - this was not

Re: [DISCUSS] Asynchronous SQLAlchemy

2024-04-08 Thread Daniel Standish
I wholeheartedly agree with Ash that it should be all or nothing. And *all* sounds better to me :) On Mon, Apr 8, 2024 at 10:54 AM Ash Berlin-Taylor wrote: > I’m all in favour of async SQLAlchemy. We’ve built two products > exclusively at @ Astronomer that use sqlalchemy+psycopg3+async and

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Ankit Chaurasia
Congratulations Wei *Ankit Chaurasia* HomePage | LinkedIn On Mon, 8 Apr 2024 at 23:38, Pierre Jeambrun wrote: > Congratulations! > > Le lun. 8 avr. 2024 à 16:49, Wei Lee a écrit : > > > Thanks for all your support 

Re: [DISCUSS] Asynchronous SQLAlchemy

2024-04-08 Thread Ash Berlin-Taylor
I’m all in favour of async SQLAlchemy. We’ve built two products exclusively at @ Astronomer that use sqlalchemy+psycopg3+async and love it. Async does take a bit of a learning curve, but SQLA has done it nicely and it works really well. I think this needs to be an all or nothing thing — having

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Pierre Jeambrun
Congratulations! Le lun. 8 avr. 2024 à 16:49, Wei Lee a écrit : > Thanks for all your support  Can’t be more excited 朗 > > Best, > Wei > > > On Apr 8, 2024, at 9:15 PM, Vincent Beck wrote: > > > > Congrats Wei! Well deserved! > > > > On 2024/04/08 13:03:50 Hemkumar Chheda wrote: > >>

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Wei Lee
Thanks for all your support  Can’t be more excited 朗 Best, Wei > On Apr 8, 2024, at 9:15 PM, Vincent Beck wrote: > > Congrats Wei! Well deserved! > > On 2024/04/08 13:03:50 Hemkumar Chheda wrote: >> Congratulations Wei! Best news ever 朗拾 >> >>> On 8 Apr 2024, at 6:10 PM, Bishundeo,

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Vincent Beck
Congrats Wei! Well deserved! On 2024/04/08 13:03:50 Hemkumar Chheda wrote: > Congratulations Wei! Best news ever 朗拾 > > > On 8 Apr 2024, at 6:10 PM, Bishundeo, Rajeshwar > > wrote: > > > > Congratulations Wei!! Good job and well deserved!! > > > > -- Rajesh > > > > > > > > > > > > > >

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Hemkumar Chheda
Congratulations Wei! Best news ever 朗拾 > On 8 Apr 2024, at 6:10 PM, Bishundeo, Rajeshwar > wrote: > > Congratulations Wei!! Good job and well deserved!! > > -- Rajesh > > > > > > > On 2024-04-08, 8:36 AM, "Abhishek Bhakat" > LID> wrote: >

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Bishundeo, Rajeshwar
Congratulations Wei!! Good job and well deserved!! -- Rajesh On 2024-04-08, 8:36 AM, "Abhishek Bhakat" mailto:abhishek.bha...@astronomer.io.inva>LID> wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Abhishek Bhakat
Yay! Congrats Wei! On Mon, Apr 8, 2024 at 11:36 AM Aritra Basu wrote: > Congrats wei! Great job! > > -- > Regards, > Aritra Basu > > On Mon, Apr 8, 2024, 4:17 PM wrote: > > > Congrats Wei! > > > > > On Apr 8, 2024, at 5:31 AM, Pankaj Singh > > wrote: > > > > > > Congrats Wei, very well

[ANNOUNCE] Apache Airflow 2.9.0 Released

2024-04-08 Thread Ephraim Anierobi
Dear Airflow community, I'm happy to announce that Airflow 2.9.0 was just released. The released sources and packages can be downloaded via https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-sources.html Other installation methods are described in

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Aritra Basu
Congrats wei! Great job! -- Regards, Aritra Basu On Mon, Apr 8, 2024, 4:17 PM wrote: > Congrats Wei! > > > On Apr 8, 2024, at 5:31 AM, Pankaj Singh > wrote: > > > > Congrats Wei, very well deserved! > > > >> On Mon, Apr 8, 2024 at 2:33 PM Rahul Vats > wrote: > >> > >> Congrats Wei, very

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread constance
Congrats Wei! > On Apr 8, 2024, at 5:31 AM, Pankaj Singh wrote: > > Congrats Wei, very well deserved! > >> On Mon, Apr 8, 2024 at 2:33 PM Rahul Vats wrote: >> >> Congrats Wei, very well deserved! >> >> Regards, >> Rahul Vats >> >> >>> On Mon, 8 Apr 2024 at 14:27, Amogh Desai wrote: >>>

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Pankaj Singh
Congrats Wei, very well deserved! On Mon, Apr 8, 2024 at 2:33 PM Rahul Vats wrote: > Congrats Wei, very well deserved! > > Regards, > Rahul Vats > > > On Mon, 8 Apr 2024 at 14:27, Amogh Desai wrote: > > > Many congratulations, Wei! > > > > Welcome onboard! > > > > Thanks & Regards, > > Amogh

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Phani Kumar
Congratulations Wei , very well deserved ! On Mon, Apr 8, 2024 at 2:28 PM Amogh Desai wrote: > Many congratulations, Wei! > > Welcome onboard! > > Thanks & Regards, > Amogh Desai > > > On Mon, 8 Apr 2024 at 2:26 PM, Jarek Potiuk wrote: > > > Congrats Wei! Indeed, well deserved! > > > > On Mon,

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Rahul Vats
Congrats Wei, very well deserved! Regards, Rahul Vats On Mon, 8 Apr 2024 at 14:27, Amogh Desai wrote: > Many congratulations, Wei! > > Welcome onboard! > > Thanks & Regards, > Amogh Desai > > > On Mon, 8 Apr 2024 at 2:26 PM, Jarek Potiuk wrote: > > > Congrats Wei! Indeed, well deserved! > >

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Amogh Desai
Many congratulations, Wei! Welcome onboard! Thanks & Regards, Amogh Desai On Mon, 8 Apr 2024 at 2:26 PM, Jarek Potiuk wrote: > Congrats Wei! Indeed, well deserved! > > On Mon, Apr 8, 2024 at 10:54 AM Hussein Awala wrote: > > > Congrats Wei, well deserved! > > > > On Monday, April 8, 2024,

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Jarek Potiuk
Congrats Wei! Indeed, well deserved! On Mon, Apr 8, 2024 at 10:54 AM Hussein Awala wrote: > Congrats Wei, well deserved! > > On Monday, April 8, 2024, Ash Berlin-Taylor wrote: > > > The Project Management Committee (PMC) for Apache Airflow has invited Wei > > Lee to become a committer and > >

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Hussein Awala
Congrats Wei, well deserved! On Monday, April 8, 2024, Ash Berlin-Taylor wrote: > The Project Management Committee (PMC) for Apache Airflow has invited Wei > Lee to become a committer and > we are pleased to announce that they have accepted. > > Wei has been contributing for a number of months

Re: [ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Pankaj Koti
Many congratulations, Wei 拾 Very well done and well deserved!! On Mon, 8 Apr 2024, 14:19 Ash Berlin-Taylor, wrote: > The Project Management Committee (PMC) for Apache Airflow has invited Wei > Lee to become a committer and > we are pleased to announce that they have accepted. > > Wei has

[ANNOUNCE] New committer: Wei Lee

2024-04-08 Thread Ash Berlin-Taylor
The Project Management Committee (PMC) for Apache Airflow has invited Wei Lee to become a committer and we are pleased to announce that they have accepted. Wei has been contributing for a number of months he also participated a lot in discussions and decisions on many aspects of Airflow but

[RESULT][VOTE] Release Airflow 2.9.0 from 2.9.0rc3

2024-04-08 Thread Ephraim Anierobi
Hello, Apache Airflow 2.9.0 (based on RC3) has been accepted. 4 "+1" binding votes received: - Jarek Potiuk - Jed Cunningham - Elad Kalif - Ephraim Anierobi 4 "+1" non-binding votes received: - Scheffler Jens - Amogh Desai - Rahul Vats - Phani Kumar Vote thread:

Re: [VOTE] Release Airflow 2.9.0 from 2.9.0rc3

2024-04-08 Thread Elad Kalif
+1 (binding) tested some of my dags. everything works as expected On Mon, Apr 8, 2024 at 7:55 AM Phani Kumar wrote: > +1 non binding.Verified by running few example DAGs > > On Mon, Apr 8, 2024 at 10:17 AM Rahul Vats wrote: > > > +1 (non-binding) > > > > Verified running example DAGs and