Re: [LAZY CONSENSUS] enable string normalization on black

2022-09-22 Thread Pankaj Koti
ing > > > -- > *From:* Felix Uellendall > *Sent:* Wednesday, September 21, 2022 10:35 AM > *To:* dev@airflow.apache.org > *Subject:* RE: [EXTERNAL][LAZY CONSENSUS] enable string normalization on > black > > > *CAUTION*: This email originated

Re: [LAZY CONSENSUS] enable string normalization on black

2022-09-21 Thread Ferruzzi, Dennis
+1 non-binding From: Felix Uellendall Sent: Wednesday, September 21, 2022 10:35 AM To: dev@airflow.apache.org Subject: RE: [EXTERNAL][LAZY CONSENSUS] enable string normalization on black CAUTION: This email originated from outside of the organization. Do

Re: [LAZY CONSENSUS] enable string normalization on black

2022-09-21 Thread Josh Fell
+1 (binding) As a double-quote guy I'm in favor, but having consistency is more important than my style preferences. Love it. On Wed, Sep 21, 2022 at 2:50 PM Drew Hubl wrote: > +1 (non-binding) > > On Sep 21, 2022, at 10:03 AM, Daniel Standish < > daniel.stand...@astronomer.io.INVALID> wrote:

Re: [LAZY CONSENSUS] enable string normalization on black

2022-09-21 Thread Drew Hubl
+1 (non-binding) > On Sep 21, 2022, at 10:03 AM, Daniel Standish > wrote: > > Proposal: remove param --skip-string-normalization on black pre-commit hook > > Discussion thread: > https://lists.apache.org/thread/0g887n3gyr611k908zsz27ccshb85z2n >

Re: [LAZY CONSENSUS] enable string normalization on black

2022-09-21 Thread Felix Uellendall
+1 (binding) Best, Felix Sent from Proton Mail for iOS On Wed, Sep 21, 2022 at 19:10, Ash Berlin-Taylor wrote: > For clarity for those who didn't read the thread: > > This change will be applied just before 2.5 is going to be released (to avoid > making cherry picks difficult) > > -a > > On

Re: [LAZY CONSENSUS] enable string normalization on black

2022-09-21 Thread Ash Berlin-Taylor
For clarity for those who didn't read the thread: This change will be applied just before 2.5 is going to be released (to avoid making cherry picks difficult) -a On 21 September 2022 18:03:19 BST, Daniel Standish wrote: >Proposal: remove param --skip-string-normalization on black pre-commit

[LAZY CONSENSUS] enable string normalization on black

2022-09-21 Thread Daniel Standish
Proposal: remove param --skip-string-normalization on black pre-commit hook Discussion thread: https://lists.apache.org/thread/0g887n3gyr611k908zsz27ccshb85z2n After 72 hours, unless there is an objection, this proposal will be adopted. What is lazy consensus? Read here