Re: Airflow Committers: Landscape checks doing more harm than good?

Oh btw I think I tried to turn it off before and couldn't. I looked at all configuration options on both landscape and GH it just kept doing its thing no matter what. Ended up giving up. Curious to see how it goes this time. On Mar 16, 2017 8:57 PM, "siddharth anand" wrote: >

Re: Airflow Committers: Landscape checks doing more harm than good?

+1 for replacing it with travis linting. On Thu, Mar 16, 2017 at 7:59 PM, Jeremiah Lowin wrote: > FWIW I recently started using yapf (https://github.com/google/yapf) with a > slightly custom config to format all of my projects. Rather than alert to > discrete linting errors

Re: Airflow Committers: Landscape checks doing more harm than good?

FWIW I recently started using yapf (https://github.com/google/yapf) with a slightly custom config to format all of my projects. Rather than alert to discrete linting errors and concrete style rules (like PEP8) -- things I'm sure we all do anyway -- it reformats all code in compliance with your

Re: Make Scheduler More Centralized

Thanks all your comments! Then looks like we should focus on scalability of scheduler now rather than adding more load on it. I will give up this centralized idea now. On Tue, Mar 14, 2017 at 3:08 PM, Rui Wang wrote: > Hi, > The design doc below I created is trying to make

Re: Airflow Committers: Landscape checks doing more harm than good?

Let's wire a custom a linter command that can be called locally and respect an agreed upon set of parameters (pylint + config file, based off of our current .landscape.yml ). flake8 is far from being as good as pylint and can't be customized much AFAICT, but variations on the command bellow can

Re: Airflow Committers: Landscape checks doing more harm than good?

Sounds like a probable consensus. I think this is a good time for me to admit I have no idea how to turn it off or move it to Travis. Could anyone please volunteer to take that on? On Thu, Mar 16, 2017 at 8:11 PM Alex Guziel wrote: > +1 also > > We have code

Re: Airflow Committers: Landscape checks doing more harm than good?

+1 also We have code review already and the amount of false positives makes this useless. On Thu, Mar 16, 2017 at 5:02 PM, Maxime Beauchemin < maximebeauche...@gmail.com> wrote: > +1 as well > > I'm disappointed because the service is inches away from getting everything > right. As Bolke said,

Re: Airflow Committers: Landscape checks doing more harm than good?

+1 as well though I have found it useful on larger PRs to help me catch some issues so it probably makes sense to make to add the travis linting at the same time we remove it in landscape. Not sure how much usability we lose by losing the landscape UI but I like that all of the errors would be in

Re: Airflow Committers: Landscape checks doing more harm than good?

We can do it in Travis’ afaik. We should replace it. So +1. B. > On 16 Mar 2017, at 16:48, Jeremiah Lowin wrote: > > This may be an unpopular opinion, but most Airflow PRs have a little red > "x" next to them not because they have failing unit tests, but because the >

Airflow Committers: Landscape checks doing more harm than good?

This may be an unpopular opinion, but most Airflow PRs have a little red "x" next to them not because they have failing unit tests, but because the Landscape check has decided they introduce bad code. Unfortunately Landscape is often wrong -- here it is telling me my latest PR introduced no less

Re: [VOTE] Release Apache Airflow 1.8.0 (incubating)

Oops, wrong mailing list ;-). > On 16 Mar 2017, at 09:28, Bolke de Bruin wrote: > > Hello Incubator PMC’ers, > > The Apache Airflow community has voted and approved the proposal to release > Apache Airflow 1.8.0 (incubating) based on 1.8.0 Release Candidate 5. We now >

[VOTE] Release Apache Airflow 1.8.0 (incubating)

Hello Incubator PMC’ers, The Apache Airflow community has voted and approved the proposal to release Apache Airflow 1.8.0 (incubating) based on 1.8.0 Release Candidate 5. We now kindly request the Incubator PMC members to review and vote on this incubator release. If the vote is successful we

[RESULT][VOTE]Release Airflow 1.8.0 based on Airflow 1.8.0rc5

Hello, Apache Airflow (incubating) 1.8.0 (RC5) has been accepted. 9 “+1” votes received: - Maxime Beauchemin (binding) - Chris Riccomini (binding) - Arthur Wiedmer (binding) - Jeremiah Lowin (binding) - Siddharth Anand (binding) - Alex van Boxel (binding) - Bolke de Bruin (binding) - Daniel

Re: [VOTE] Release Airflow 1.8.0 based on Airflow 1.8.0rc5

I agree that it is not nice. I suggest that we revisit our fix and see if we can do better there (rather than adding new complexity). And get this into 1.8.1. Nevertheless, I consider the vote passed. Bolke > On 15 Mar 2017, at 19:12, Dan Davydov wrote: > >