Re: Refactor models.py

2018-12-17 Thread Bas Harenslak
Andreas good idea, without that the only way to refactor models.py is a big bang all at once. I made a start and renamed models.py to /airflow/models/__init__.py and moved class Connection to /airflow/models/connection.py (AIRFLOW-3458). PR is here:

Re: Refactor models.py

2018-12-17 Thread Tao Feng
We should merge the existing prs before doing this refactors. Otherwise, there will be so many rebase issues. On Mon, Dec 17, 2018 at 12:37 AM Andreas Költringer < andreas.koeltrin...@n-fuse.co> wrote: > Hi, > > a suggestion to make this process easier: > > a folder could be created called

Re: Refactor models.py

2018-12-17 Thread Andreas Költringer
Hi, a suggestion to make this process easier: a folder could be created called `models`. The `models.py` could then moved into that folder and renamed to `__init__.py`. That way, all the other parts of airflow can be left untouched - it is still possible to run `from models import ` In