Re: PR Review request for url_prefix

2018-01-14 Thread Bolke de Bruin
Not to leave anything to imagination: the middleware logic should be implemented. It would be awesome if Gaetan could do this. Using the application root would be the cherry on the cake. Cheers Bolke Verstuurd vanaf mijn iPad > Op 14 jan. 2018 om 21:44 heeft Arthur Wiedmer

Re: PR Review request for url_prefix

2018-01-14 Thread Arthur Wiedmer
Sounds good. I second your call for more tests and we should update the docs to detail middleware configs. I wasn't sure if migrating the API endpoint was left to later so as not to hinder work on the new webserver, but I guess it should not be a huge deal to accomodate. Gaëtan, I think it

Re: Airflow 1.10

2018-01-14 Thread Bolke de Bruin
Chris, Joy, Can you shed some light on the backward compatibility of the new UI, particularly with regards to the API? The API for example cannot use the login from FAB afaik. As much of the work is already in for 1.10 I think focus should be on polishing. There are some minor quirks and

Re: PR Review request for url_prefix

2018-01-14 Thread Bolke de Bruin
Hi Arthur, I read a little bit further. Indeed the application_setting is used for setting cookies and it isn’t used for changing the base_url. However, a WSGI application (like Airflow) works with mount points to the webserver. This requires a middle-ware configuration which is explained in

Re: Airflow 1.10

2018-01-14 Thread Driesprong, Fokko
I think 1.10 is a good idea. I'm working on this refactoring of the sensor structure: https://github.com/apache/incubator-airflow/pull/2875 Would be awesome to get this in. At my current project we use sensors in a few places, but still there is some work to be done. For example, don't allocate