Hi Kaxil,
On Tue, Jun 12, 2018 at 5:12 PM, Naik Kaxil wrote:
>
> I have merged the PR that reverts the commit that broke the CI. Waiting
> for the CI result.
>
>
I see master is green again! Thanks :)
Cheers,
--
Gerardo Curiel // https://gerar.do
Hi Fokko,
I've been keeping track of the airflow builds just recently. So far I've
seen TravisCI failing because of HTTP errors coming from Ubuntu repos, and
maybe a few timeouts from tar downloads. But the recent ones were
definitely related to bad merges. It seems to me that they can be
identifi
Hi Gerado,
As Fokko mentioned, sometimes the CI breaks because of some flaky test and
sometime just fails due to connectivity issues while downloading required
packages.
If a certain commits break the master, we try to fix it asap.
I have merged the PR that reverts the commit that broke the C
Hi Gerardo,
I totally agree that when master turns red, we should stop merging and fix
the build or revert the commit that broke the build.
I think one of the underlying problems is having flaky tests, I tried to
fix a few of those, but they are quite persistent. Sometimes it is hard to
indentify
+1 for merge blocking hooks. It would be great to have safety knowing that
any commit I revert to will still pass tests (for rebase testing, etc)
On Mon, Jun 11, 2018 at 10:23 PM Alex Tronchin-James 949-412-7220
<(949)%20412-7220> wrote:
> Could we adopt some sort of merge-blocking hook that pro
Could we adopt some sort of merge-blocking hook that prohibits merge of PRs
failing unit tests? My team has such an approach at work and it reduces the
volume of breakage quite a bit. The only time we experience problems now is
where our unit test coverage is poor, but we improve the coverage every
Hi folks,
The master branch has been broken for a couple of days already. But that
hasn't stopped the project from merging pull requests. As time passes by,
it gets hard to identify what change caused the breakage. And of course,
fixing it might cause conflicts with the changes introduced by the m
