- minor: `ForgeTracker/forgetracker/templates/tracker/milestone.html` has
`import 'allura:templates/jinja_master/lib.html` twice
- when on a `page=0` url, then I don't see any `rel="next"` tag. Remember
page=0 means first page in allura! :grin:
- when on a `page=1` url then the `<link rel="prev"
href="/p/test/tickets/milestone/1.0/"/>` doesn't have the fully-qualified URL
with domain
- also when on a ticket search then this `rel="prev"` tag loses the
`?q=...` part of its URL
- the `def querystring` helper is a little complicated, can we have a docstring
to explain what it does? Like "make a new URL based on the current request and
new params" if that is a correct explanation :smile: Maybe even a unit test
too? (you can make a fake request with `Request.blank`
- I think there's a mismatch between passing `count` into
`lib.pagination_meta_tags(` and that macro taking the parameter as `last_page`.
The count of items is not equal to the last page number. Need to divide by
the `limit` size I think to convert `count` into `last_page`.
- probably should include these tags on the main ticket list and the blog main
view too.
---
** [tickets:#8444] Add Canonical Link For Tool Sections **
**Status:** open
**Milestone:** unreleased
**Created:** Tue Jun 28, 2022 05:50 PM UTC by Guillermo Cruz
**Last Updated:** Tue Jun 28, 2022 05:50 PM UTC
**Owner:** Guillermo Cruz
Tools like Tickets, Wikis, Discussions, etc. should include a canonical link.
Also on sections with pagination include `page=x` in the root url and
`rel="next"` `rel="next"` tags
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
