Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

> On Nov. 18, 2014, 9:09 a.m., Nate Cole wrote: > > ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql, lines > > 171-172 > > > > > > Since there's a FK, I'm not sure if this needs to be removed before >

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28159/#review61924 --- Ship it! Ship It! - Nate Cole On Nov. 18, 2014, 9:16 a.m., Jonat

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28159/ --- (Updated Nov. 18, 2014, 9:16 a.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

> On Nov. 18, 2014, 9:09 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java, > > lines 328-331 > > > > > > This is an assumption that a

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28159/#review61920 --- ambari-server/src/main/java/org/apache/ambari/server/controller/int

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

> On Nov. 18, 2014, 8:51 a.m., Tom Beerbower wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java, > > line 333 > > > > > > I think isEmpty() reads nicer

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28159/#review61915 --- Ship it! Looks good. ambari-server/src/main/java/org/apache/ambar

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

> On Nov. 18, 2014, 6:16 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java, > > line 333 > > > > > > Why use `Collection.size() > 0

Re: Review Request 28159: Alerts: Targets Should Support A Severity Level

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28159/#review61899 --- ambari-server/src/main/java/org/apache/ambari/server/controller/int

Review Request 28159: Alerts: Targets Should Support A Severity Level

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28159/ --- Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower. B