Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-26 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/#review103992 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 25, 2015, 12:16

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-26 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/ --- (Updated Жов. 26, 2015, 8:28 після полудня) Review request for Ambari, Dmitro

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-26 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/#review104103 --- Ship it! Ship It! - Sumit Mohanty On Oct. 26, 2015, 8:28 p.m.,

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-26 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/#review104014 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 26, 2015, 4:26

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-26 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/ --- (Updated Жов. 26, 2015, 2:26 після полудня) Review request for Ambari, Dmitro

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-25 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/#review103952 ---

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-24 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/ --- (Updated Жов. 24, 2015, 9:16 після полудня) Review request for Ambari, Dmitro

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-24 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/ --- (Updated Жов. 24, 2015, 8:30 після полудня) Review request for Ambari, Dmitro

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-23 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/ --- (Updated Жов. 23, 2015, 5:02 після полудня) Review request for Ambari, Dmitro

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-23 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/#review103807 --- Ship it! Ship It! - Sumit Mohanty On Oct. 23, 2015, 5:02 p.m.,

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-22 Thread Sumit Mohanty
> On Oct. 22, 2015, 6:14 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 859 > > > > > > type - configuration I meant typo. - Sumit

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-22 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/#review103530 --- ambari-server/sbin/ambari-server (line 148)

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/#review103540 ---

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-22 Thread Vitalyi Brodetskyi
> On Жов. 22, 2015, 6:14 до полудня, Sumit Mohanty wrote: > > ambari-server/sbin/ambari-server, line 148 > > > > > > Updating hostnames done > On Жов. 22, 2015, 6:14 до полудня, Sumit Mohanty wrote: > >

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-22 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/ --- (Updated Жов. 22, 2015, 12:03 після полудня) Review request for Ambari, Dmitro

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-22 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/ --- (Updated Жов. 22, 2015, 11:46 до полудня) Review request for Ambari, Dmitro

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-22 Thread Vitalyi Brodetskyi
> On Жов. 22, 2015, 8:23 до полудня, Dmitro Lisnichenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/update/HostUpdateHelper.java, > > line 197 > > > > > > Seems dangerous to me. > > If

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-22 Thread Vitalyi Brodetskyi
> On Жов. 22, 2015, 5:22 до полудня, Sid Wagle wrote: > > ambari-server/sbin/ambari-server, line 147 > > > > > > Lets call this update-hostname Renamed to update-host-names > On Жов. 22, 2015, 5:22 до полудня,

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-22 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/ --- (Updated Жов. 22, 2015, 11:59 до полудня) Review request for Ambari, Dmitro

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/#review103527 --- ambari-server/sbin/ambari-server (line 147)

Re: Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-21 Thread Sid Wagle
On Oct. 22, 2015, 5:22 a.m., Vitalyi Brodetskyi wrote: > > Any reason to not have written unit tests for this? Ignore this, just saw the update. - Sid --- This is an automatically generated e-mail. To reply, visit:

Review Request 39519: Create a script to change host names for a stopped cluster

2015-10-21 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39519/ --- Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav