Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-16 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/#review106767 --- Ship it! Good find, but surprising though +1. - Sumit Mohanty O

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-16 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/ --- (Updated Nov. 16, 2015, 10:52 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-12 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/#review106284 --- Ship it! Ship It! - Myroslav Papirkovskyy On Лис. 12, 2015, 1:1

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-11 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/ --- (Updated Nov. 11, 2015, 11:19 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-11 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/#review106040 --- @OneToMany(mappedBy = "clusterServiceEntity", cascade = CascadeType

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/#review106025 --- Ship it! Ship it. - Sebastian Toader On Nov. 11, 2015, 4:11 a.m

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-10 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/ --- (Updated Nov. 11, 2015, 3:11 a.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-10 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/ --- (Updated Nov. 11, 2015, 3:10 a.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-10 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/ --- (Updated Nov. 10, 2015, 8:22 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-08 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/ --- (Updated Nov. 9, 2015, 2:59 a.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-08 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/#review105621 --- Ship it! Ship It! - Sebastian Toader On Nov. 7, 2015, 6:47 a.m.

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-06 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/ --- (Updated Nov. 7, 2015, 5:47 a.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-06 Thread Sid Wagle
> On Nov. 6, 2015, 9:52 a.m., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java, > > line 92 > > > > > > Couldn't this constructor just simply call the s

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/#review105424 --- Ship it! Ship It! - Sumit Mohanty On Nov. 5, 2015, 11:38 p.m.,

Re: Review Request 39996: Refactor code that caches stale entity references

2015-11-06 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/#review105387 --- ambari-server/src/main/java/org/apache/ambari/server/state/Service

Review Request 39996: Refactor code that caches stale entity references

2015-11-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39996/ --- Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sebastian T