[GitHub] [incubator-annotator] tilgovi closed issue #51: Range Normalization

2020-08-16 Thread GitBox
tilgovi closed issue #51: URL: https://github.com/apache/incubator-annotator/issues/51 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-annotator] tilgovi commented on issue #51: Range Normalization

2020-08-16 Thread GitBox
tilgovi commented on issue #51: URL: https://github.com/apache/incubator-annotator/issues/51#issuecomment-674593638 I'll close this for now, as it seems like we may not need this at the moment. This is an automated message f

[GitHub] [incubator-annotator] tilgovi commented on issue #75: Support TextPositionSelector (in the dom package)

2020-08-16 Thread GitBox
tilgovi commented on issue #75: URL: https://github.com/apache/incubator-annotator/issues/75#issuecomment-674586963 > The text MUST be normalized before recording the annotation. Thus HTML/XML tags SHOULD be removed and character entities SHOULD be replaced with the character that they en

[GitHub] [incubator-annotator] tilgovi commented on issue #80: highlight range: "not a perfect undo: split text nodes are not merged again"

2020-08-16 Thread GitBox
tilgovi commented on issue #80: URL: https://github.com/apache/incubator-annotator/issues/80#issuecomment-674584836 Is there any action here, or are we okay to leave the nodes split? This is an automated message from the Apa

[GitHub] [incubator-annotator] tilgovi commented on issue #81: sync vs async API

2020-08-16 Thread GitBox
tilgovi commented on issue #81: URL: https://github.com/apache/incubator-annotator/issues/81#issuecomment-674584671 I propose we start by making some attempt to have core pieces of our reusable code allow for synchronous iterators, but keep the asynchronous consumer API. I started