[GitHub] [incubator-annotator] tilgovi commented on a change in pull request #98: Implement TextPositionSelector, create Chunking abstraction

2020-12-10 Thread GitBox
tilgovi commented on a change in pull request #98: URL: https://github.com/apache/incubator-annotator/pull/98#discussion_r540515796 ## File path: packages/dom/src/normalize-range.ts ## @@ -0,0 +1,156 @@ +/** + * @license + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [incubator-annotator] tilgovi commented on a change in pull request #98: Implement TextPositionSelector, create Chunking abstraction

2020-12-10 Thread GitBox
tilgovi commented on a change in pull request #98: URL: https://github.com/apache/incubator-annotator/pull/98#discussion_r540515237 ## File path: packages/dom/src/normalize-range.ts ## @@ -0,0 +1,156 @@ +/** + * @license + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [incubator-annotator] tilgovi commented on a change in pull request #98: Implement TextPositionSelector, create Chunking abstraction

2020-12-10 Thread GitBox
tilgovi commented on a change in pull request #98: URL: https://github.com/apache/incubator-annotator/pull/98#discussion_r540513682 ## File path: .eslintrc.js ## @@ -111,6 +112,7 @@ module.exports = { plugins: ['@typescript-eslint'], rules: { '@typescript