tilgovi commented on issue #113:
URL:
https://github.com/apache/incubator-annotator/issues/113#issuecomment-883097394
Looks like that problem has been reported here:
https://github.com/autarc/optimal-select/issues/70
We could drop the "describe" support for Element -> CSS selector c
tilgovi commented on issue #113:
URL:
https://github.com/apache/incubator-annotator/issues/113#issuecomment-883091895
We are generating ES6 imports/exports. We don't actually ship CommonJS at
all right now. But npm package imports are not valid in the browser because the
browser only allo
tilgovi edited a comment on issue #115:
URL:
https://github.com/apache/incubator-annotator/issues/115#issuecomment-883082208
> One can always make a sync function into async one, but not the other way
around.
Yes, that's the reason for making everything async now. If we compose high
tilgovi commented on issue #115:
URL:
https://github.com/apache/incubator-annotator/issues/115#issuecomment-883082208
> One can always make a sync function into async one, but not the other way
around.
Yes, that's the reason for making everything async now. If we compose higher
lev
DellCliff edited a comment on issue #115:
URL:
https://github.com/apache/incubator-annotator/issues/115#issuecomment-882816203
This kinda smells like speculative generality. IMO I would make those
matchers not adhere to some common interface and let them have their own
signature. A user c
DellCliff commented on issue #115:
URL:
https://github.com/apache/incubator-annotator/issues/115#issuecomment-882816203
This kinda smells like speculative generality. IMO I would make those
matchers not adhere to some common interface and let them have their own
signature. A user can then
Treora commented on issue #115:
URL:
https://github.com/apache/incubator-annotator/issues/115#issuecomment-882519923
You are completely correct that there is no need for the current functions
to be async. The reason they are async is to make it easier to do async stuff
in the future, with
