[GitHub] [incubator-annotator] tilgovi commented on issue #115: Turn AsyncGenerators into Generators

tilgovi commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-883082208 > One can always make a sync function into async one, but not the other way around. Yes, that's the reason for making everything async now. If we compose higher lev

[GitHub] [incubator-annotator] tilgovi edited a comment on issue #115: Turn AsyncGenerators into Generators

tilgovi edited a comment on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-883082208 > One can always make a sync function into async one, but not the other way around. Yes, that's the reason for making everything async now. If we compose high

[GitHub] [incubator-annotator] DellCliff commented on issue #115: Turn AsyncGenerators into Generators

DellCliff commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-882816203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-annotator] DellCliff edited a comment on issue #115: Turn AsyncGenerators into Generators

DellCliff edited a comment on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-882816203 This kinda smells like speculative generality. IMO I would make those matchers not adhere to some common interface and let them have their own signature. A user c

[GitHub] [incubator-annotator] tilgovi commented on issue #113: Can't use after installing via npm (without webpack or similar)

tilgovi commented on issue #113: URL: https://github.com/apache/incubator-annotator/issues/113#issuecomment-883091895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [incubator-annotator] Treora commented on issue #115: Turn AsyncGenerators into Generators

Treora commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-882519923 You are completely correct that there is no need for the current functions to be async. The reason they are async is to make it easier to do async stuff in the future, with

[GitHub] [incubator-annotator] tilgovi commented on issue #115: Turn AsyncGenerators into Generators

tilgovi commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-883082208 > One can always make a sync function into async one, but not the other way around. Yes, that's the reason for making everything async now. If we compose higher lev

[GitHub] [incubator-annotator] tilgovi edited a comment on issue #115: Turn AsyncGenerators into Generators

tilgovi edited a comment on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-883082208 > One can always make a sync function into async one, but not the other way around. Yes, that's the reason for making everything async now. If we compose high

[GitHub] [incubator-annotator] DellCliff edited a comment on issue #115: Turn AsyncGenerators into Generators

DellCliff edited a comment on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-882816203 This kinda smells like speculative generality. IMO I would make those matchers not adhere to some common interface and let them have their own signature. A user c

[GitHub] [incubator-annotator] DellCliff commented on issue #115: Turn AsyncGenerators into Generators

DellCliff commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-882816203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-annotator] tilgovi commented on issue #113: Can't use after installing via npm (without webpack or similar)

tilgovi commented on issue #113: URL: https://github.com/apache/incubator-annotator/issues/113#issuecomment-883091895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [incubator-annotator] Treora commented on issue #115: Turn AsyncGenerators into Generators

Treora commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-882519923 You are completely correct that there is no need for the current functions to be async. The reason they are async is to make it easier to do async stuff in the future, with