[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-18 Thread twogee
GitHub user twogee opened a pull request:

https://github.com/apache/ant-ivy/pull/53

Suppressed warnings

As described in previous PR, all compiler warnings are annotated.
This PR removes a few of them, along with some refactoring.
Changes are grouped in separate commits which are hopefully self-describing.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant-ivy suppressed-warnings

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #53


commit 3781faf7238a3a9dc185a863f8b0582a7c28d1b4
Author: twogee 
Date:   2017-07-18T12:08:13Z

cosmetics

commit ba221a1b4323aa59137886b48c70d2ba3480325f
Author: twogee 
Date:   2017-07-18T12:09:12Z

get rid of suppressed warnings

commit bd0f075d2cecf7d6d86c9ce92ed6727438f06f05
Author: twogee 
Date:   2017-07-18T12:09:52Z

refactor

commit 2f0cd05b6ab4bb84eff3b21ebbc966de23e740f0
Author: twogee 
Date:   2017-07-18T12:10:08Z

fix exceptions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Coding style: import of nested classes

2017-07-18 Thread Gintautas Grigelionis
In my last PR I tried to address inconsistencies with import of nested
classes, such as Map.Entry; some classes, e.g. IvySettings ended up with
foreach loops over both Entry and Map.Entry. So: should qualified names be
encouraged or avoided?

Gintas