[GitHub] ant-ivy issue #55: use the vectorised logo

2018-01-08 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/55
  
Thanks for recapitulating the issues; headers and javadoc corrected.

I tested the xsl using the buildfile provided above (without pointing out 
the xsl explicitly), so I tend to suspect you're picking up an old version of 
Ivy.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



AW: Ivy-2.5.0

2018-01-08 Thread jhm
> What must be done to complete the work on SVG (IVY-922/IVY-450 or resp
> PR-55/PR-60)? If you fine with merging (eventually adjusting the
> contents of SVG), let's do it.

I added a comment on the PR.
For short:
- license header is missed on two files
- improve two JavaDocs
- test: does the fresh built Ivy use the SVG graphics?



> Changes to alleviate IVY-1315/IVY-1419/IVY-1420/IVY-1437 should be
> evaluated by reporters, but nobody responded because the issues are so
> old.
> I would rather close the issues and a open a new issue if needed. I

No. It's just a matter of prioritization by us.



> added test cases for every issue highlighting the specific parts of the
> problem and I can write up separately on the design problem with
> permitting the same attributes on different elements with recursive
> inheritance or using the same attribute name with different semantics
> depending on the element (perhaps in Confluence? or Github wiki?).

Can't understand the problem (haven't that knowledge of Ivy).
IVY-1315 "is related to" IVY-1420, which is resolved.
Is IVY-1315 also resolved? Then just close that issue.



> My opinion on PR-57 is that it addresses another design problem in a
> similarly good-enough fashion. We can handle this like Ant and have a
> Java
> 7 branch (2.5.x) and a Java 8+ branch with further API changes (2.6.x).
> The question is, whether that makes 2.5.x more interesting and is worth
> the extra work?

I wouldn't create an extra branch just for that.
I am more a fan of moving to a newer Java version after that release.

I recap the PR-57:
- multiple changes array->collection
- all are fine expect one
- one central public interface added one new method 
  -- no changes in semantics, but only in method declaration 
(array->collection, generics)
  -- technically one new method and deprecating the old
- this means breaking backwards compatibility
- proposal is adding a 2nd interface extending the original interface and 
adding that new method
  (could be 'inlined' in later Ivy version).

I followed the mail thread 
https://www.mail-archive.com/dev@ant.apache.org/msg46002.html and found another 
problem
- ModuleRules breaks BWC due the same reason (as you pointed it out).

Maybe we should not include this PR into an Ivy-2.5.0 release but instead move 
Ivy-2.6.0 to Java8 and change these parts in a (IMO) right but backwards 
incompatible way.



Jan


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #63: IVY-1486 respect exclude regardless of order

2018-01-08 Thread twogee
GitHub user twogee opened a pull request:

https://github.com/apache/ant-ivy/pull/63

IVY-1486 respect exclude regardless of order



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant-ivy ivy-1486

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #63


commit c2601118d9a41aac00a0c0eb89279095d9a83712
Author: twogee 
Date:   2018-01-09T07:04:42Z

IVY-1486 respect exclude regardless of order




---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ivy-2.5.0

2018-01-08 Thread Jaikiran Pai

Hi Jan,

My efforts to resolve IVY-1485 have taken longer than I expected, mainly 
due to not finding enough time to sort it out. A few weekends I tried to 
focus on this, with my local WIP changes, I ran into merge issues with 
the latest upstream changes. I resolved them then and continued with the 
WIP changes. But a few weeks down the line I ran into the merge 
conflicts again. I haven't yet been able to find time to resolve them 
locally and spend time on the real fix (I do admit that I lost a bit of 
focus/interest with the merges).


I'll try again this weekend and see how far I can get this working. 
Either way, I don't want to block the release anymore. If I can't get 
IVY-1485 solved by this weekend, I propose to have it marked as a known 
issue for this release and I will try and get it out in the next release 
after that.


As you note, we do have good number of fixes in this release and it's 
time that we have them available to the general public.


-Jaikiran


On 08/01/18 8:18 PM, Jan Matèrne (jhm) wrote:

I took my old TODO list for Ivy-2.5.0.

Most of them are still open, how to deal with that?

In my opinion we should try to get a release out and postpone these to a
2.5.1 (means reducing stopper->later).

We have lots of changes we could deliver in this way. We also show a sign of
life in that way.

  

  


Jan

  

  

  


- https://issues.apache.org/jira/browse/IVY-1485

   Incorrect revision of dependencies put in to delivered Ivy files

   Status:

 11.09.2017: Jaikiran wanted to focus on that

   prio: stopper ("but it was IVY-1485 which reanimated the community")

  


- SVG-graphics

   Status:

 08.01.2018: unknown

   prio: should be included, as it seems to be nearly finished (for me)

  


- https://github.com/apache/ant-ivy/pull/60

   use Unicode glyphs or SVG data URLs instead of bitmaps

   Status:

 11.09.2017: review required

 08.01.2018: not sure what to do or what impact this have

   prio: should be included (as part of the "svg-bulk")

  


- https://github.com/apache/ant-ivy/pull/57

   fix the last inconsistencies in generics

   Status:

 11.09.2017: This includes a change which breaks BC

 08.01.2018: no consense on the API change

   prio: solve that or delay (this PR should not delay the new version in my
opinion)

  


- https://github.com/apache/ant-ivy/pull/55

   use the vectorised logo

   Status:

 11.09.2017: nearly finished (missing header)

 08.01.2018: no changes (license header missing)

   prio: include that as is nearly finished

  


- https://issues.apache.org/jira/browse/IVY-1420

   defaultconfmapping on  element is not written to
delivered ivy file

   Status:

 11.09.2017: "I need about a week"

 08.01.2018: done (27.09.2017)

   prio: should be included

  


- upgrading BouncyCastle

   Status: done

  


- IVY-1420/IVY-1437, defaultconf/defaultconfmapping/confmappingoverride
attributes

   "according to ivy.xsd, all three attributes can be used on both
dependencies and configurations.

   So, it's the documentation that must be adjusted accordingly"

   Status:

 11.09.2017: open

 08.01.2018: done

   prio: maybe delay (and open a Jira ticket)

  

  






-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #55: use the vectorised logo

2018-01-08 Thread janmaterne
Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/55
  
Still open are:

IvyLogo.java

JavaDoc of the parameters of IvyLogo(int width, int height) are bad 
("ditto")

test the report 
But a simple ivy:report didnt work, I changed build.xml:500 to use 
explicitly the new xsl

Maybe my local environment ...
--> does the fresh built Ivy use the SVG graphics?

Violations of the license header:

ivy-lierre.svg (header missing, remove the generator comment)
IvyLogo (header missing)



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ivy-2.5.0

2018-01-08 Thread Gintautas Grigelionis
What must be done to complete the work on SVG (IVY-922/IVY-450 or resp
PR-55/PR-60)? If you fine with merging (eventually adjusting the contents
of SVG), let's do it.

Changes to alleviate IVY-1315/IVY-1419/IVY-1420/IVY-1437 should be
evaluated by reporters, but nobody responded because the issues are so old.
I would rather close the issues and a open a new issue if needed. I added
test cases for every issue highlighting the specific parts of the problem
and I can write up separately on the design problem with permitting the
same attributes on different elements with recursive inheritance or using
the same attribute name with different semantics depending on the element
(perhaps in Confluence? or Github wiki?).

My opinion on PR-57 is that it addresses another design problem in a
similarly good-enough fashion. We can handle this like Ant and have a Java
7 branch (2.5.x) and a Java 8+ branch with further API changes (2.6.x). The
question is, whether that makes 2.5.x more interesting and is worth the
extra work?

Gintas


2018-01-08 14:48 GMT+00:00 Jan Matèrne (jhm) :

> I took my old TODO list for Ivy-2.5.0.
>
> Most of them are still open, how to deal with that?
>
> In my opinion we should try to get a release out and postpone these to a
> 2.5.1 (means reducing stopper->later).
>
> We have lots of changes we could deliver in this way. We also show a sign
> of
> life in that way.
>
>
>
>
>
> Jan
>
>
>
>
>
>
>
> - https://issues.apache.org/jira/browse/IVY-1485
>
>   Incorrect revision of dependencies put in to delivered Ivy files
>
>   Status:
>
> 11.09.2017: Jaikiran wanted to focus on that
>
>   prio: stopper ("but it was IVY-1485 which reanimated the community")
>
>
>
> - SVG-graphics
>
>   Status:
>
> 08.01.2018: unknown
>
>   prio: should be included, as it seems to be nearly finished (for me)
>
>
>
> - https://github.com/apache/ant-ivy/pull/60
>
>   use Unicode glyphs or SVG data URLs instead of bitmaps
>
>   Status:
>
> 11.09.2017: review required
>
> 08.01.2018: not sure what to do or what impact this have
>
>   prio: should be included (as part of the "svg-bulk")
>
>
>
> - https://github.com/apache/ant-ivy/pull/57
>
>   fix the last inconsistencies in generics
>
>   Status:
>
> 11.09.2017: This includes a change which breaks BC
>
> 08.01.2018: no consense on the API change
>
>   prio: solve that or delay (this PR should not delay the new version in my
> opinion)
>
>
>
> - https://github.com/apache/ant-ivy/pull/55
>
>   use the vectorised logo
>
>   Status:
>
> 11.09.2017: nearly finished (missing header)
>
> 08.01.2018: no changes (license header missing)
>
>   prio: include that as is nearly finished
>
>
>
> - https://issues.apache.org/jira/browse/IVY-1420
>
>   defaultconfmapping on  element is not written to
> delivered ivy file
>
>   Status:
>
> 11.09.2017: "I need about a week"
>
> 08.01.2018: done (27.09.2017)
>
>   prio: should be included
>
>
>
> - upgrading BouncyCastle
>
>   Status: done
>
>
>
> - IVY-1420/IVY-1437, defaultconf/defaultconfmapping/confmappingoverride
> attributes
>
>   "according to ivy.xsd, all three attributes can be used on both
> dependencies and configurations.
>
>   So, it's the documentation that must be adjusted accordingly"
>
>   Status:
>
> 11.09.2017: open
>
> 08.01.2018: done
>
>   prio: maybe delay (and open a Jira ticket)
>
>
>
>
>
>


Ivy-2.5.0

2018-01-08 Thread jhm
I took my old TODO list for Ivy-2.5.0.

Most of them are still open, how to deal with that?

In my opinion we should try to get a release out and postpone these to a
2.5.1 (means reducing stopper->later).

We have lots of changes we could deliver in this way. We also show a sign of
life in that way.

 

 

Jan

 

 

 

- https://issues.apache.org/jira/browse/IVY-1485

  Incorrect revision of dependencies put in to delivered Ivy files

  Status:

11.09.2017: Jaikiran wanted to focus on that

  prio: stopper ("but it was IVY-1485 which reanimated the community")

 

- SVG-graphics

  Status:

08.01.2018: unknown

  prio: should be included, as it seems to be nearly finished (for me)

 

- https://github.com/apache/ant-ivy/pull/60

  use Unicode glyphs or SVG data URLs instead of bitmaps

  Status: 

11.09.2017: review required

08.01.2018: not sure what to do or what impact this have

  prio: should be included (as part of the "svg-bulk")

 

- https://github.com/apache/ant-ivy/pull/57

  fix the last inconsistencies in generics

  Status: 

11.09.2017: This includes a change which breaks BC

08.01.2018: no consense on the API change

  prio: solve that or delay (this PR should not delay the new version in my
opinion)

 

- https://github.com/apache/ant-ivy/pull/55

  use the vectorised logo

  Status: 

11.09.2017: nearly finished (missing header)

08.01.2018: no changes (license header missing)

  prio: include that as is nearly finished

 

- https://issues.apache.org/jira/browse/IVY-1420

  defaultconfmapping on  element is not written to
delivered ivy file

  Status: 

11.09.2017: "I need about a week"

08.01.2018: done (27.09.2017)

  prio: should be included

 

- upgrading BouncyCastle

  Status: done

 

- IVY-1420/IVY-1437, defaultconf/defaultconfmapping/confmappingoverride
attributes

  "according to ivy.xsd, all three attributes can be used on both
dependencies and configurations. 

  So, it's the documentation that must be adjusted accordingly"

  Status: 

11.09.2017: open

08.01.2018: done

  prio: maybe delay (and open a Jira ticket)